In order to conform to best practices for performance staff client template javascript should be in the footer instead of the header. This patch will do so for the patrons and circulation administration templates.
Created attachment 69058 [details] [review] Bug 19603: Move admin templates JavaScript to the footer: Patrons and circulation This patch modifies the staff client patrons and circulation-related administration templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of each modified template: All button controls, DataTables functionality, tabs, etc.
Hi Owen, I was unable to apply this patch : fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt).
Did you apply the patch for Bug 19594 first?
Yes I did, followed the same steps as for signing off bug 19601.
Created attachment 69201 [details] [review] Bug 19603: Move admin templates JavaScript to the footer: Patrons and circulation This patch modifies the staff client patrons and circulation-related administration templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of each modified template: All button controls, DataTables functionality, tabs, etc.
can't apply the patch, I tried a git reset --hard origin/master without success: fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt). error: could not build fake ancestor Patch failed at 0001 Bug 19603: Move admin templates JavaScript to the footer: Patrons and circulation
Created attachment 69311 [details] [review] Bug 19603: Move admin templates JavaScript to the footer: Patrons and circulation This patch modifies the staff client patrons and circulation-related administration templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of each modified template: All button controls, DataTables functionality, tabs, etc. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Created attachment 69734 [details] [review] Bug 19603: Move admin templates JavaScript to the footer: Patrons and circulation This patch modifies the staff client patrons and circulation-related administration templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of each modified template: All button controls, DataTables functionality, tabs, etc. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Edit: Rebased
Dependency still needs sign-off - moving to BLOCKED for now. Please move it back once the dependency is ready for QA.
Created attachment 70152 [details] [review] Bug 19603: Move admin templates JavaScript to the footer: Patrons and circulation This patch modifies the staff client patrons and circulation-related administration templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of each modified template: All button controls, DataTables functionality, tabs, etc. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Edit: Rebased Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 70153 [details] [review] Bug 19603: (QA follow-up) Remove unused message Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Pushed to master for 18.05, thanks to everybody involved!
Enhancement, skipping for 17.11.x. Awesome work everybody!