In order to conform to best practices for performance staff client template javascript should be in the footer instead of the header. This patch will do so for some cataloging templates: addbooks.tt, linkitem.tt, merge.tt, z3950_auth_search.tt, z3950_search.tt
Created attachment 69145 [details] [review] Bug 19623 - Move template JavaScript to the footer: Cataloging This patch modifies some staff client cataloging templates so that JavaScript is included in the footer instead of the header. Several cataloging templates are excluded because they require significant structural changes: addbiblio.tt, additem.tt, and editor.tt To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. Note that z350_auth_search.tt is tested by performing a Z39.50 search from the Authorities module.
Created attachment 69163 [details] [review] Bug 19623 - Move template JavaScript to the footer: Cataloging This patch modifies some staff client cataloging templates so that JavaScript is included in the footer instead of the header. Several cataloging templates are excluded because they require significant structural changes: addbiblio.tt, additem.tt, and editor.tt To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. Note that z350_auth_search.tt is tested by performing a Z39.50 search from the Authorities module. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
With this patch applied, the Z39.50 search window remains empty. Owen, can you please check? Tested on kohadevbox with the sample data.
Created attachment 70118 [details] [review] Bug 19623: (Follow-up) Correct footer include in pop-up windows This patch corrects the footer include in two templates for Z39.50 pop-up windows. popup-bottom.inc shouldn't be used because it doesn't have the JavaScript embed code in it. To test, perform a Z39.50 search from both the MARC bibliographic editor and the MARC authority editor. In both cases the Z39.50 popup window should work correctly.
Created attachment 70144 [details] [review] Bug 19623 - Move template JavaScript to the footer: Cataloging This patch modifies some staff client cataloging templates so that JavaScript is included in the footer instead of the header. Several cataloging templates are excluded because they require significant structural changes: addbiblio.tt, additem.tt, and editor.tt To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. Note that z350_auth_search.tt is tested by performing a Z39.50 search from the Authorities module. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 70145 [details] [review] Bug 19623: (Follow-up) Correct footer include in pop-up windows This patch corrects the footer include in two templates for Z39.50 pop-up windows. popup-bottom.inc shouldn't be used because it doesn't have the JavaScript embed code in it. To test, perform a Z39.50 search from both the MARC bibliographic editor and the MARC authority editor. In both cases the Z39.50 popup window should work correctly. Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 70146 [details] [review] Bug 19623: (QA follow-up) Add missing footerjs variable in merge.tt Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Pushed to master for 18.05, thanks to everybody involved!
Enhancement, skipping for 17.11.x. Awesome work everybody!