I have an idea for how to move JavaScript in additem.tt and addbiblio.tt to the footer, but the JavaScript generated by the plugin scripts needs some cleanup before that can happen. Specifically, single line JS comments (// ... ) will break the script if whitespace in the script is collapsed. These will be changed to multi-line comments (/* ... */). While I'm making changes I'll be removing the <script> tag's "type" attribute and obsolete "//<![CDATA[" markers.
Created attachment 104239 [details] [review] Bug 25354: Clean up JavaScript markup in cataloging plugin scripts This patch makes some minor changes to the JavaScript generated by the cataloging plugins: <script> "type" attribute removed; single-line comments converted to multi-line style; obsolete //<![CDATA[ marks removed. These changes help the JavaScript conform to current coding guidelines. The comment style change allows for whitespace in the scripts to be collapsed by the Template::Toolkit "collapse" filter. Since the patch makes small cosmetic changes to many files it may be easiest to test this patch by visually inspecting the changes. It's also simple to test some plugins which are enabled by default (at least in MARC21): In the basic MARC editor, the leader, 007, and 008. In the item editor, subfield d - Date acquired.
Created attachment 109857 [details] [review] Bug 25354: Clean up JavaScript markup in cataloging plugin scripts This patch makes some minor changes to the JavaScript generated by the cataloging plugins: <script> "type" attribute removed; single-line comments converted to multi-line style; obsolete //<![CDATA[ marks removed. These changes help the JavaScript conform to current coding guidelines. The comment style change allows for whitespace in the scripts to be collapsed by the Template::Toolkit "collapse" filter. Since the patch makes small cosmetic changes to many files it may be easiest to test this patch by visually inspecting the changes. It's also simple to test some plugins which are enabled by default (at least in MARC21): In the basic MARC editor, the leader, 007, and 008. In the item editor, subfield d - Date acquired.
Created attachment 111047 [details] [review] Bug 25354: Clean up JavaScript markup in cataloging plugin scripts This patch makes some minor changes to the JavaScript generated by the cataloging plugins: <script> "type" attribute removed; single-line comments converted to multi-line style; obsolete //<![CDATA[ marks removed. These changes help the JavaScript conform to current coding guidelines. The comment style change allows for whitespace in the scripts to be collapsed by the Template::Toolkit "collapse" filter. Since the patch makes small cosmetic changes to many files it may be easiest to test this patch by visually inspecting the changes. It's also simple to test some plugins which are enabled by default (at least in MARC21): In the basic MARC editor, the leader, 007, and 008. In the item editor, subfield d - Date acquired. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 111537 [details] [review] Bug 25354: Clean up JavaScript markup in cataloging plugin scripts This patch makes some minor changes to the JavaScript generated by the cataloging plugins: <script> "type" attribute removed; single-line comments converted to multi-line style; obsolete //<![CDATA[ marks removed. These changes help the JavaScript conform to current coding guidelines. The comment style change allows for whitespace in the scripts to be collapsed by the Template::Toolkit "collapse" filter. Since the patch makes small cosmetic changes to many files it may be easiest to test this patch by visually inspecting the changes. It's also simple to test some plugins which are enabled by default (at least in MARC21): In the basic MARC editor, the leader, 007, and 008. In the item editor, subfield d - Date acquired. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 20.11, thanks to everybody involved!
enhancement will not be backported to 20.05.x