Bug 19680 - Move JS to the footer: Patron and circulation tools
Summary: Move JS to the footer: Patron and circulation tools
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Owen Leonard
QA Contact: Josef Moravec
URL:
Keywords:
Depends on: 19647
Blocks: 17858
  Show dependency tree / graph
 
Reported: 2017-11-22 17:12 UTC by Owen Leonard
Modified: 2018-12-03 20:04 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 19680: Move JS to the footer: Patron and circulation tools (18.12 KB, patch)
2017-11-22 19:07 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 19680: Move JS to the footer: Patron and circulation tools (18.18 KB, patch)
2017-12-05 12:55 UTC, Claire Gravely 		Details | Diff | Splinter Review
Bug 19680: Move JS to the footer: Patron and circulation tools (18.24 KB, patch)
2017-12-06 17:07 UTC, Josef Moravec 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2017-11-22 17:12:40 UTC 
In order to conform to best practices for performance, staff client template JavaScript should be in the footer instead of the header.

This patch will do so for some patron and circulation-related tools.
Comment 1 Owen Leonard 2017-11-22 19:07:02 UTC 
Created attachment 69290 [details] [review]
Bug 19680: Move JS to the footer: Patron and circulation tools

This patch modifies more staff client patrons and circulation tools
templates so that JavaScript is included in the footer instead of the
header.

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
form validation, etc.

  - Batch patron deletion/anonymization
  - Overdue notice/status triggers
  - Batch patron modification
Comment 2 Claire Gravely 2017-12-05 12:55:39 UTC 
Created attachment 69501 [details] [review]
Bug 19680: Move JS to the footer: Patron and circulation tools

This patch modifies more staff client patrons and circulation tools
templates so that JavaScript is included in the footer instead of the
header.

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
form validation, etc.

  - Batch patron deletion/anonymization
  - Overdue notice/status triggers
  - Batch patron modification

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Comment 3 Josef Moravec 2017-12-06 17:07:07 UTC 
Created attachment 69569 [details] [review]
Bug 19680: Move JS to the footer: Patron and circulation tools

This patch modifies more staff client patrons and circulation tools
templates so that JavaScript is included in the footer instead of the
header.

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
form validation, etc.

  - Batch patron deletion/anonymization
  - Overdue notice/status triggers
  - Batch patron modification

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 4 Jonathan Druart 2017-12-11 14:37:18 UTC 
Pushed to master for 18.05, thanks to everybody involved!
Comment 5 Nick Clemens (kidclamp) 2017-12-14 17:59:23 UTC 
Awesome work all! Skipping for 17.11, enhancement.