In order to conform to best practices for performance, staff client template JavaScript should be in the footer instead of the header. This patch will do so for the patron lists templates.
Created attachment 69202 [details] [review] Bug 19647: Move patron lists templates JS to the footer This patch modifies the staff client patron lists templates so that JavaScript is included in the footer instead of the header. This patch adds a new JS file, tools-menu.js, which will be added to each template which has the Tools sidebar menu. Highlighting of the current page in the sidebar menu will be broken for pages which have not been modified to use this file. To test, apply the patch and test the JavaScript-driven features of each modified template: All button controls, DataTables functionality, form validation, etc.
Looks good to me! I'm having trouble signing it off though: Failed to attach patch to bug 19647, status=200 Maybe if someone else could attach it...
Created attachment 69211 [details] [review] Bug 19647: Move patron lists templates JS to the footer This patch modifies the staff client patron lists templates so that JavaScript is included in the footer instead of the header. This patch adds a new JS file, tools-menu.js, which will be added to each template which has the Tools sidebar menu. Highlighting of the current page in the sidebar menu will be broken for pages which have not been modified to use this file. To test, apply the patch and test the JavaScript-driven features of each modified template: All button controls, DataTables functionality, form validation, etc. resolved the issue, sorry about that, everything is working fine!Signed-off-by: Dominic Pichette <dominic@inlibro.com>
Created attachment 69556 [details] [review] Bug 19647: Move patron lists templates JS to the footer This patch modifies the staff client patron lists templates so that JavaScript is included in the footer instead of the header. This patch adds a new JS file, tools-menu.js, which will be added to each template which has the Tools sidebar menu. Highlighting of the current page in the sidebar menu will be broken for pages which have not been modified to use this file. To test, apply the patch and test the JavaScript-driven features of each modified template: All button controls, DataTables functionality, form validation, etc. resolved the issue, sorry about that, everything is working fine!Signed-off-by: Dominic Pichette <dominic@inlibro.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Pushed to master for 18.05, thanks to everybody involved!
Awesome work all! Skipping for 17.11, enhancement