In order to conform to best practices for performance, staff client template JavaScript should be in the footer instead of the header. This patch will do so for two patron-related tools which also incorporate elements from the Patrons module, requiring a dependency on Bug 19641: Import patrons and Upload patron images.
Created attachment 69292 [details] [review] Bug 19682: Move JS to the footer: Two patron-related tools This patch modifies two patron-related tools templates in the staff client so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of each modified template: All button controls, DataTables functionality, form validation, etc. - Import patrons - Upload patron images
Hullo, issue when applying dependencies: Applying: Bug 19560: Correctly escape branchcode in admin/branches.pl fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge.
I did some rebasing to other bugs this morning so I think this is ready to test.
Created attachment 69737 [details] [review] Bug 19682: Move JS to the footer: Two patron-related tools This patch modifies two patron-related tools templates in the staff client so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of each modified template: All button controls, DataTables functionality, form validation, etc. - Import patrons - Upload patron images Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
One of the dependencies is not in the QA queue yet, moving to BLOCKED for now, please move back once dependencies have been sorted.
The datepicker in import patrons tool is shown only by dateofbirth field. Should be also on dateexpiry and dateenrolled.
Created attachment 70467 [details] [review] Bug 19682: Move JS to the footer: Two patron-related tools This patch modifies two patron-related tools templates in the staff client so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of each modified template: All button controls, DataTables functionality, form validation, etc. - Import patrons - Upload patron images Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Edit for QA: Fixed datepickers on import patron form
Created attachment 71293 [details] [review] Bug 19682: Move JS to the footer: Two patron-related tools This patch modifies two patron-related tools templates in the staff client so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of each modified template: All button controls, DataTables functionality, form validation, etc. - Import patrons - Upload patron images Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Edit for QA: Fixed datepickers on import patron form Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Pushed to master for 18.05, thanks to everybody involved!