In order to conform to best practices for performance staff client template javascript should be in the footer instead of the header. This patch will do so for plugins templates.
Created attachment 69419 [details] [review] Bug 19710: Move plugins templates javascript to the footer This patch modifies the staff client plugins template so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the modified template: - The plugins link should be bold in the sidebar menu. - Choosing "Uninstall" for an installed plugin should trigger a confirmation alert.
Created attachment 69421 [details] [review] Bug 19710: Move plugins templates javascript to the footer This patch modifies the staff client plugins template so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the modified template: - The plugins link should be bold in the sidebar menu. - Choosing "Uninstall" for an installed plugin should trigger a confirmation alert. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Created attachment 69561 [details] [review] Bug 19710: Move plugins templates javascript to the footer This patch modifies the staff client plugins template so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the modified template: - The plugins link should be bold in the sidebar menu. - Choosing "Uninstall" for an installed plugin should trigger a confirmation alert. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Pushed to master for 18.05, thanks to everybody involved!
Awesome work all! Skipping for 17.11, enhancement.