Some libraries use a combination of borrowers surname and cardnumber on hold slips, this seems to be a fairly common occurence. To facilitate this it would be nice to have the cardnumber available on the waiting holds report. Additionally it would be nice to have classes add to the borrower information so that they can be accessed via javascript for constructing the special code used.
Created attachment 69607 [details] [review] Bug 19770 - Add cardnumber to holds awaiting pickup and add classes to borrower info To Test: 1 - View the holds awaiting pickup report 2 - Note there is no cardnumber 3 - Apply patch 4 - Cardnumber now shows 5 - Add to IntranetUserCSS .borrowercardnumber { display: none; } 6 - Cardnumber does not show 7 - Verify the same works for 'Holds over' tab 8 - Sign off
Created attachment 69612 [details] [review] Bug 19770 - Add cardnumber to holds awaiting pickup and add classes to borrower info To Test: 1 - View the holds awaiting pickup report 2 - Note there is no cardnumber 3 - Apply patch 4 - Cardnumber now shows 5 - Add to IntranetUserCSS .borrowercardnumber { display: none; } 6 - Cardnumber does not show 7 - Verify the same works for 'Holds over' tab 8 - Sign off Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Why did not you choose to use patron-title.inc?
I am sorry, patch doesn't apply. Can you please rebase?
I think Joubu is right, this should be done using patron-title.inc and that should be adding the spans
Created attachment 83919 [details] [review] Bug 19770: Add cardnumber and CSS classed to patron info on waiting holds Patch makes use fo patron-string.inc for displaying the patron information on the waiting holds report. It also adds spans with classes for phone and email. To Test: 1 - View the holds awaiting pickup report 2 - Note there is no cardnumber for the patron 3 - Apply patch 4 - Cardnumber shows now 5 - Verify the same works for 'Holds over' tab
Created attachment 84224 [details] [review] Bug 19770: Add cardnumber and CSS classed to patron info on waiting holds Patch makes use fo patron-string.inc for displaying the patron information on the waiting holds report. It also adds spans with classes for phone and email. To Test: 1 - View the holds awaiting pickup report 2 - Note there is no cardnumber for the patron 3 - Apply patch 4 - Cardnumber shows now 5 - Verify the same works for 'Holds over' tab Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Created attachment 84270 [details] [review] Bug 19770: Add cardnumber and CSS classed to patron info on waiting holds Patch makes use fo patron-string.inc for displaying the patron information on the waiting holds report. It also adds spans with classes for phone and email. To Test: 1 - View the holds awaiting pickup report 2 - Note there is no cardnumber for the patron 3 - Apply patch 4 - Cardnumber shows now 5 - Verify the same works for 'Holds over' tab Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Awesome work all! Pushed to master for 19.05
Enhancement, will not be backported to 18.11.x series.