Bug 13024 - Nonpublic note not appearing in the staff client added the nonpublic note to the 1) Checkouts (circulation.pl) 2) Checkins (returns.pl) 3) Record details ( moredetail.pl ) There is currently no class to hide on of those locations if a library wants to hide a non public note. Can we add a class to items.itemnotes_nonpublic so libraries have the choice to hide one of the locations listed above.
Created attachment 69801 [details] [review] Bug 19806 - Add classes to itemnotes in issues table To test: 1 - Checkout an item with both public and non-public notes 2 - Note the notes display and both have circ-hlt class 3 - Apply patch 4 - Ensure display has not changed 5 - Note notes now have classes 'item-note-public' and 'item-note-nonpublic' 6 - Sign off
Created attachment 69803 [details] [review] Bug 19806: Add classes to itemnotes in issues table To test: 1 - Checkout an item with both public and non-public notes 2 - Note the notes display and both have circ-hlt class 3 - Apply patch 4 - Ensure display has not changed 5 - Note notes now have classes 'item-note-public' and 'item-note-nonpublic' 6 - Sign off Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 69818 [details] [review] Bug 19806: Add classes to itemnotes in issues table To test: 1 - Checkout an item with both public and non-public notes 2 - Note the notes display and both have circ-hlt class 3 - Apply patch 4 - Ensure display has not changed 5 - Note notes now have classes 'item-note-public' and 'item-note-nonpublic' 6 - Sign off Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
The only thing I could say is that item-note- does not fully match the field name itemnotes :) Which is no problem to me!
(In reply to Marcel de Rooy from comment #4) > The only thing I could say is that item-note- does not fully match the field > name itemnotes :) Which is no problem to me! Ah, yes, I copied the classes I found on returns.tt, figured the same css could be used consistently then.
Pushed to master for 18.05, thanks to everybody involved!
Awesome work all! Pushed to stable for 17.11.01
Pushed to 17.05.x for v17.05.10