Created attachment 70065 [details] ScreenShot Prior to the 17.05 upgrade when you did a z39.50 search and then viewed the MARC record prior to import, a side scroll bar would appear at the bottom of the window, however, in 17.05 you have to scroll to the bottom of the window before the side scroll bar appears.
+1
Created attachment 128573 [details] [review] Bug 19865: Add back horizontal scrollbar to cat_z3950_search To test: 1. Do a Z39.50/SRU search 2. In the search results click on MARC to get the MARC preview. Choose something with lots of MARC data so it is both wide and long. 3. See the Y axis scrollbar 4. You must scroll bottom of the modal to see the X axis scrollbar, annoying. 5. Apply patch 6. Regenrate the CSS files ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface ) 7. Try steps 1-4 again. This time you should see the X axis scrollbar without having to scroll to the bottom. 8. It's not a bad idea to test in multiple browsers.
Since this change affects only one page and there is already some inline CSS on that page I think it's better to add it to the template and not the global SCSS file.
Created attachment 129677 [details] [review] Bug 19865: Add back horizontal scroll bar To test: 1. Do a Z39.50/SRU search 2. In the search results click on MARC to get the MARC preview. Choose something with lots of MARC data so it is both wide and long. 3. See the Y axis scrollbar 4. You must scroll bottom of the modal to see the X axis scrollbar, annoying. 5. Apply patch 6. Try steps 1-4 again. This time you should see the X axis scrollbar without having to scroll to the bottom. 7. It's not a bad idea to test in multiple browsers. Note: I also put the CSS onto multiple lines to increase readability
Created attachment 129695 [details] [review] Bug 19865: Add back horizontal scroll bar To test: 1. Do a Z39.50/SRU search 2. In the search results click on MARC to get the MARC preview. Choose something with lots of MARC data so it is both wide and long. 3. See the Y axis scrollbar 4. You must scroll bottom of the modal to see the X axis scrollbar, annoying. 5. Apply patch 6. Try steps 1-4 again. This time you should see the X axis scrollbar without having to scroll to the bottom. 7. It's not a bad idea to test in multiple browsers. Note: I also put the CSS onto multiple lines to increase readability Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Looks like the acquisition view needs something for the scroll bar as well: https://snipboard.io/XpC3IS.jpg
Created attachment 129905 [details] [review] Bug 19865: Add back horizontal scroll bar To test: 1. Do a Z39.50/SRU search 2. In the search results click on MARC to get the MARC preview. Choose something with lots of MARC data so it is both wide and long. 3. See the Y axis scrollbar 4. You must scroll bottom of the modal to see the X axis scrollbar, annoying. 5. Apply patch 6. Try steps 1-4 again. This time you should see the X axis scrollbar without having to scroll to the bottom. 7. It's not a bad idea to test in multiple browsers. Note: I also put the CSS onto multiple lines to increase readability Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(In reply to Jonathan Druart from comment #6) > Looks like the acquisition view needs something for the scroll bar as well: > https://snipboard.io/XpC3IS.jpg Yes, I have filed Bug 29961 and will do it there.
Pushed to master for 22.05, thanks to everybody involved [U+1F984]
Pushed to 21.11.x for 21.11.03
Pushed to 21.05.x for 21.05.11
Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed.