Bug 29961 - Horizontal scroll bar in acquisition z39.50 search should always show
Summary: Horizontal scroll bar in acquisition z39.50 search should always show
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Lucas Gass
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-27 16:36 UTC by Lucas Gass
Modified: 2023-06-08 22:26 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00, 22.05.01, 21.11.07


Attachments
Bug 29961: Make horizontal scroll bar always visible on acqui/z3950_search.pl (1.78 KB, patch)
2022-01-27 17:01 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 29961: Make horizontal scroll bar always visible on acqui/z3950_search.pl (1.83 KB, patch)
2022-05-31 03:35 UTC, David Nind
Details | Diff | Splinter Review
Bug 29961: Make horizontal scroll bar always visible on acqui/z3950_search.pl (1.91 KB, patch)
2022-05-31 08:09 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass 2022-01-27 16:36:37 UTC
Just like Bug 19865 we should fix this view in the z39.50 acquisition search so one doesn't have to scroll all the way to the bottom in order to see it
Comment 1 Lucas Gass 2022-01-27 17:01:18 UTC
Created attachment 129914 [details] [review]
Bug 29961: Make horizontal scroll bar always visible on acqui/z3950_search.pl

To test:
1. In Acquisitions make a basket and add something "From an external source"
2. Search for a title and click on the 'MARC' button, make sure the MARC prview is both tall and wide.
3. You will not see the horizontal scroll bar unless you scroll all the way to the bottom of the preview.
4. Apply patch.
5. Try steps 1 & 2 again, this time you should see the horizontal scroll bar as soon as the MARC prveiw loads.

Note: I put the CSS on multiple lines for better readability
Comment 2 David Nind 2022-05-31 03:35:01 UTC
Created attachment 135459 [details] [review]
Bug 29961: Make horizontal scroll bar always visible on acqui/z3950_search.pl

To test:
1. In Acquisitions make a basket and add something "From an external source"
2. Search for a title and click on the 'MARC' button, make sure the MARC prview is both tall and wide.
3. You will not see the horizontal scroll bar unless you scroll all the way to the bottom of the preview.
4. Apply patch.
5. Try steps 1 & 2 again, this time you should see the horizontal scroll bar as soon as the MARC prveiw loads.

Note: I put the CSS on multiple lines for better readability

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Jonathan Druart 2022-05-31 08:09:22 UTC
As you are reusing the same code as bug 19865 it would have been better to have the rules defined in a .css file.
Comment 4 Jonathan Druart 2022-05-31 08:09:46 UTC
Created attachment 135477 [details] [review]
Bug 29961: Make horizontal scroll bar always visible on acqui/z3950_search.pl

To test:
1. In Acquisitions make a basket and add something "From an external source"
2. Search for a title and click on the 'MARC' button, make sure the MARC prview is both tall and wide.
3. You will not see the horizontal scroll bar unless you scroll all the way to the bottom of the preview.
4. Apply patch.
5. Try steps 1 & 2 again, this time you should see the horizontal scroll bar as soon as the MARC prveiw loads.

Note: I put the CSS on multiple lines for better readability

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Tomás Cohen Arazi 2022-06-02 17:08:45 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 6 Lucas Gass 2022-06-10 16:59:35 UTC
Pushed to 22.05.x for 22.05.01
Comment 7 Arthur Suzuki 2022-06-21 13:41:58 UTC
thx, this is pushed to 21.11.x for 21.11.07
Comment 8 Victor Grousset/tuxayo 2022-06-25 23:59:47 UTC
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.