Created attachment 70602 [details] Result Summary that need to be show while returning of books. On the previous build Koha v17.05, after checking an item, the Check-in items table (patron cell), numbers of remaining items is visible below the patron's name, but now in v17.11 it is not visible even if patron has remaining checkout books. I am attaching the older screenshot of the result summary marking with red block in the screenshot that is not visible/displaying in the newer build. Please also help me, if there is an system preferences that need to be changed / modify to view results summary.
Adding the bug number of the original patch for adding this feature. I also confirmed it's no longer working.
Created attachment 70681 [details] [review] Bug 20003: Fix showing number of remaining checkouts during checking in Test plan: 0) Do not apply the patch 1) Have a patron with more then one checkout 2) Return one of patron's checkout and confirm the remaining number of checkout is not shown 3) Apply the patch 4) Try it again and confirm the number is now shown
Caused by commit 2b90ea2cb0e5e976de7ddef0151ae83d8ac578e6 Bug 17829: Move GetMember to Koha::Patron Due to a bad merge conflict during a rebase (that is exactly why we should not wait for moths to focus on these patches...) So I guess it impacts master as well.
Created attachment 70778 [details] [review] Bug 20003: Fix showing number of remaining checkouts during checking in Test plan: 0) Do not apply the patch 1) Have a patron with more then one checkout 2) Return one of patron's checkout and confirm the remaining number of checkout is not shown 3) Apply the patch 4) Try it again and confirm the number is now shown Signed-off-by: Roch D'Amour <roch.damour@inlibro.com>
Created attachment 70981 [details] [review] Bug 20003: Fix showing number of remaining checkouts during checking in Test plan: 0) Do not apply the patch 1) Have a patron with more then one checkout 2) Return one of patron's checkout and confirm the remaining number of checkout is not shown 3) Apply the patch 4) Try it again and confirm the number is now shown Signed-off-by: Roch D'Amour <roch.damour@inlibro.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 70982 [details] [review] Bug 20003: QA Followup - use patron checkouts method instead of Koha::Checkouts
Added a possible followup to use the method provided in Patron.pm instead of calling from Koha::Checkouts - feel free to obsolete if other method is preferred
Please make sure the " (QA follow-up) " flag is correct https://wiki.koha-community.org/wiki/Commit_messages#Examples
Pushed to master for 18.05, thanks to everybody involved!
Awesome work all! This patch has been pushed to 17.11.x and will be in 17.11.03