Bug 20179 - Remove GROUP BY in get_shelves_containing_record
Summary: Remove GROUP BY in get_shelves_containing_record
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Jonathan Druart
QA Contact: Julian Maurice
URL:
Keywords:
Depends on:
Blocks: 17258 20521
  Show dependency tree / graph
 
Reported: 2018-02-12 13:53 UTC by Julian Maurice
Modified: 2019-10-14 19:57 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 20179: [sql_modes] Remove GROUP BY in get_shelves_containing_record (917 bytes, patch)
2018-02-12 13:53 UTC, Julian Maurice 		Details | Diff | Splinter Review
Bug 20179: [sql_modes] Remove GROUP BY in get_shelves_containing_record (926 bytes, patch)
2018-02-14 17:57 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 20179: [sql_modes] Remove GROUP BY in get_shelves_containing_record (974 bytes, patch)
2018-03-16 20:28 UTC, Roch D'Amour 		Details | Diff | Splinter Review
Bug 20179: [sql_modes] Remove GROUP BY in get_shelves_containing_record (1.02 KB, patch)
2018-04-09 12:05 UTC, Julian Maurice 		Details | Diff | Splinter Review
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Maurice 2018-02-12 13:53:00 UTC 
This bug is a continuation of bug 20144
Comment 1 Julian Maurice 2018-02-12 13:53:53 UTC 
Created attachment 71470 [details] [review]
Bug 20179: [sql_modes] Remove GROUP BY in get_shelves_containing_record

Is that right?

Fix for:
'koha_kohadev.me.shelfname' isn't in GROUP BY

t/db_dependent/Virtualshelves.t

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 2 Julian Maurice 2018-02-12 13:55:05 UTC 
If there are multiple virtualshelfshares, get_shelves_containing_record can return the same virtualshelf multiple times.
Comment 3 Jonathan Druart 2018-02-14 17:57:21 UTC 
Created attachment 71626 [details] [review]
Bug 20179: [sql_modes] Remove GROUP BY in get_shelves_containing_record

Replaced with distinct.
Fix for:
'koha_kohadev.me.shelfname' isn't in GROUP BY

t/db_dependent/Virtualshelves.t
Comment 4 Roch D'Amour 2018-03-16 20:28:13 UTC 
Created attachment 73063 [details] [review]
Bug 20179: [sql_modes] Remove GROUP BY in get_shelves_containing_record

Replaced with distinct.
Fix for:
'koha_kohadev.me.shelfname' isn't in GROUP BY

t/db_dependent/Virtualshelves.t

Signed-off-by: Roch D'Amour <roch.damour@inlibro.com>
Comment 5 Julian Maurice 2018-04-09 12:05:17 UTC 
Created attachment 73861 [details] [review]
Bug 20179: [sql_modes] Remove GROUP BY in get_shelves_containing_record

Replaced with distinct.
Fix for:
'koha_kohadev.me.shelfname' isn't in GROUP BY

t/db_dependent/Virtualshelves.t

Signed-off-by: Roch D'Amour <roch.damour@inlibro.com>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Comment 6 Jonathan Druart 2018-04-09 19:16:35 UTC 
Pushed to master for 18.05, thanks to everybody involved!