So far we have bug 17258 (omnibus to list the issue we have with the new default SQL modes), bug 20144 (which fixed our test suite with these modes) and bug 20229. This last one forces the SQL modes to avoid to modify the DBMS configuration and define the SQL modes we support. We should let developers catch the issues and report/fix them. Also Jenkins must alert us if there is a regression with the test suite. I suggest to enable the problematic SQL modes on dev installs.
Created attachment 73659 [details] [review] Bug 20521: Enable problematic SQL modes for dev installs So far we have bug 17258 (omnibus to list the issue we have with the new default SQL modes), bug 20144 (which fixed our test suite with these modes) and bug 20229. This last one forces the SQL modes to avoid to modify the DBMS configuration and define the SQL modes we support. We should let developers catch the issues and report/fix them. Also Jenkins must alert us if there is a regression with the test suite. I suggest to enable the problematic SQL modes on dev installs. Test plan: - Revert commit 0180524bb9b1464c441bb1b858d0d8df37524d72 - prove t/db_dependent/Koha/Biblios.t => If you have dev_install defined in your Koha config file, the test will fail with "Field 'datecreated' doesn't have a default value" => If you do not have dev_install, the tests will pass
Created attachment 73670 [details] [review] Bug 20521: Enable problematic SQL modes for dev installs So far we have bug 17258 (omnibus to list the issue we have with the new default SQL modes), bug 20144 (which fixed our test suite with these modes) and bug 20229. This last one forces the SQL modes to avoid to modify the DBMS configuration and define the SQL modes we support. We should let developers catch the issues and report/fix them. Also Jenkins must alert us if there is a regression with the test suite. I suggest to enable the problematic SQL modes on dev installs. Test plan: - Revert commit 0180524bb9b1464c441bb1b858d0d8df37524d72 - prove t/db_dependent/Koha/Biblios.t => If you have dev_install defined in your Koha config file, the test will fail with "Field 'datecreated' doesn't have a default value" => If you do not have dev_install, the tests will pass NOTE: The commit number was wrong. Using git log -- t/db_dependent/Koha/Biblios.t This showed bug 20176 which was 524eab678833b2719187e67128ee4f83a2a48ba4 Also dev_install was in koha_conf.xml already, so I just had to toggle 0 and 1. Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 73683 [details] [review] Bug 20521: Enable problematic SQL modes for dev installs So far we have bug 17258 (omnibus to list the issue we have with the new default SQL modes), bug 20144 (which fixed our test suite with these modes) and bug 20229. This last one forces the SQL modes to avoid to modify the DBMS configuration and define the SQL modes we support. We should let developers catch the issues and report/fix them. Also Jenkins must alert us if there is a regression with the test suite. I suggest to enable the problematic SQL modes on dev installs. Test plan: - Revert commit 0180524bb9b1464c441bb1b858d0d8df37524d72 - prove t/db_dependent/Koha/Biblios.t => If you have dev_install defined in your Koha config file, the test will fail with "Field 'datecreated' doesn't have a default value" => If you do not have dev_install, the tests will pass NOTE: The commit number was wrong. Using git log -- t/db_dependent/Koha/Biblios.t This showed bug 20176 which was 524eab678833b2719187e67128ee4f83a2a48ba4 Also dev_install was in koha_conf.xml already, so I just had to toggle 0 and 1. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This is blocked by bug 20177, bug 20179 and bug 20180, otherwise the tests will not pass.
Back to PQA.
Awesome work all! Pushed to master for 18.11
Created attachment 80851 [details] [review] Bug 20521: Use a specific config for strict sql modes To avoid dev to complain to much it will be turned off by default. We will turn it on for Jenkins so devs will have to take care of the regressions they introduce (!)
(In reply to Jonathan Druart from comment #7) > Created attachment 80851 [details] [review] [review] > Bug 20521: Use a specific config for strict sql modes > > To avoid disrupting testers and new developers it will be turned off by default. > We will turn it on for Jenkins so devs will have to take care of the > regressions they introduce (!) (Amended) follow-up pushed to master
I think this is a solid choice for going forward.. but backporting all the fixes to enable currently unsupported SQL modes seems unnecessary. As such, I've chosen not to backport this one.
Pushed to 18.05.x for 18.05.06.. now that the followup makes it more configurable I've chosen to backport it.. it's a nice goal to strive for SQL compatibility for bugfixes.