Because of our contracts with vendors, we create acquisition baskets on june to renew our serial subscriptions for the next year. Most of the time, subscriptions for present year have not been received, for invoices are send at the end of the year. This is quite a problem for people who create the renewal baskets for only one open order in allowed on the same subscription. As budget can be defined for a given period (most of the time for a full year I imagine), it would be great if we could have several open orders allowed on the same subscription if the funds used belong to different budgets.
The BULAC (http://www.bulac.fr/) would like to sponsor this development ! As long as “Change sponsored?” is set on “Seeking developer”, anyone wanting to quote us for the development of such a feature or just ask for more information is welcome to write to us: <sigb@bulac.fr>.
Created attachment 73399 [details] [review] Bug 20365: Allow several orders on the same subscriptions Do we really need this limitation?
Should this be Needs Sign-off? Having mulitple orders makes sense to me. But I think we might need to revise the display on the subscrpition detail page then too.
Created attachment 74314 [details] [review] Bug 20365: Allow several orders on the same subscriptions Do we really need this limitation? Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Except the display issue on the subscription page that Katrin pointed, the behaviour of this patch seems good to me.
(In reply to Katrin Fischer from comment #3) > Should this be Needs Sign-off? Having multiple orders makes sense to me. But > I think we might need to revise the display on the subscription detail page > then too. I agree. Failing QA for this.
This one-line fix remove the unnecessary restriction at template level. The other views will be updated on other bug reports, like bug 9898. I am letting you adjust the status if you think it makes sense.
(In reply to Jonathan Druart from comment #7) > This one-line fix remove the unnecessary restriction at template level. > > The other views will be updated on other bug reports, like bug 9898. > > I am letting you adjust the status if you think it makes sense. The subscription detail page actually assume that only one order per subscription can be done. Pushing this patch alone means that we deliberately introduce new bugs, so, no, please no :)
Created attachment 75145 [details] [review] Bug 20365: Allow several orders on the same subscriptions Do we really need this limitation?
Sending back to NQA as it needs to be QAed along with bug 20726.
Created attachment 77437 [details] [review] Bug 20365: Allow several orders on the same subscriptions Do we really need this limitation? Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 77507 [details] [review] Bug 20365: Allow several orders on the same subscriptions Do we really need this limitation? Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 78069 [details] [review] Bug 20365: Allow several orders on the same subscriptions Do we really need this limitation? Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Awesome work all! Pushed to master for 18.11
Enhancement, will not be backported to 18.05.x series.