On the 'Acquisition detail' tab on bibliographic record, we cant' know if orders are placed on bibliographic or subscription level. It is quite complicated when several subscriptions are attached to this record to have a clear history of the acquisitions. It would be great for order managers if we could have 2 more columns on this tab, one with the 'aqorders.subsciptionid' and one with 'subscription.callnumber'.
The BULAC (http://www.bulac.fr/) would like to sponsor this development ! As long as “Change sponsored?” is set on “Seeking developer”, anyone wanting to quote us for the development of such a feature or just ask for more information is welcome to write to us: <sigb@bulac.fr>.
Created attachment 75174 [details] [review] Bug 20366: Add new method Koha::Acquisition::Order->subscription Can be moved to a separate bug report.
Created attachment 75175 [details] [review] Bug 20366: Add new method Koha::Acquisition::Basket->basket_group Can be moved to a separate bug report.
Created attachment 75176 [details] [review] Bug 20366: Add subscription info to the acq tab on the biblio detail page On the "Acquisition details" tab of the bibliographic detail page, the subscription information are missing. This patch replace the call to GetHistory with Koha::Acquisition::Orders in order to simplify the code and make use of new Koha:: packages/methods. TODO: Add column settings (show/hide columns) to this table (?)
Attached to test but will certainly need to be adjusted depending on the decisions from bug 20726.
I was curious to see what it looks like, but can't apply patches. $ git bz apply 20366 Bug 20366 - More information about orders linked to subscriptions on "Acquisition details" tab 75174 - Bug 20366: Add new method Koha::Acquisition::Order->subscription 75175 - Bug 20366: Add new method Koha::Acquisition::Basket->basket_group 75176 - Bug 20366: Add subscription info to the acq tab on the biblio detail page Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 20366: Add new method Koha::Acquisition::Order->subscription fatal: sha1 information is lacking or useless (Koha/Acquisition/Order.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 20366: Add new method Koha::Acquisition::Order->subscription
You need to apply patches from bug 20365 first, and so the ones from bug 20726 too.
I have pushed a branch to my gitlab repo to help testing: https://gitlab.com/joubu/Koha/tree/bug_20366
I get an error when I try to view detail.pl: Template process failed: undef error - DBIx::Class::Storage::DBI::_dbh_execute(): Unknown column 'me.created_by' in 'field list' at /home/vagrant/kohaclone/Koha/Objects.pm line 269 at /home/vagrant/kohaclone/C4/Templates.pm line 122
I do not recreate that, could you confirm you do not have this issue on master? Or without patches from this bug, i.e. with patches from bug 20365?
(In reply to Jonathan Druart from comment #10) > Or without patches from this bug, i.e. with patches from bug 20365? I have this problem on master, only happens after applying this patch set (not with the patch dependencies).
I guess you have some data inconsistencies, or the bug comes somewhere else. I do not see how it could be related to this bug (I may be wrong ofc). Maybe you will get the same error browsing the acq module? I am resetting to needs signoff in order to get other tests on it, let me know if you have more pointers to give me!
Created attachment 77438 [details] [review] Bug 20366: Add new method Koha::Acquisition::Order->subscription Can be moved to a separate bug report.
Created attachment 77439 [details] [review] Bug 20366: Add new method Koha::Acquisition::Basket->basket_group Can be moved to a separate bug report.
Created attachment 77440 [details] [review] Bug 20366: Add subscription info to the acq tab on the biblio detail page On the "Acquisition details" tab of the bibliographic detail page, the subscription information are missing. This patch replace the call to GetHistory with Koha::Acquisition::Orders in order to simplify the code and make use of new Koha:: packages/methods. TODO: Add column settings (show/hide columns) to this table (?)
Created attachment 77441 [details] [review] Bug 20366: (follow-up) Fix link to subscription
Created attachment 77452 [details] [review] Bug 20366: Add new method Koha::Acquisition::Order->subscription Can be moved to a separate bug report. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 77453 [details] [review] Bug 20366: Add new method Koha::Acquisition::Basket->basket_group Can be moved to a separate bug report. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 77454 [details] [review] Bug 20366: Add subscription info to the acq tab on the biblio detail page On the "Acquisition details" tab of the bibliographic detail page, the subscription information are missing. This patch replace the call to GetHistory with Koha::Acquisition::Orders in order to simplify the code and make use of new Koha:: packages/methods. TODO: Add column settings (show/hide columns) to this table (?) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 77455 [details] [review] Bug 20366: (follow-up) Fix link to subscription Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 77508 [details] [review] Bug 20366: Add new method Koha::Acquisition::Order->subscription Can be moved to a separate bug report. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 77509 [details] [review] Bug 20366: Add new method Koha::Acquisition::Basket->basket_group Can be moved to a separate bug report. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 77510 [details] [review] Bug 20366: Add subscription info to the acq tab on the biblio detail page On the "Acquisition details" tab of the bibliographic detail page, the subscription information are missing. This patch replace the call to GetHistory with Koha::Acquisition::Orders in order to simplify the code and make use of new Koha:: packages/methods. TODO: Add column settings (show/hide columns) to this table (?) Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 77511 [details] [review] Bug 20366: (follow-up) Fix link to subscription Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
(In reply to Jonathan Druart from comment #4) > TODO: Add column settings (show/hide columns) to this table (?) See bug 21166
Created attachment 78070 [details] [review] Bug 20366: Add new method Koha::Acquisition::Order->subscription Can be moved to a separate bug report. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 78071 [details] [review] Bug 20366: Add new method Koha::Acquisition::Basket->basket_group Can be moved to a separate bug report. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 78072 [details] [review] Bug 20366: Add subscription info to the acq tab on the biblio detail page On the "Acquisition details" tab of the bibliographic detail page, the subscription information are missing. This patch replace the call to GetHistory with Koha::Acquisition::Orders in order to simplify the code and make use of new Koha:: packages/methods. TODO: Add column settings (show/hide columns) to this table (?) Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 78073 [details] [review] Bug 20366: (follow-up) Fix link to subscription Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Awesome work all! Pushed to master for 18.11
Enhancement, will not be backported to 18.05.x series.