Currently indexes only coming from mapping.yaml. We need to add some using UI (admin/searchengine/elasticsearch/mappings.pl)
* The add line could be at the begin of the page. * A delete button could be on each line.
Created attachment 73158 [details] [review] Bug 20388 - Add/delete search fields from search engine configuration page Test plan: - apply this patch, - check that SearchEngine system preference is set to Elasticsearch, - go to Admin > Search engine configuration, - on the search fields tab, fill a new line at the bottom of the table (name, label, type) - click on the "Add" button and save, - check that the new search field has been saved, - also test field deletions, - check that you can't delete already mapped fields.
Created attachment 73165 [details] [review] Bug 20388 - Add/delete search fields from search engine configuration page Test plan: - apply this patch, - check that SearchEngine system preference is set to Elasticsearch, - go to Admin > Search engine configuration, - on the search fields tab, fill a new line at the bottom of the table (name, label, type) - click on the "Add" button and save, - check that the new search field has been saved, - also test field deletions, - check that you can't delete already mapped fields. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr>
Created attachment 73167 [details] [review] Bug 20388 - Add/delete search fields from search engine configuration page Test plan: - apply this patch, - check that SearchEngine system preference is set to Elasticsearch, - go to Admin > Search engine configuration, - on the search fields tab, fill a new line at the bottom of the table (name, label, type) - click on the "Add" button and save, - check that the new search field has been saved, - also test field deletions, - check that you can't delete already mapped fields. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
This new feature will be very useful ! It also makes the "Search fields" tab clearer, for we now can see which index are unused. Thanks Alex !
*** Bug 18194 has been marked as a duplicate of this bug. ***
Created attachment 73476 [details] [review] Bug 20388 - Add/delete search fields from search engine configuration page Test plan: - apply this patch, - check that SearchEngine system preference is set to Elasticsearch, - go to Admin > Search engine configuration, - on the search fields tab, fill a new line at the bottom of the table (name, label, type) - click on the "Add" button and save, - check that the new search field has been saved, - also test field deletions, - check that you can't delete already mapped fields. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
1. What's the point of the JS function valid_line? I think you should double-check it, it does not do what you expect it to do. 2. You are reusing code to duplicate a new mapping but for something else. You should rename the variables to avoid confusion then. For instance "search_fields" is not an index name 3. Bug report's title is wrong, we are not adding/removing indices 4. I did not implement that part on the original patch because it's hard to keep an interface consistent. For instance: - create a new search field => You cannot create a new mapping, you have to save first - create a new search field, save => You can delete it. So it you create a mapping using it, you can still delete it. If you save => kaboom => If you have a search field already mapped and delete the mapping, you cannot delete the search field.
(In reply to Jonathan Druart from comment #8) > 1. What's the point of the JS function valid_line? > I think you should double-check it, it does not do what you expect it to do. > > 2. You are reusing code to duplicate a new mapping but for something else. > You should rename the variables to avoid confusion then. > For instance "search_fields" is not an index name I wanted to reuse the code as much as possible. It is not a problem for to add a js fonction dedicated to duplicate search fields only. > > 3. Bug report's title is wrong, we are not adding/removing indices Right! > > 4. I did not implement that part on the original patch because it's hard to > keep an interface consistent. > For instance: > - create a new search field > => You cannot create a new mapping, you have to save first > - create a new search field, save > => You can delete it. So it you create a mapping using it, you can still > delete it. If you save => kaboom > => If you have a search field already mapped and delete the mapping, you > cannot delete the search field. I see 2 solutions: 1) JS code for validating data when saving and warn the user if there is something inconsistent. May be quite tricky... 2) Submit the form on clicking the "+add" button. There is a disavantage: page is reloaded between each adding. Not confortable for adding many search fields or mapping
Created attachment 73626 [details] [review] Bug 20388 - Add/delete search fields from search engine configuration page Test plan: - apply this patch, - check that SearchEngine system preference is set to Elasticsearch, - go to Admin > Search engine configuration, - on the search fields tab, fill a new line at the bottom of the table (name, label, type) - click on the "Add" button and save, - check that the new search field has been saved, - also test field deletions, - check that you can't delete already mapped fields. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 73627 [details] [review] Bug 20388 - Keep data consistency when adding/removing mapping Test plan: - create a new search field, save, - you create a mapping using it (don't save), - check that you can't delete the search field. - delete all the mapping related to a search field (don't save) - check that you can delete this search field.
Created attachment 73629 [details] [review] Bug 20388 - Keep data consistency when adding/removing mapping Test plan: - create a new search field, save, - create a mapping using it (don't save), - check that you can't delete the search field. - delete all the mapping related to a search field (biblios and authoroties), don't save, - check that you can delete this search field.
Created attachment 73681 [details] [review] Bug 20388 - Add/delete search fields from search engine configuration page Test plan: - apply this patch, - check that SearchEngine system preference is set to Elasticsearch, - go to Admin > Search engine configuration, - on the search fields tab, fill a new line at the bottom of the table (name, label, type) - click on the "Add" button and save, - check that the new search field has been saved, - also test field deletions, - check that you can't delete already mapped fields. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 73682 [details] [review] Bug 20388 - Keep data consistency when adding/removing mapping Test plan: - create a new search field, save, - create a mapping using it (don't save), - check that you can't delete the search field. - delete all the mapping related to a search field (biblios and authorities), don't save, - check that you can delete this search field. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr>
(In reply to Jonathan Druart from comment #8) > 1. What's the point of the JS function valid_line? > I think you should double-check it, it does not do what you expect it to do. You forgot that point.
(In reply to Jonathan Druart from comment #15) > (In reply to Jonathan Druart from comment #8) > > 1. What's the point of the JS function valid_line? > > I think you should double-check it, it does not do what you expect it to do. > > You forgot that point. I removed that function. Not esasy to see since i squashed this operation in the first patch.
Indeed, thanks
Created attachment 73918 [details] [review] Bug 20388 - Add/delete search fields from search engine configuration page Test plan: - apply this patch, - check that SearchEngine system preference is set to Elasticsearch, - go to Admin > Search engine configuration, - on the search fields tab, fill a new line at the bottom of the table (name, label, type) - click on the "Add" button and save, - check that the new search field has been saved, - also test field deletions, - check that you can't delete already mapped fields. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 73919 [details] [review] Bug 20388 - Keep data consistency when adding/removing mapping Test plan: - create a new search field, save, - create a mapping using it (don't save), - check that you can't delete the search field. - delete all the mapping related to a search field (biblios and authorities), don't save, - check that you can delete this search field. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr>
Made this BZ depends on 18316 because i'm reusing a subroutine created in. So put this one back on needs signoff to be sure nothing is broken
Created attachment 73940 [details] [review] Bug 18316 - Add weighting/relevancy options to ES query on simple search The idea is the following: if some search field(s) are weighted in search engine config page, Koha will query ES on these fields only and with the coresponding weights. Else, search is done on the entire record. Test plan (having Koha working with Elasticsearch): - apply this patch, - try searches with and without weight defined on search fields Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 73943 [details] [review] Bug 20388 - Add/delete search fields from search engine configuration page Test plan: - apply this patch, - check that SearchEngine system preference is set to Elasticsearch, - go to Admin > Search engine configuration, - on the search fields tab, fill a new line at the bottom of the table (name, label, type) - click on the "Add" button and save, - check that the new search field has been saved, - also test field deletions, - check that you can't delete already mapped fields. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 73944 [details] [review] Bug 20388 - Keep data consistency when adding/removing mapping Test plan: - create a new search field, save, - create a mapping using it (don't save), - check that you can't delete the search field. - delete all the mapping related to a search field (biblios and authorities), don't save, - check that you can delete this search field. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr>
Created attachment 73945 [details] [review] Bug 20388 - Add/delete search fields from search engine configuration page Test plan: - apply this patch, - check that SearchEngine system preference is set to Elasticsearch, - go to Admin > Search engine configuration, - on the search fields tab, fill a new line at the bottom of the table (name, label, type) - click on the "Add" button and save, - check that the new search field has been saved, - also test field deletions, - check that you can't delete already mapped fields. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 73946 [details] [review] Bug 20388 - Keep data consistency when adding/removing mapping Test plan: - create a new search field, save, - create a mapping using it (don't save), - check that you can't delete the search field. - delete all the mapping related to a search field (biblios and authorities), don't save, - check that you can delete this search field. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr>
I tested this one (when reviewing bug 18316). We can have inconsistency when using the UI: - Add acqdate to authority - Add weight to acqdate for biblio - Save - Remove it for biblio - Save => weight is still set in DB but not displayed on the UI It's not that important, because not used. But if we continue that way we are going to have a lot of inconsistencies. I built this interface (bug 14899, 2.5 years ago) as an example. Now we are going to add lot of information and maybe we should rethink the interface. I can easily imagine somebody spending 2 hours switching from 1 tab to another and modifying everything, then finally save, and... everything is lost because an error occurred. It seems obvious that the search fields form should be a separate page to force a save before modifying the mappings. Maybe better would be to save via AJAX when the tab is changed (or force the user to save), and refresh the new tab to have updated info. The "add" and "delete" buttons could also send AJAX requests. I do not think it will be blocker for 18.05, but keep this comment in mind if you plan to add more and more stuffs to this view.
It would also has been fair to base your patches on top of the other ones in the queue (since 1 year), bug 18235 for instance
Created attachment 74261 [details] [review] Bug 11674: DBRev 17.12.00.031 Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Something weird happened when I signed it.. Sorry about that. Behaviour is ok for me.
Created attachment 74718 [details] [review] Bug 20388 - Add/delete search fields from search engine configuration page Test plan: - apply this patch, - check that SearchEngine system preference is set to Elasticsearch, - go to Admin > Search engine configuration, - on the search fields tab, fill a new line at the bottom of the table (name, label, type) - click on the "Add" button and save, - check that the new search field has been saved, - also test field deletions, - check that you can't delete already mapped fields. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 74719 [details] [review] Bug 20388 - Keep data consistency when adding/removing mapping Test plan: - create a new search field, save, - create a mapping using it (don't save), - check that you can't delete the search field. - delete all the mapping related to a search field (biblios and authorities), don't save, - check that you can delete this search field. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr>
I was trying to test these patches but they don't apply on top of latest master.
Created attachment 78658 [details] [review] Bug 20388 - Add/delete search fields from search engine configuration page Test plan: - apply this patch, - check that SearchEngine system preference is set to Elasticsearch, - go to Admin > Search engine configuration, - on the search fields tab, fill a new line at the bottom of the table (name, label, type) - click on the "Add" button and save, - check that the new search field has been saved, - also test field deletions, - check that you can't delete already mapped fields. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 78659 [details] [review] Bug 20388 - Keep data consistency when adding/removing mapping Test plan: - create a new search field, save, - create a mapping using it (don't save), - check that you can't delete the search field. - delete all the mapping related to a search field (biblios and authorities), don't save, - check that you can delete this search field. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr>
There is a little problem that needs to be fixed: 1. Add a search field, save 2. Delete the search field, don't save 3. Go to "Bibliographic records" tab, add a new mapping for this search field, Save. 4. An error message appear: > An error occurred when updating mappings (Can't call method > "add_to_search_marc_maps" on an undefined value at > /home/koha/env/master/src/admin/searchengine/elasticsearch/mappings.pl line > 107. ).
Created attachment 80709 [details] [review] Bug 20388: Prevent user from using a search field for a mapping after removing it Test plan: - add a search field, - save, - remove this search field - check that it has been removed from the mapping lists (bottom select).
(In reply to Alex Arnaud from comment #34) > Created attachment 78659 [details] [review] [review] > Bug 20388 - Keep data consistency when adding/removing mapping > > Test plan: > - create a new search field, save, > - create a mapping using it (don't save), > - check that you can't delete the search field. > > - delete all the mapping related to a search field (biblios and > authorities), don't save, > - check that you can delete this search field. > This does not work, first part is OK, but in second one, I still can't remove the searchfield...
(In reply to Josef Moravec from comment #37) > (In reply to Alex Arnaud from comment #34) > > Created attachment 78659 [details] [review] [review] [review] > > Bug 20388 - Keep data consistency when adding/removing mapping > > > > Test plan: > > - create a new search field, save, > > - create a mapping using it (don't save), > > - check that you can't delete the search field. > > > > - delete all the mapping related to a search field (biblios and > > authorities), don't save, > > - check that you can delete this search field. > > > > This does not work, first part is OK, but in second one, I still can't > remove the searchfield... Hello, You mean you deleted all mapping related to a search field and you can delete it ?
(In reply to Alex Arnaud from comment #38) > (In reply to Josef Moravec from comment #37) > > (In reply to Alex Arnaud from comment #34) > > > Created attachment 78659 [details] [review] [review] [review] [review] > > > Bug 20388 - Keep data consistency when adding/removing mapping > > > > > > Test plan: > > > - create a new search field, save, > > > - create a mapping using it (don't save), > > > - check that you can't delete the search field. > > > > > > - delete all the mapping related to a search field (biblios and > > > authorities), don't save, > > > - check that you can delete this search field. > > > > > > > This does not work, first part is OK, but in second one, I still can't > > remove the searchfield... > > Hello, > > You mean you deleted all mapping related to a search field and you can > delete it ? Works for me...
Hi! We also tested the patch and can't remove the search field according to your instructions. If I save the mappings first it works ok. Tested in FF and Chrome After a quick look it seems the newly created mappings is missing the onclick event to enable the delete button on the search field-tab.
Created attachment 86912 [details] [review] Bug 20388: Use live handler for deleting elements
The patch doesnt apply for me on the current master. Applying: Bug 20388 - Add/delete search fields from search engine configuration page fatal: sha1 information is lacking or useless (admin/searchengine/elasticsearch/mappings.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 20388 - Add/delete search fields from search engine configuration page
Created attachment 87196 [details] [review] Bug 20388 - Add/delete search fields from search engine configuration page Test plan: - apply this patch, - check that SearchEngine system preference is set to Elasticsearch, - go to Admin > Search engine configuration, - on the search fields tab, fill a new line at the bottom of the table (name, label, type) - click on the "Add" button and save, - check that the new search field has been saved, - also test field deletions, - check that you can't delete already mapped fields. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 87197 [details] [review] Bug 20388 - Keep data consistency when adding/removing mapping Test plan: - create a new search field, save, - create a mapping using it (don't save), - check that you can't delete the search field. - delete all the mapping related to a search field (biblios and authorities), don't save, - check that you can delete this search field. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr>
Created attachment 87198 [details] [review] Bug 20388: Prevent user from using a search field for a mapping after removing it Test plan: - add a search field, - save, - remove this search field - check that it has been removed from the mapping lists (bottom select).
Created attachment 87199 [details] [review] Bug 20388: Use live handler for deleting elements
Created attachment 87201 [details] [review] Bug 20388 - Add/delete search fields from search engine configuration page Test plan: - apply this patch, - check that SearchEngine system preference is set to Elasticsearch, - go to Admin > Search engine configuration, - on the search fields tab, fill a new line at the bottom of the table (name, label, type) - click on the "Add" button and save, - check that the new search field has been saved, - also test field deletions, - check that you can't delete already mapped fields. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se>
Created attachment 87202 [details] [review] Bug 20388 - Keep data consistency when adding/removing mapping Test plan: - create a new search field, save, - create a mapping using it (don't save), - check that you can't delete the search field. - delete all the mapping related to a search field (biblios and authorities), don't save, - check that you can delete this search field. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se>
Created attachment 87203 [details] [review] Bug 20388: Prevent user from using a search field for a mapping after removing it Test plan: - add a search field, - save, - remove this search field - check that it has been removed from the mapping lists (bottom select). Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se>
Created attachment 87204 [details] [review] Bug 20388: Use live handler for deleting elements Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se>
Comment on attachment 87201 [details] [review] Bug 20388 - Add/delete search fields from search engine configuration page Review of attachment 87201 [details] [review]: ----------------------------------------------------------------- ::: admin/searchengine/elasticsearch/mappings.pl @@ +217,5 @@ > my $search_field_unblessed = $search_field->unblessed; > $search_field_unblessed->{mapped_biblios} = 1 if $search_field->is_mapped_biblios; > + > + $search_field_unblessed->{is_mapped} = $schema->resultset('SearchMarcToField')->search( > + { search_field_id => $search_field->id })->count; Can be replaced by $search_field_unblessed->{is_mapped} = $search_field->is_mapped; But why is it unblessed in the first place, and not directly passed to template ? ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt @@ +64,5 @@ > + var name = $(line).find('input[data-id="search_field_name"]').val(); > + var label = $(line).find('input[data-id="search_field_name"]').val(); > + if ( name.length > 0 && label.length > 0 ) { > + var new_line = clone_line( line ); > + new_line.appendTo($('table[data-index_name=search_fields]>tbody')); You should probably use the already existing 'table' variable instead of searching in the whole DOM @@ +72,5 @@ > + clean_line(line); > + > + $(table).tableDnD( { > + onDragClass: "dragClass", > + } ); This is weird. Drag and Drop is not enabled on this table until you add a new field. And it looks like it is useless to move lines around since they are automatically ordered alphabetically after a save @@ +242,5 @@ > + [% IF search_field.is_mapped %] > + <a class="btn btn-default btn-xs disabled delete" style="cursor: pointer;"><i class="fa fa-trash"></i> Delete</a> > + [% ELSE %] > + <a class="btn btn-default btn-xs delete" style="cursor: pointer;"><i class="fa fa-trash"></i> Delete</a> > + [% END %] It might be better to use a <button> here to avoid the inline style, and to use the disabled attribute instead of the disabled class @@ +244,5 @@ > + [% ELSE %] > + <a class="btn btn-default btn-xs delete" style="cursor: pointer;"><i class="fa fa-trash"></i> Delete</a> > + [% END %] > + </td> > + </td> Double end tag, should be removed
Comment on attachment 87203 [details] [review] Bug 20388: Prevent user from using a search field for a mapping after removing it Review of attachment 87203 [details] [review]: ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt @@ +33,4 @@ > var line = $(this).closest("tr"); > + > + // We clicked delete button on search fields tab. > + if (name = $(line).find('input[name="search_field_name"]').val()) { It looks like 'name' is a global variable. Declare it with 'var' to avoid that.
Additional QA comments: - I noticed a strange behaviour. After resetting all mappings ("Reset mappings" button), all "Delete" buttons are disabled until I click on "Save". What is happening here ? - If I add a new field with the same name of an existing field, and move the line to the top, the existing field will be deleted and the new field will remain. It could be a problem if the types differ. There should be a control to avoid that.
Created attachment 88075 [details] [review] Bug 20388: QA fixes: - pass search field objects in template instead of unblessed ones - disable drag n drop
Created attachment 88079 [details] [review] Bug 20388: Add/delete search fields from search engine configuration page Test plan: - apply this patch, - check that SearchEngine system preference is set to Elasticsearch, - go to Admin > Search engine configuration, - on the search fields tab, fill a new line at the bottom of the table (name, label, type) - click on the "Add" button and save, - check that the new search field has been saved, - also test field deletions, - check that you can't delete already mapped fields. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Created attachment 88080 [details] [review] Bug 20388: Keep data consistency when adding/removing mapping Test plan: - create a new search field, save, - create a mapping using it (don't save), - check that you can't delete the search field. - delete all the mapping related to a search field (biblios and authorities), don't save, - check that you can delete this search field. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Created attachment 88081 [details] [review] Bug 20388: Prevent user from using a search field for a mapping after removing it Test plan: - add a search field, - save, - remove this search field - check that it has been removed from the mapping lists (bottom select). Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Created attachment 88082 [details] [review] Bug 20388: Use live handler for deleting elements Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Created attachment 88083 [details] [review] Bug 20388: QA fixes: - pass search field objects in template instead of unblessed ones - disable drag n drop Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
If i add a field and then add a mapping, then delete the mapping, I am unable to the delete the field I poked the DB a bit - it looks like the numberings are getting mixed up somewhere/somehow The ids for search_field are rebuilt on every save?
Are we still hoping to move this along for 19.05?
(In reply to Martin Renvoize from comment #61) > Are we still hoping to move this along for 19.05? We (Biblibre) will send some fixes very soon. Work in progress...
Created attachment 89117 [details] [review] Bug 20388: QA fixe : delete line who add elements in biblios and authorities in the same time
Created attachment 89118 [details] [review] Bug 20388: QA fixe : delete line who add elements in biblios and authorities in the same time
Created attachment 89121 [details] [review] Bug 20388: QA fixe : delete line who add elements in biblios and authorities in the same time
Hi, I've just tried to test this, and I don't see the row at the bottom to add new mappings on the search tab? Terribly sorry, I'm quite sure I restarted the things and did all of the prerequisites, but as usual not sure if it was something I'm doing wrong or if it's the code. Cheers, Liz
(In reply to Liz Rea from comment #66) > Hi, > > I've just tried to test this, and I don't see the row at the bottom to add > new mappings on the search tab? > > Terribly sorry, I'm quite sure I restarted the things and did all of the > prerequisites, but as usual not sure if it was something I'm doing wrong or > if it's the code. > > Cheers, > Liz Hi, Are you sure you are at the good place? You can add search fields at the biottom of the search field part, but to add new mappings you have to go at the bottom of bibliographic records.
Anyone else can reproduce Liz's issue ?
there were no entry boxes at the bottom of either tab, sorry.
(In reply to Liz Rea from comment #69) > there were no entry boxes at the bottom of either tab, sorry. If you realy are in search engine configuration. Remove the patch, so you should be in master. - return to search engine configuration - go to bibliographic records or authorities - at the bottom of the tab, you should see the add line because this patch just add the line at the bottom of search field - if you don't, there is a issue on your side
The new "add" line appears for me, but the "Type" dropdown does not contain the same values as above. Please double check. In case of misunderstanding it's always good to share a screenshot, so here it is: https://snag.gy/2XiGEd.jpg # Scroll down!
Also, if you add a field that already exists, it is ignored (no warning, no updated).
Re-checked this today, and the fields showed up. Quite sure I didn't do anything differently, sorry for the noise. As Jonathan noted, the types for the new entries don't match with the types in the existing entries. Is that intentional? When I tested adding a name and label that already existed, it added it for me - I don't know if that is correct or incorrect behaviour.
Created attachment 89733 [details] [review] Bug 20388: add of types in the new entries dropdown of searchfiels
(In reply to Liz Rea from comment #73) > Re-checked this today, and the fields showed up. Quite sure I didn't do > anything differently, sorry for the noise. > > As Jonathan noted, the types for the new entries don't match with the types > in the existing entries. Is that intentional? > > When I tested adding a name and label that already existed, it added it for > me - I don't know if that is correct or incorrect behaviour. Hi, I fix the types for the new entries ( I don't think it was intentional). But for the adding, I didn't succeed to reproduce your bug. How did you do it?
Like that, adding a new 'uri' field: https://snag.gy/BpxcIq.jpg
Created attachment 89894 [details] [review] Bug 20388: QA fixe : add searchfield only if it doesn't exist To test: Without the fix: - in search field configuration -> search field - add the search field "uri" at the bottom of the tab - you should have two fields "uri" like that : https://snag.gy/BpxcIq.jpg Then apply the fix - try to add the search field uri - this time an alert should appear with the message : " SearchField uri already exist "
Created attachment 90517 [details] [review] Bug 20388: Add/delete search fields from search engine configuration page Test plan: - apply this patch, - check that SearchEngine system preference is set to Elasticsearch, - go to Admin > Search engine configuration, - on the search fields tab, fill a new line at the bottom of the table (name, label, type) - click on the "Add" button and save, - check that the new search field has been saved, - also test field deletions, - check that you can't delete already mapped fields. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Michal Denar <black23@gmail.com>
Created attachment 90518 [details] [review] Bug 20388: Keep data consistency when adding/removing mapping Test plan: - create a new search field, save, - create a mapping using it (don't save), - check that you can't delete the search field. - delete all the mapping related to a search field (biblios and authorities), don't save, - check that you can delete this search field. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Michal Denar <black23@gmail.com>
Created attachment 90519 [details] [review] Bug 20388: Prevent user from using a search field for a mapping after removing it Test plan: - add a search field, - save, - remove this search field - check that it has been removed from the mapping lists (bottom select). Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Michal Denar <black23@gmail.com>
Created attachment 90520 [details] [review] Bug 20388: Use live handler for deleting elements Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Michal Denar <black23@gmail.com>
Created attachment 90521 [details] [review] Bug 20388: QA fixes: - pass search field objects in template instead of unblessed ones - disable drag n drop Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Michal Denar <black23@gmail.com>
Created attachment 90522 [details] [review] Bug 20388: QA fixe : delete line who add elements in biblios and authorities in the same time Signed-off-by: Michal Denar <black23@gmail.com>
Created attachment 90523 [details] [review] Bug 20388: add of types in the new entries dropdown of searchfiels Signed-off-by: Michal Denar <black23@gmail.com>
Created attachment 90524 [details] [review] Bug 20388: QA fixe : add searchfield only if it doesn't exist To test: Without the fix: - in search field configuration -> search field - add the search field "uri" at the bottom of the tab - you should have two fields "uri" like that : https://snag.gy/BpxcIq.jpg Then apply the fix - try to add the search field uri - this time an alert should appear with the message : " SearchField uri already exist " Signed-off-by: Michal Denar <black23@gmail.com>
Created attachment 98011 [details] [review] Bug 20388: Add/delete search fields from search engine configuration page Test plan: - apply this patch, - check that SearchEngine system preference is set to Elasticsearch, - go to Admin > Search engine configuration, - on the search fields tab, fill a new line at the bottom of the table (name, label, type) - click on the "Add" button and save, - check that the new search field has been saved, - also test field deletions, - check that you can't delete already mapped fields. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Michal Denar <black23@gmail.com>
Created attachment 98012 [details] [review] Bug 20388: Keep data consistency when adding/removing mapping Test plan: - create a new search field, save, - create a mapping using it (don't save), - check that you can't delete the search field. - delete all the mapping related to a search field (biblios and authorities), don't save, - check that you can delete this search field. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Michal Denar <black23@gmail.com>
Created attachment 98013 [details] [review] Bug 20388: Prevent user from using a search field for a mapping after removing it Test plan: - add a search field, - save, - remove this search field - check that it has been removed from the mapping lists (bottom select). Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Michal Denar <black23@gmail.com>
Created attachment 98014 [details] [review] Bug 20388: Use live handler for deleting elements Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Michal Denar <black23@gmail.com>
Created attachment 98015 [details] [review] Bug 20388: QA fixes: - pass search field objects in template instead of unblessed ones - disable drag n drop Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Michal Denar <black23@gmail.com>
Created attachment 98016 [details] [review] Bug 20388: QA fixe : delete line who add elements in biblios and authorities in the same time Signed-off-by: Michal Denar <black23@gmail.com>
Created attachment 98017 [details] [review] Bug 20388: add of types in the new entries dropdown of searchfiels Signed-off-by: Michal Denar <black23@gmail.com>
Created attachment 98018 [details] [review] Bug 20388: QA fixe : add searchfield only if it doesn't exist To test: Without the fix: - in search field configuration -> search field - add the search field "uri" at the bottom of the tab - you should have two fields "uri" like that : https://snag.gy/BpxcIq.jpg Then apply the fix - try to add the search field uri - this time an alert should appear with the message : " SearchField uri already exist " Signed-off-by: Michal Denar <black23@gmail.com>
Patches have been rebased on upon bug 19482 which prevent removing mandatory fields. So set back to need signoff.
Created attachment 99960 [details] [review] Bug 20388: Add/delete search fields from search engine configuration page Test plan: - apply this patch, - check that SearchEngine system preference is set to Elasticsearch, - go to Admin > Search engine configuration, - on the search fields tab, fill a new line at the bottom of the table (name, label, type) - click on the "Add" button and save, - check that the new search field has been saved, - also test field deletions, - check that you can't delete already mapped fields. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com>
Created attachment 99961 [details] [review] Bug 20388: Keep data consistency when adding/removing mapping Test plan: - create a new search field, save, - create a mapping using it (don't save), - check that you can't delete the search field. - delete all the mapping related to a search field (biblios and authorities), don't save, - check that you can delete this search field. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com>
Created attachment 99962 [details] [review] Bug 20388: Prevent user from using a search field for a mapping after removing it Test plan: - add a search field, - save, - remove this search field - check that it has been removed from the mapping lists (bottom select). Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com>
Created attachment 99963 [details] [review] Bug 20388: Use live handler for deleting elements Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com>
Created attachment 99964 [details] [review] Bug 20388: QA fixes: - pass search field objects in template instead of unblessed ones - disable drag n drop Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com>
Created attachment 99965 [details] [review] Bug 20388: QA fixe : delete line who add elements in biblios and authorities in the same time Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com>
Created attachment 99966 [details] [review] Bug 20388: add of types in the new entries dropdown of searchfiels Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com>
Created attachment 99967 [details] [review] Bug 20388: QA fixe : add searchfield only if it doesn't exist To test: Without the fix: - in search field configuration -> search field - add the search field "uri" at the bottom of the tab - you should have two fields "uri" like that : https://snag.gy/BpxcIq.jpg Then apply the fix - try to add the search field uri - this time an alert should appear with the message : " SearchField uri already exist " Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com>
This depends on bug 19482 which is currently Failed QA. Marking as BLOCKED until this is resolved.
bug 19482 is pushed master, I reset to previous status
OK for QA ?
Created attachment 119296 [details] [review] Issue #6 - Restore continue, skip and abort
(In reply to Gérard Simon Voyer from comment #107) > Created attachment 119296 [details] [review] [review] > Issue #6 - Restore continue, skip and abort All the Saints in the World, what have I done?? This is completely unintentional, I will cease right now my tinkering with git-bz and just apply patches the like I used to. Please forgive this dumb mistake
(In reply to Gérard Simon Voyer from comment #108) > (In reply to Gérard Simon Voyer from comment #107) > > Created attachment 119296 [details] [review] [review] [review] > > Issue #6 - Restore continue, skip and abort > > All the Saints in the World, what have I done?? > This is completely unintentional, I will cease right now my tinkering with > git-bz and just apply patches the like I used to. > > Please forgive this dumb mistake Don't worry Gérard, i marked your patch as obsolete. No consequence
Created attachment 119317 [details] [review] Bug 20388 - Elasticsearch - Ability to add search fields from UI
Created attachment 119318 [details] [review] Bug 20388 - Elasticsearch - Ability to add search fields from UI Test plan: - apply this patch, - check that SearchEngine system preference is set to Elasticsearch, - go to Admin > Search engine configuration, - on the search fields tab, fill a new line at the bottom of the table (name, label, type) - click on the "Add" button and save, - check that the new search field has been saved, - also test field deletions, - check that you can't delete already mapped fields. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com>
Patches rebased and squashed
What a great way for me to say "Hey, I'm the new in-house dev for Collecto's version of Koha!" Thanks again, I swear next time I have to break something, it'll be much more impressive.
Sorry chaps, this one no longer applies
Is there any way to apply this functionnality on top of the master branch as of now?
Created attachment 120104 [details] [review] Bug 20388 - Elasticsearch - Ability to add search fields from UI Test plan: - apply this patch, - check that SearchEngine system preference is set to Elasticsearch, - go to Admin > Search engine configuration, - on the search fields tab, fill a new line at the bottom of the table (name, label, type) - click on the "Add" button and save, - check that the new search field has been saved, - also test field deletions, - check that you can't delete already mapped fields. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com>
Patch rebased
Needs Signoff, again? How was the rebase Alex?
(In reply to Jonathan Druart from comment #118) > Needs Signoff, again? How was the rebase Alex? The last one was tiny. But the one 2 weeks ago was tricky. A new signoff wouldn't be too much.
Hi Alex! I'm trying my hand at sign offs. On a koha-docker-testing CT using master branch, I seem to fall on this error upon entering the ElasticSearch mappings setup : https://pastebin.com/8Mj7LzvM Something I'm doing wrong? I remember this message being addressed in one of the obsoleted patches. Thanks a lot!
(In reply to Gérard Simon Voyer from comment #120) > Hi Alex! > > I'm trying my hand at sign offs. On a koha-docker-testing CT using master > branch, I seem to fall on this error upon entering the ElasticSearch > mappings setup : https://pastebin.com/8Mj7LzvM > > Something I'm doing wrong? I remember this message being addressed in one of > the obsoleted patches. > > Thanks a lot! Hi, you can try Actions > Refresh Schema to see if this fixes the issue. An Actions > Restart services also sometimes doesn't hurt (restarts Plack, Memcached, Apache etc.)
Patch no longer applies 8-(.. git bz apply 20388 Bug 20388 - Elasticsearch - Ability to add search fields from UI 120104 - Bug 20388 - Elasticsearch - Ability to add search fields from UI Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 20388 - Elasticsearch - Ability to add search fields from UI Using index info to reconstruct a base tree... M Koha/SearchField.pm M admin/searchengine/elasticsearch/mappings.pl M koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt M koha-tmpl/intranet-tmpl/prog/js/elasticsearch-mappings.js Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/js/elasticsearch-mappings.js CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/js/elasticsearch-mappings.js Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt Auto-merging admin/searchengine/elasticsearch/mappings.pl Auto-merging Koha/SearchField.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 20388 - Elasticsearch - Ability to add search fields from UI
Just ran into this again - especially with us not updating the default mappings on update it would be important to allow libraries to add indexes i think.
Is it possible to rebase? It seems that many libraries and support providers are interested. And a lot of work has already been done, it would be a pity if it did not continue
Created attachment 163449 [details] [review] Bug 20388: Elasticsearch - Ability to add search fields from UI Test plan: - apply this patch, - check that SearchEngine system preference is set to Elasticsearch, - go to Admin > Search engine configuration, - on the search fields tab, fill a new line at the bottom of the table (name, label, type) - click on the "Add" button and save, - check that the new search field has been saved, - also test field deletions, - check that you can't delete already mapped fields. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com>
Created attachment 163450 [details] [review] Bug 20388: Adjust code Sponsored-by: The Research University in the Helmholtz Association (KIT)
Created attachment 163451 [details] [review] Bug 20388: Add trash icon to the delete button Sponsored-by: The Research University in the Helmholtz Association (KIT)
Created attachment 163452 [details] [review] Bug 20388: Alert if the search field already exists Sponsored-by: The Research University in the Helmholtz Association (KIT)
Created attachment 163460 [details] [review] Bug 20388: Elasticsearch - Ability to add search fields from UI Test plan: - apply this patch, - check that SearchEngine system preference is set to Elasticsearch, - go to Admin > Search engine configuration, - on the search fields tab, fill a new line at the bottom of the table (name, label, type) - click on the "Add" button and save, - check that the new search field has been saved, - also test field deletions, - check that you can't delete already mapped fields. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Created attachment 163461 [details] [review] Bug 20388: Adjust code Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Created attachment 163462 [details] [review] Bug 20388: Add trash icon to the delete button Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Created attachment 163463 [details] [review] Bug 20388: Alert if the search field already exists Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Created attachment 164529 [details] [review] Bug 20388: Alert if the search field already exists Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Thomas Klausner <domm@plix.at>
Created attachment 164530 [details] [review] Bug 20388: Alert if the search field already exists Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: David Schmidt <davewood@gmx.at>
Created attachment 164531 [details] [review] Bug 20388: Alert if the search field already exists Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: David Schmidt <davewood@gmx.at> Signed-off-by: Thomas Klausner <domm@plix.at>
Created attachment 164532 [details] [review] Bug 20388: Elasticsearch - Ability to add search fields from UI Test plan: - apply this patch, - check that SearchEngine system preference is set to Elasticsearch, - go to Admin > Search engine configuration, - on the search fields tab, fill a new line at the bottom of the table (name, label, type) - click on the "Add" button and save, - check that the new search field has been saved, - also test field deletions, - check that you can't delete already mapped fields. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: David Schmidt <davewood@gmx.at>
Created attachment 164533 [details] [review] Bug 20388: Adjust code Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: David Schmidt <davewood@gmx.at>
Created attachment 164534 [details] [review] Bug 20388: Add trash icon to the delete button Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: David Schmidt <davewood@gmx.at>
Created attachment 164535 [details] [review] Bug 20388: Alert if the search field already exists Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: David Schmidt <davewood@gmx.at> Signed-off-by: Thomas Klausner <domm@plix.at> Signed-off-by: David Schmidt <davewood@gmx.at>
Created attachment 164789 [details] [review] Bug 20388: Elasticsearch - Ability to add search fields from UI Test plan: - apply this patch, - check that SearchEngine system preference is set to Elasticsearch, - go to Admin > Search engine configuration, - on the search fields tab, fill a new line at the bottom of the table (name, label, type) - click on the "Add" button and save, - check that the new search field has been saved, - also test field deletions, - check that you can't delete already mapped fields. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: David Schmidt <davewood@gmx.at> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 164790 [details] [review] Bug 20388: Adjust code Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: David Schmidt <davewood@gmx.at> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 164791 [details] [review] Bug 20388: Add trash icon to the delete button Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: David Schmidt <davewood@gmx.at> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 164792 [details] [review] Bug 20388: Alert if the search field already exists Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: David Schmidt <davewood@gmx.at> Signed-off-by: Thomas Klausner <domm@plix.at> Signed-off-by: David Schmidt <davewood@gmx.at> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 164793 [details] [review] Bug 20388: (QA follow-up) Tidy Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Small notes from testing (for future follow-ups, not here) The 'Add' button cannot be tabbed to - this feels like a small accessibility lack After adding a field, I must save before I can add mappings - seems ok I was able to, in the interface, delete a field with a mapping, but saving gave an error and all was restored - ok
(In reply to Nick Clemens from comment #145) > Small notes from testing (for future follow-ups, not here) > > The 'Add' button cannot be tabbed to - this feels like a small accessibility > lack > After adding a field, I must save before I can add mappings - seems ok > I was able to, in the interface, delete a field with a mapping, but saving > gave an error and all was restored - ok Could you please file bugs for these? So we don't lose sight of them. Thank you!
Pushed for 24.05! Well done everyone, thank you!
I have updated the release notes. Is it a new feature or an enhancement?
(In reply to David Nind from comment #148) > I have updated the release notes. > > Is it a new feature or an enhancement? I think enh is OK here: we had the ability do to this before, but it got heaps easier now.
Not backported to 23.11.x