Apply dataTable on search fields and mapping tables to be able to sort and filter data.
Created attachment 74241 [details] [review] Bug 20588 - Apply dataTable on search fields and mapping tables This add the following capabilities: - Pagination, - columns sorting, - data filtering Test plan: - apply this patch, - update DB and schema files, - add/remove search fields and mappings
Hiya Alex, Applying: Bug 20588 - Apply dataTable on search fields and mapping tables fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 20588 - Apply dataTable on search fields and mapping tables
(In reply to Nicolas Legrand from comment #2) > Hiya Alex, > > Applying: Bug 20588 - Apply dataTable on search fields and mapping tables > fatal: sha1 information is lacking or useless > (koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/ > mappings.tt). > Repository lacks necessary blobs to fall back on 3-way merge. > Cannot fall back to three-way merge. > Patch failed at 0001 Bug 20588 - Apply dataTable on search fields and > mapping tables Hello Nicolas, Did you apply in order: 18316 and 20388 ?
I applied it with Jonathan autoapply : $ git bz apply 20588 Bug 20588 Depends on bug 20388 Follow? [(y)es, (n)o] y Bug 20388 Depends on bug 18316 Follow? [(y)es, (n)o] y Bug 18316 - Add weighting/relevancy options to ElasticSearch 74115 - Bug 18316: Ability to weight search fields 74116 - Bug 18316: Add weighting/relevancy options to ES query on simple search 74117 - Bug 18316: String changes Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 18316: Ability to weight search fields Applying: Bug 18316: Add weighting/relevancy options to ES query on simple search Applying: Bug 18316: String changes Bug 20388 - Elasticsearch - Ability to add search fields from UI 73945 - Bug 20388 - Add/delete search fields from search engine configuration page 73946 - Bug 20388 - Keep data consistency when adding/removing mapping 74261 - Bug 11674: DBRev 17.12.00.031 Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 20388 - Add/delete search fields from search engine configuration page Applying: Bug 20388 - Keep data consistency when adding/removing mapping Applying: Bug 11674: DBRev 17.12.00.031 Using index info to reconstruct a base tree... M Koha.pm A installer/data/mysql/atomicupdate/bug_11674-config_for_marc_field_doc_urls.sql M installer/data/mysql/updatedatabase.pl Falling back to patching base and 3-way merge... No changes -- Patch already applied. Bug 20588 - Elasticsearch - Apply dataTable on search fields and mapping tables 74241 - Bug 20588 - Apply dataTable on search fields and mapping tables Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 20588 - Apply dataTable on search fields and mapping tables fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 20588 - Apply dataTable on search fields and mapping tables
Created attachment 74312 [details] [review] Bug 20588 - Apply dataTable on search fields and mapping tables This add the following capabilities: - Pagination, - columns sorting, - data filtering Test plan: - apply this patch, - update DB and schema files, - add/remove search fields and mappings
I've rebased the patch. Please try again
Looks like this patch removes the ability to sort the table (plugin tablednd), and store this order in DB. Are you sure we do no longer need that?
Created attachment 74315 [details] [review] Bug 20588 - Apply dataTable on search fields and mapping tables This add the following capabilities: - Pagination, - columns sorting, - data filtering Test plan: - apply this patch, - update DB and schema files, - add/remove search fields and mappings Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Jonathan has an other view of the patch. As user, it looks pretty good to me !
(In reply to Jonathan Druart from comment #7) > Looks like this patch removes the ability to sort the table (plugin > tablednd), and store this order in DB. Are you sure we do no longer need > that? This patch exactly add the ability to sort tables columns. And, if i understand what you are talking about, we don't lose the drag and drop feature provided by tableDnD plugin.
Sorting by user's preference I meant, not sorting by alpha/num Moreover the drag and drop functionality does not longer work after one of the column has been sorted. I do not remember if this is used, could be useful later, or totally useless.
Changing status to BLOCKED, as it depends on 20388, which needs a rebase.
Created attachment 78660 [details] [review] Bug 20588 - Apply dataTable on search fields and mapping tables This add the following capabilities: - Pagination, - columns sorting, - data filtering Test plan: - apply this patch, - update DB and schema files, - add/remove search fields and mappings Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
BLOCKED by bug 20338 dependency being Needs Signoff.
(In reply to Katrin Fischer from comment #14) > BLOCKED by bug 20338 dependency being Needs Signoff. Should be BLOCKED by bug 20388 - which is signed off now, so unlocking.
Blocked by dependency bug 20388 awaiting sign-off.
Created attachment 90576 [details] [review] Bug 20588: Apply dataTable on search fields and mapping tables This add the following capabilities: - Pagination, - columns sorting, - data filtering Test plan: - apply this patch, - update DB and schema files, - add/remove search fields and mappings
I just made a rebase
*** Bug 19598 has been marked as a duplicate of this bug. ***
Created attachment 90585 [details] [review] Bug 20588: Apply dataTable on search fields and mapping tables This add the following capabilities: - Pagination, - columns sorting, - data filtering Test plan: - apply this patch, - update DB and schema files, - add/remove search fields and mappings Signed-off-by: Michal Denar <black23@gmail.com>
*** This bug has been marked as a duplicate of bug 27682 ***