This patch will convert several unrelated templates to use the Bootstrap grid: - patroncards/print.tt - patron_lists/add-modify.tt - plugins/plugins-disabled.tt - plugins/plugins-upload.tt - tools/tools-home.tt - virtualshelves/merge.tt
Created attachment 74813 [details] [review] Bug 20650: Switch single-column templates to Bootstrap grid: Various, part 3 This patch updates various unrelated templates to use the Bootstrap grid. In each case, confirm that the indicated page looks correct. This patch also corrects a couple of capitalization errors and removes an unused template: virtualshelves/merge.tt. - Tools -> Patron card creator -> Manage -> Card batches - Export a batch - The pages inside the modal window should look correct: Both the "X batch(es) to export" screen and the "download exported batch(es)" one. - Tools -> Patron lists -> Edit list - The patron list add/edit form should look correct. - Disable plugins in koha-conf.xml. - Tools -> Plugins - The "Plugins disabled" page should look correct. - Enable plugins in koha-conf.xml - Tools -> Plugins -> Upload plugins. - This page should look correct. - Tools - The tools home page should show three columns: Patrons and Circulation, Catalog, Additional tools. - At viewport width below 768 pixels content should reflow into one column. - virtualshelves/merge.tt has been removed as it is unused. Search the codebase for references to it. There should be none.
hullo, I am getting the same issue that we had on bug 19709 (now fixed) that the 'Cancel' Link in the Modal for x batch to export doesn't work and similarly the 'done' button in the batch download Modal also does nothing. Everything else is looking good!
Created attachment 75267 [details] [review] Bug 20650: Switch single-column templates to Bootstrap grid: Various, part 3 This patch updates various unrelated templates to use the Bootstrap grid. In each case, confirm that the indicated page looks correct. This patch also corrects a couple of capitalization errors and removes an unused template: virtualshelves/merge.tt. - Tools -> Patron card creator -> Manage -> Card batches - Export a batch - The pages inside the modal window should look correct: Both the "X batch(es) to export" screen and the "download exported batch(es)" one. - Tools -> Patron lists -> Edit list - The patron list add/edit form should look correct. - Disable plugins in koha-conf.xml. - Tools -> Plugins - The "Plugins disabled" page should look correct. - Enable plugins in koha-conf.xml - Tools -> Plugins -> Upload plugins. - This page should look correct. - Tools - The tools home page should show three columns: Patrons and Circulation, Catalog, Additional tools. - At viewport width below 768 pixels content should reflow into one column. - virtualshelves/merge.tt has been removed as it is unused. Search the codebase for references to it. There should be none.
Created attachment 75301 [details] [review] Bug 20650: Switch single-column templates to Bootstrap grid: Various, part 3 This patch updates various unrelated templates to use the Bootstrap grid. In each case, confirm that the indicated page looks correct. This patch also corrects a couple of capitalization errors and removes an unused template: virtualshelves/merge.tt. - Tools -> Patron card creator -> Manage -> Card batches - Export a batch - The pages inside the modal window should look correct: Both the "X batch(es) to export" screen and the "download exported batch(es)" one. - Tools -> Patron lists -> Edit list - The patron list add/edit form should look correct. - Disable plugins in koha-conf.xml. - Tools -> Plugins - The "Plugins disabled" page should look correct. - Enable plugins in koha-conf.xml - Tools -> Plugins -> Upload plugins. - This page should look correct. - Tools - The tools home page should show three columns: Patrons and Circulation, Catalog, Additional tools. - At viewport width below 768 pixels content should reflow into one column. - virtualshelves/merge.tt has been removed as it is unused. Search the codebase for references to it. There should be none. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Owen, I think doc-head-open is missing from patroncards/print.tt, could you confirm?
Created attachment 76170 [details] [review] Bug 20650: (follow-up) Add missing include file This patch adds a missing include of doc-head-open.inc. To test, apply the patch and export a batch of patron cards. The modal view for downloading the card batch PDF should work correctly. Validating the iframe's source should show no relevant errors.
Created attachment 76171 [details] [review] Bug 20650: Switch single-column templates to Bootstrap grid: Various, part 3 This patch updates various unrelated templates to use the Bootstrap grid. In each case, confirm that the indicated page looks correct. This patch also corrects a couple of capitalization errors and removes an unused template: virtualshelves/merge.tt. - Tools -> Patron card creator -> Manage -> Card batches - Export a batch - The pages inside the modal window should look correct: Both the "X batch(es) to export" screen and the "download exported batch(es)" one. - Tools -> Patron lists -> Edit list - The patron list add/edit form should look correct. - Disable plugins in koha-conf.xml. - Tools -> Plugins - The "Plugins disabled" page should look correct. - Enable plugins in koha-conf.xml - Tools -> Plugins -> Upload plugins. - This page should look correct. - Tools - The tools home page should show three columns: Patrons and Circulation, Catalog, Additional tools. - At viewport width below 768 pixels content should reflow into one column. - virtualshelves/merge.tt has been removed as it is unused. Search the codebase for references to it. There should be none. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 76172 [details] [review] Bug 20650: (follow-up) Add missing include file This patch adds a missing include of doc-head-open.inc. To test, apply the patch and export a batch of patron cards. The modal view for downloading the card batch PDF should work correctly. Validating the iframe's source should show no relevant errors. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 76173 [details] [review] Bug 20650: Remove unused virtualshelves/merge.tt Committed by Jonathan Druart, get out from first patch of this patchset. It's a follow-up of bug 4019 which removed virtualshelves/merge.pl Moving this change to its own commit to make it clear in the git log and easier to backport if needed. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Awesome work all! Pushed to master for 18.11
Enhancement, not backporting to 18.05.x series.
*** Bug 20642 has been marked as a duplicate of this bug. ***