Koha gives the ability to print Patron cards from the Patron Lists tool. To recreate 1. Go to a Patron List, use Actions 2. choose Print Patron Cards. 3. Once a layout and template have been chosen, Koha gives the box to Print Patron cards, but this box is empty. No PDF is loaded or displayed and there are no options within this screen. Using the Patron Card creator and choosing a Patron List does work correctly.
Broken feature - confirmed. Funnily, there is no error in the plack-error-log or the console, the xhr request response is: Click on the link to download the patron cards from the patron list. label_patronlist_1.pdf But we are not seeing it. Adding Owen as I tihnk this might be an issue template/Javascript side?
Git bisect blames me and Bug 20650.
Bad Owen ;) Do you have an idea what's going on?
Created attachment 92239 [details] [review] Bug 23455: Patron card printing from Patron lists is broken This patch makes a few corrections to the process of printing patron cards from the patron lists page. These changes are necessitated by Bug 20650: Changes to the markup in patroncards/print.tt were not reflected in the JavaScript in patron_lists/lists.tt. Also fixed: A missing quotation mark, a missing semicolon, and incorrect template variable filter. To test, apply the patch and go to Tools -> Patron lists. - Click the "Actions" menu corresponding to a patron list. - Select "Print patron cards." - In the "Print patron cards" modal, click the "Export" button. - The modal should reload with a link to download a patron card PDF. The link should work correctly. https://bugs.koha-community.org/show_bug.cgi?id=23445
Created attachment 92245 [details] [review] Bug 23455: Patron card printing from Patron lists is broken This patch makes a few corrections to the process of printing patron cards from the patron lists page. These changes are necessitated by Bug 20650: Changes to the markup in patroncards/print.tt were not reflected in the JavaScript in patron_lists/lists.tt. Also fixed: A missing quotation mark, a missing semicolon, and incorrect template variable filter. To test, apply the patch and go to Tools -> Patron lists. - Click the "Actions" menu corresponding to a patron list. - Select "Print patron cards." - In the "Print patron cards" modal, click the "Export" button. - The modal should reload with a link to download a patron card PDF. The link should work correctly. https://bugs.koha-community.org/show_bug.cgi?id=23445 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
I wonder if we could do without the: Click on the link to download the patron cards from the patron list And Instead just add a "Download.... to the displayed link.
Created attachment 92257 [details] [review] Bug 23455: Patron card printing from Patron lists is broken This patch makes a few corrections to the process of printing patron cards from the patron lists page. These changes are necessitated by Bug 20650: Changes to the markup in patroncards/print.tt were not reflected in the JavaScript in patron_lists/lists.tt. Also fixed: A missing quotation mark, a missing semicolon, and incorrect template variable filter. To test, apply the patch and go to Tools -> Patron lists. - Click the "Actions" menu corresponding to a patron list. - Select "Print patron cards." - In the "Print patron cards" modal, click the "Export" button. - The modal should reload with a link to download a patron card PDF. The link should work correctly. https://bugs.koha-community.org/show_bug.cgi?id=23445 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Nice work! Pushed to master for 19.11.00
Pushed to 19.05.x for 19.05.03
backported to 18.11.x for 18.11.09