Bug 20740 - Update two-column templates with Bootstrap grid: Administration part 4
Summary: Update two-column templates with Bootstrap grid: Administration part 4
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 20668
Blocks: 20654
  Show dependency treegraph
 
Reported: 2018-05-09 11:59 UTC by Owen Leonard
Modified: 2019-10-14 19:56 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 20740: Update two-column templates with Bootstrap grid, Administration part 4 (10.06 KB, patch)
2018-07-16 16:42 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 20740: Update two-column templates with Bootstrap grid, Administration part 4 (10.12 KB, patch)
2018-08-16 13:21 UTC, Claire Gravely
Details | Diff | Splinter Review
Bug 20740: Update two-column templates with Bootstrap grid, Administration part 4 (10.28 KB, patch)
2018-08-16 19:07 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2018-05-09 11:59:43 UTC
This patch will convert yet more administration templates to use the Bootstrap grid:

 - currency.tt
 - didyoumean.tt
 - edi_accounts.tt
 - edi_ean_accounts.tt
 - items_search_field.tt
 - items_search_fields.tt
Comment 1 Owen Leonard 2018-07-16 16:42:03 UTC
Created attachment 77017 [details] [review]
Bug 20740: Update two-column templates with Bootstrap grid, Administration part 4

This patch modifies several administration templates to use the
Bootstrap grid instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags in the modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Administration -> Currencies and exchange rates
   - View and edit currencies
 - Administration -> Did you mean?
 - Administration -> EDI accounts
   - View and edit accounts
 - Administration -> Library EANs
   - View and edit EANs
 - Administration -> Item search fields
   - View and edit item search fields
Comment 2 Claire Gravely 2018-08-16 11:28:14 UTC
In currencies and exchange rates the table appears to the right of the Column visibility etc buttons. Should it be below rather than next to?

Other pages are all fine.
Comment 3 Owen Leonard 2018-08-16 13:14:05 UTC
(In reply to Claire Gravely from comment #2)
> In currencies and exchange rates the table appears to the right of the
> Column visibility etc buttons. Should it be below rather than next to?

I have fixed this in a separate bug as it is unrelated to the changes in this patch. Bug 21234.
Comment 4 Claire Gravely 2018-08-16 13:21:03 UTC
Created attachment 77927 [details] [review]
Bug 20740: Update two-column templates with Bootstrap grid, Administration part 4

This patch modifies several administration templates to use the
Bootstrap grid instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags in the modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Administration -> Currencies and exchange rates
   - View and edit currencies
 - Administration -> Did you mean?
 - Administration -> EDI accounts
   - View and edit accounts
 - Administration -> Library EANs
   - View and edit EANs
 - Administration -> Item search fields
   - View and edit item search fields

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Comment 5 Jonathan Druart 2018-08-16 19:07:09 UTC
Created attachment 77941 [details] [review]
Bug 20740: Update two-column templates with Bootstrap grid, Administration part 4

This patch modifies several administration templates to use the
Bootstrap grid instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags in the modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Administration -> Currencies and exchange rates
   - View and edit currencies
 - Administration -> Did you mean?
 - Administration -> EDI accounts
   - View and edit accounts
 - Administration -> Library EANs
   - View and edit EANs
 - Administration -> Item search fields
   - View and edit item search fields

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 6 Jonathan Druart 2018-08-16 19:08:30 UTC
I have rebased the patch on top of bug 13618 as it should be the next one to be pushed.

Also found bug 21239 while testing (not caused by this patch).
Comment 7 Nick Clemens 2018-08-30 14:10:05 UTC
Awesome work all!

Pushed to master for 18.11
Comment 8 Martin Renvoize 2018-09-05 10:24:00 UTC
Enhancement, will not be backported to 18.05.x series.