Bug 21234 - Remove our .clearfix class in favor of Bootstrap's
Summary: Remove our .clearfix class in favor of Bootstrap's
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Josef Moravec
URL:
Keywords:
Depends on:
Blocks: 21239
  Show dependency treegraph
 
Reported: 2018-08-16 13:01 UTC by Owen Leonard
Modified: 2019-10-14 19:57 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 21234: Remove our .clearfix class in favor of Bootstrap's (1.40 KB, patch)
2018-08-16 13:11 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 21234: Remove our .clearfix class in favor of Bootstrap's (1.48 KB, patch)
2018-08-17 13:19 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 21234: Remove our .clearfix class in favor of Bootstrap's (1.53 KB, patch)
2018-08-21 16:07 UTC, Josef Moravec
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2018-08-16 13:01:40 UTC
Bootstrap in the staff client has its own ".clearfix" class which appears to be conflicting with the one in staff-global.scss. Removing .clearfix from staff-global.scss fixes it.

See https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20740#c2.
Comment 1 Owen Leonard 2018-08-16 13:11:07 UTC
Created attachment 77922 [details] [review]
Bug 21234: Remove our .clearfix class in favor of Bootstrap's

This patch removes the ".clearfix" declaration from staff-global.scss so
that Bootstrap's built-in clearfix class will be used.

To reproduce this issue, see Administration -> Currencies and exchange
rates. The table of currencies does not appear below the table buttons.

Apply the patch and regenerate CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

Clear the browser cache if necessary and reload the Currencies and
exchange rates page. The table should appear in the correct position.
Comment 2 Jonathan Druart 2018-08-17 13:19:23 UTC
Created attachment 77976 [details] [review]
Bug 21234: Remove our .clearfix class in favor of Bootstrap's

This patch removes the ".clearfix" declaration from staff-global.scss so
that Bootstrap's built-in clearfix class will be used.

To reproduce this issue, see Administration -> Currencies and exchange
rates. The table of currencies does not appear below the table buttons.

Apply the patch and regenerate CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

Clear the browser cache if necessary and reload the Currencies and
exchange rates page. The table should appear in the correct position.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 3 Josef Moravec 2018-08-21 16:07:45 UTC
Created attachment 78047 [details] [review]
Bug 21234: Remove our .clearfix class in favor of Bootstrap's

This patch removes the ".clearfix" declaration from staff-global.scss so
that Bootstrap's built-in clearfix class will be used.

To reproduce this issue, see Administration -> Currencies and exchange
rates. The table of currencies does not appear below the table buttons.

Apply the patch and regenerate CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

Clear the browser cache if necessary and reload the Currencies and
exchange rates page. The table should appear in the correct position.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 4 Nick Clemens 2018-08-22 15:02:35 UTC
Awesome work all!

Pushed to master for 18.11
Comment 5 Martin Renvoize 2018-08-24 10:41:51 UTC
Caused by bug 19474 not in 18.05.x branch.