Bootstrap in the staff client has its own ".clearfix" class which appears to be conflicting with the one in staff-global.scss. Removing .clearfix from staff-global.scss fixes it. See https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20740#c2.
Created attachment 77922 [details] [review] Bug 21234: Remove our .clearfix class in favor of Bootstrap's This patch removes the ".clearfix" declaration from staff-global.scss so that Bootstrap's built-in clearfix class will be used. To reproduce this issue, see Administration -> Currencies and exchange rates. The table of currencies does not appear below the table buttons. Apply the patch and regenerate CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Clear the browser cache if necessary and reload the Currencies and exchange rates page. The table should appear in the correct position.
Created attachment 77976 [details] [review] Bug 21234: Remove our .clearfix class in favor of Bootstrap's This patch removes the ".clearfix" declaration from staff-global.scss so that Bootstrap's built-in clearfix class will be used. To reproduce this issue, see Administration -> Currencies and exchange rates. The table of currencies does not appear below the table buttons. Apply the patch and regenerate CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Clear the browser cache if necessary and reload the Currencies and exchange rates page. The table should appear in the correct position. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 78047 [details] [review] Bug 21234: Remove our .clearfix class in favor of Bootstrap's This patch removes the ".clearfix" declaration from staff-global.scss so that Bootstrap's built-in clearfix class will be used. To reproduce this issue, see Administration -> Currencies and exchange rates. The table of currencies does not appear below the table buttons. Apply the patch and regenerate CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Clear the browser cache if necessary and reload the Currencies and exchange rates page. The table should appear in the correct position. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Awesome work all! Pushed to master for 18.11
Caused by bug 19474 not in 18.05.x branch.