There is 2 display issues with the table "Holds history" tab : - no change when modifying "Column settings > Patrons > (id=holdshistory-table)". I don't know if it is linked, but the <table id> on the tab is "table_holdshistory". - column "Item type" is always empty
(In reply to Séverine Queune from comment #0) > There is 2 display issues with the table "Holds history" tab : > - no change when modifying "Column settings > Patrons > > (id=holdshistory-table)". I don't know if it is linked, but the <table id> > on the tab is "table_holdshistory". This is caused by bug 9573, where the first parameter of KohaTable function was changed from selector to id > - column "Item type" is always empty
Created attachment 75625 [details] [review] Bug 20806: Add item type description holds history page Test plan: 0) Do not apply the patch 1) Set AllowHoldItemTypeSelection to Allow 2) Place some hold for a patron, some with specific item type and some without item typ 3) On holds history page you should see blank or item type code in item type column 4) Apply the patch 5) Now you should see description in item type column
I'm quite confused... If I understand correctly the patch, the (new) column "Request item type" is filled with the hold level. Personally, I though to see the 'items.itype' value. As we only authorised item level holds because of our local use, it would have been more useful because with this patch we will only have "Any item itype" displayed. Can you confirm this is the behaviour you were waiting for ? If so, as patch applies correctly, I will sign it. PS : sorting option for the table is a good idea !
Séverine is right, the column is confusing. Maybe we should display it only when AllowHoldItemTypeSelection is set?
I think this might be related to AllowHoldItemTypeSelection that allows you to pick an itemtype when placing the hold? Maybe we can make the visibility of the column depend on that?
... which is exactly what Jonathan suggested.
I think with the change to "Requested item type" the patch makes sense to me. Only thing I'd is a check for the AllowHoldItemTypeSelection system preference to decide about showing it or not.
Created attachment 76370 [details] [review] Bug 20806: Add item type description holds history page Test plan: 0) Do not apply the patch 1) Set AllowHoldItemTypeSelection to Allow 2) Place some hold for a patron, some with specific item type and some without item type 3) On holds history page you should see blank or item type code in item type column 4) Apply the patch 5) Now you should see description in item type column 6) Set AllowHoldItemTypeSelection to Don't Allow 7) You shold not see the item type column, but column visibility settings should continue working ;)
Thanks all for comments/suggestions. I added the check of AllowHoldItemTypeSelection system preference
Created attachment 76585 [details] [review] Bug 20806: Add item type description holds history page Test plan: 0) Do not apply the patch 1) Set AllowHoldItemTypeSelection to Allow 2) Place some hold for a patron, some with specific item type and some without item type 3) On holds history page you should see blank or item type code in item type column 4) Apply the patch 5) Now you should see description in item type column 6) Set AllowHoldItemTypeSelection to Don't Allow 7) You shold not see the item type column, but column visibility settings should continue working ;) Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Followed the test plan and it works.
Created attachment 76591 [details] [review] Bug 20806: Add item type description holds history page Test plan: 0) Do not apply the patch 1) Set AllowHoldItemTypeSelection to Allow 2) Place some hold for a patron, some with specific item type and some without item type 3) On holds history page you should see blank or item type code in item type column 4) Apply the patch 5) Now you should see description in item type column 6) Set AllowHoldItemTypeSelection to Don't Allow 7) You shold not see the item type column, but column visibility settings should continue working ;) Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Followed the test plan and it works. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 76592 [details] [review] Bug 20806: Do not rely on column position It is not the first time we have this splice call, it seems safer to rely on the column's name instead of the column's position Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 76593 [details] [review] Bug 20806: Surround string by span tag to help translation Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Awesome work all! Pushed to master for 18.11
Pushed to 18.05.x for 18.05.03
Depends on Bug 20831 not in 17.11.x