Regression from commit 2059f7d8016ab61172830e9b670279d3e28882b7 Bug 16735: Migrate library search groups into the new hierarchical groups It re-added code that was removed by bug 15758 (use of var BranchesLoop).
Created attachment 75773 [details] [review] Bug 20875: (bug 16735 follow-up) Fix library list for OpacAddMastheadLibraryPulldown This patch fixes a regression introduced by commit 2059f7d8016ab61172830e9b670279d3e28882b7 Bug 16735: Migrate library search groups into the new hierarchical groups It re-added code that was removed by bug 15758 (use of var BranchesLoop). Test plan: - Create library search groups - Turn OpacAddMastheadLibraryPulldown on - At the OPAC confirm that the search box with libraries and library groups is displayed and works correctly. - Remove the library search group - The dropdown list should not have the optgroup tags
Created attachment 75790 [details] [review] Bug 20875: (bug 16735 follow-up) Fix library list for OpacAddMastheadLibraryPulldown This patch fixes a regression introduced by commit 2059f7d8016ab61172830e9b670279d3e28882b7 Bug 16735: Migrate library search groups into the new hierarchical groups It re-added code that was removed by bug 15758 (use of var BranchesLoop). Test plan: - Create library search groups - Turn OpacAddMastheadLibraryPulldown on - At the OPAC confirm that the search box with libraries and library groups is displayed and works correctly. - Remove the library search group - The dropdown list should not have the optgroup tags Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Thx Martin for catching the forgotten status change!
Created attachment 75867 [details] [review] Bug 20875: (bug 16735 follow-up) Fix library list for OpacAddMastheadLibraryPulldown This patch fixes a regression introduced by commit 2059f7d8016ab61172830e9b670279d3e28882b7 Bug 16735: Migrate library search groups into the new hierarchical groups It re-added code that was removed by bug 15758 (use of var BranchesLoop). Test plan: - Create library search groups - Turn OpacAddMastheadLibraryPulldown on - At the OPAC confirm that the search box with libraries and library groups is displayed and works correctly. - Remove the library search group - The dropdown list should not have the optgroup tags Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Simple change works as expected and doesn't break any tests. I'd love to see an accompanying selenium (or whatever) integration test, but as we don't yet have a clear framework for such tests I can't justifiably fail it for not having one.
Pushed to master for 18.11, awesome work all!
This patch has been pushed to 18.05.x and will be in 18.05.01
Depends on Bug 16735 not in 17.11.x