To reproduce: 1) Checkout an item to a patron 2) Go to the biblio record for this item and show checkouts history - you see the current checkout 3) Check in the item back 4) Repeat 2), you will see there is not any checkout in checkouts history for this biblio
Created attachment 76043 [details] [review] Bug 20934: Fix display of old checkouts in the checkout history page Again a regression caused by commit fa54100dffe092e606f79b15692eedaf78f42e45 Bug 18403: Use patron-title.inc when hidepatronname is used [SPECIFIC for issuehistory] GetBiblioIssues does a union all with issues and old_issues, so we should old_issues as well. To make the join on the items table we need to define the item and patron methods. For consistency the relationships have been redefined (item instead of itemnumber, borrower instead of borrowernumber) in the DBIx::Class definition. This is not perfect but I think the best way to provide an easy to backport patch. It highlights that we need improvements in this area.
Created attachment 76104 [details] [review] Bug 20934: Fix display of old checkouts in the checkout history page Again a regression caused by commit fa54100dffe092e606f79b15692eedaf78f42e45 Bug 18403: Use patron-title.inc when hidepatronname is used [SPECIFIC for issuehistory] GetBiblioIssues does a union all with issues and old_issues, so we should old_issues as well. To make the join on the items table we need to define the item and patron methods. For consistency the relationships have been redefined (item instead of itemnumber, borrower instead of borrowernumber) in the DBIx::Class definition. This is not perfect but I think the best way to provide an easy to backport patch. It highlights that we need improvements in this area. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> The patch works as expected.
Created attachment 76141 [details] [review] Bug 20934: Fix display of old checkouts in the checkout history page Again a regression caused by commit fa54100dffe092e606f79b15692eedaf78f42e45 Bug 18403: Use patron-title.inc when hidepatronname is used [SPECIFIC for issuehistory] GetBiblioIssues does a union all with issues and old_issues, so we should old_issues as well. To make the join on the items table we need to define the item and patron methods. For consistency the relationships have been redefined (item instead of itemnumber, borrower instead of borrowernumber) in the DBIx::Class definition. This is not perfect but I think the best way to provide an easy to backport patch. It highlights that we need improvements in this area. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> The patch works as expected. Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 76142 [details] [review] Bug 20934: (QA follow-up) Fix pod in Koha::Old::Checkout Test plan: Run qa tools - it shouldn't complain about pod levels Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 76143 [details] [review] Bug 20934: (QA follow-up) Fix showing number of records in checkout history Test plan: 0) Do not apply this patch 1) Go to biblio checkout history page (issuehistory.pl) 2) You'll see something like "Checked out ARRAY(0xf830378) times" 3) Apply this patch 4) Now you should see number of checkout history records Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
(In reply to Jonathan Druart from comment #1) > > This is not perfect but I think the best way to provide an easy to > backport patch. > > It highlights that we need improvements in this area. Maybe not perfect, but fixing the bug ;) Hope some thing will be fixed during merging issues and oldissues in future...
Awesome work all! Pushed to master for 18.11.x
The checkout history is used in a couple of workflows we have at my library, so it would be really nice if we didn't have to wait until upgrading to 18.11 to get this fix. Are there currently any plans to backport the fix to 18.05? If not, would it be helpful for me to create a patch for it?
Hmm, this was just an oversight on my part... Not sure how I missed it [U+1F617]. I'll grab it shortly and reporeport back
Pushed to 18.05.x for 18.05.02
Depends on Bug 20899 not in 17.11.x