Even with the prefs set to show the name, the name doesn't seem to be showing here since the feature for groups was pushed. To replicate: Issue an item, go to the biblio, click the circulation history for this tab. Note that the patron's name is not showing here.
Caused by commit fa54100dffe092e606f79b15692eedaf78f42e45 Bug 18403: Use patron-title.inc when hidepatronname is used [SPECIFIC for issuehistory]
Created attachment 75975 [details] [review] Bug 20899: Fix patron's name display This is a follow-up for commit fa54100dffe092e606f79b15692eedaf78f42e45 Bug 18403: Use patron-title.inc when hidepatronname is used [SPECIFIC for issuehistory] We should use patron-title.inc to display (or hide) patron's info on the checkout history view Test plan: Issue an item, go to the biblio, click the circulation history for this tab. Note that the patron's name is showing.
Created attachment 75998 [details] [review] Bug 20899: Fix patron's name display This is a follow-up for commit fa54100dffe092e606f79b15692eedaf78f42e45 Bug 18403: Use patron-title.inc when hidepatronname is used [SPECIFIC for issuehistory] We should use patron-title.inc to display (or hide) patron's info on the checkout history view Test plan: Issue an item, go to the biblio, click the circulation history for this tab. Note that the patron's name is showing. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Works as expected :)
Created attachment 76027 [details] [review] Bug 20899: Fix patron's name display This is a follow-up for commit fa54100dffe092e606f79b15692eedaf78f42e45 Bug 18403: Use patron-title.inc when hidepatronname is used [SPECIFIC for issuehistory] We should use patron-title.inc to display (or hide) patron's info on the checkout history view Test plan: Issue an item, go to the biblio, click the circulation history for this tab. Note that the patron's name is showing. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 76042 [details] [review] Bug 20899: Fix patron's name display This is a follow-up for commit fa54100dffe092e606f79b15692eedaf78f42e45 Bug 18403: Use patron-title.inc when hidepatronname is used [SPECIFIC for issuehistory] We should use patron-title.inc to display (or hide) patron's info on the checkout history view Test plan: Issue an item, go to the biblio, click the circulation history for this tab. Note that the patron's name is showing. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Patch amended, td tag was not closed!
Awesome work all! Pushed to master for 18.11
Pushed to 18.05.x for 18.05.01
Depends on Bug 18403 not in 17.11.x