When OverDrive circulation/integration was introduced it used the 'Granted authentication' API This API is no longer supported on OverDrive's new library sites, we need to switch to the 'Patron authentication' API
Created attachment 77053 [details] [review] Bug 21082: Database updates
Created attachment 77054 [details] [review] Bug 21082: Add new admin page for overdrive The 'authname' field required for OverDrive can differ per branch. This patch adds Koha Objects for dealing with OD info and submitting authnames per branch. The description is left open so future branch info can be added. To test: 1 - prove -v t/db_dependent/Koha/Library/OverDriveInfos.t 2 - visit cgi-bin/koha/admin/overdrive.pl 3 - Add some authnames for various branches 4 - Verify data saves correctly
Created attachment 77055 [details] [review] Bug 21082: DO NOT PUSH - Schema changes
Created attachment 77056 [details] [review] Bug 21082: Update OverDrive authentication method Testing will require an OverDrive account, you should be able to obtain a developer account here: https://developer.overdrive.com/ You will need to register a SIP connection for patron authentication To test authentication: 1 - Set authname default in OD prefs 2 - Sign in as a patron whose branch matches authname 3 - Verify the patron can sign into OverDrive 4 - Set the patrons branch authname to be incorrect 5 - Verify branch specific authname is used and patron cannot sign in 6 - Set the default authname to be incorrect and patron's branch authname to be correct 7 - Verofy patron can sign in To test circulation: 1 - Fill out all OD prefs and enable circulation 2 - Sign in to opac 3 - Verify you have an OverDrive tab 4 - Click 'Login to Overdrive' 5 - If password required you shoudl be prompted, otherwise you should be signed in and see account info 6 - Test logging out and in 7 - Log-in, perform a search on the opac - you should see hold/checkout buttons 8 - Test the buttons 9 - After holding/checking out items, check your account page 10 - Verify info is correct 11 - Log out of overdrive 12 - Search catalog click overdrive results 13 - Test "Login to Overdrive" link on OD results 14 - Verify page is reloaded, buttons show and work
Comment on attachment 77053 [details] [review] Bug 21082: Database updates Review of attachment 77053 [details] [review]: ----------------------------------------------------------------- ::: installer/data/mysql/sysprefs.sql @@ +415,4 @@ > ('OverDriveClientKey','','Client key for OverDrive integration','30','Free'), > ('OverDriveClientSecret','','Client key for OverDrive integration','30','YesNo'), > ('OverDriveLibraryID','','Library ID for OverDrive integration','','Integer'), > +('OverDrivePasswordRequired','',NULL,'Does the library require passwords for OverDrive SIP authentication','Free'), Shouldn't 'Free' be 'YesNo'?
Comment on attachment 77056 [details] [review] Bug 21082: Update OverDrive authentication method Review of attachment 77056 [details] [review]: ----------------------------------------------------------------- ::: opac/svc/overdrive @@ +45,4 @@ > eval { > { > $action eq 'login' && do { > + my $password = $cgi->param("password") // "" ; Not a real issue, but q{} is perlcritic friendlier. Even '' would be better than "".
Created attachment 79792 [details] [review] Bug 21082: Database updates https://bugs.koha-community.org/show_bug.cgi?id=2108 Current status: Needs Signoff
Created attachment 79793 [details] [review] Bug 21082: Add new admin page for overdrive The 'authname' field required for OverDrive can differ per branch. This patch adds Koha Objects for dealing with OD info and submitting authnames per branch. The description is left open so future branch info can be added. To test: 1 - prove -v t/db_dependent/Koha/Library/OverDriveInfos.t 2 - visit cgi-bin/koha/admin/overdrive.pl 3 - Add some authnames for various branches 4 - Verify data saves correctly https://bugs.koha-community.org/show_bug.cgi?id=2108
Created attachment 79794 [details] [review] Bug 21082: Update OverDrive authentication method Testing will require an OverDrive account, you should be able to obtain a developer account here: https://developer.overdrive.com/ You will need to register a SIP connection for patron authentication To test authentication: 1 - Set authname default in OD prefs 2 - Sign in as a patron whose branch matches authname 3 - Verify the patron can sign into OverDrive 4 - Set the patrons branch authname to be incorrect 5 - Verify branch specific authname is used and patron cannot sign in 6 - Set the default authname to be incorrect and patron's branch authname to be correct 7 - Verofy patron can sign in To test circulation: 1 - Fill out all OD prefs and enable circulation 2 - Sign in to opac 3 - Verify you have an OverDrive tab 4 - Click 'Login to Overdrive' 5 - If password required you shoudl be prompted, otherwise you should be signed in and see account info 6 - Test logging out and in 7 - Log-in, perform a search on the opac - you should see hold/checkout buttons 8 - Test the buttons 9 - After holding/checking out items, check your account page 10 - Verify info is correct 11 - Log out of overdrive 12 - Search catalog click overdrive results 13 - Test "Login to Overdrive" link on OD results 14 - Verify page is reloaded, buttons show and work https://bugs.koha-community.org/show_bug.cgi?id=2108
Created attachment 79795 [details] [review] Bug 21082: DO NOT PUSH - Schema updates https://bugs.koha-community.org/show_bug.cgi?id=2108
Created attachment 79894 [details] [review] Bug 21082: DO NOT PUSH - Schema updates https://bugs.koha-community.org/show_bug.cgi?id=2108
Created attachment 79954 [details] [review] Bug 21082: Database updates https://bugs.koha-community.org/show_bug.cgi?id=2108 Signed-off-by: Sandy Allgood <sandy.allgood@citruslibraries.org> Signed-off-by: Sandy Allgood <sandy.allgood@citruslibraries.org>
Created attachment 79955 [details] [review] Bug 21082: Add new admin page for overdrive The 'authname' field required for OverDrive can differ per branch. This patch adds Koha Objects for dealing with OD info and submitting authnames per branch. The description is left open so future branch info can be added. To test: 1 - prove -v t/db_dependent/Koha/Library/OverDriveInfos.t 2 - visit cgi-bin/koha/admin/overdrive.pl 3 - Add some authnames for various branches 4 - Verify data saves correctly https://bugs.koha-community.org/show_bug.cgi?id=2108 Signed-off-by: Sandy Allgood <sandy.allgood@citruslibraries.org> Signed-off-by: Sandy Allgood <sandy.allgood@citruslibraries.org>
Created attachment 79956 [details] [review] Bug 21082: Update OverDrive authentication method Testing will require an OverDrive account, you should be able to obtain a developer account here: https://developer.overdrive.com/ You will need to register a SIP connection for patron authentication To test authentication: 1 - Set authname default in OD prefs 2 - Sign in as a patron whose branch matches authname 3 - Verify the patron can sign into OverDrive 4 - Set the patrons branch authname to be incorrect 5 - Verify branch specific authname is used and patron cannot sign in 6 - Set the default authname to be incorrect and patron's branch authname to be correct 7 - Verofy patron can sign in To test circulation: 1 - Fill out all OD prefs and enable circulation 2 - Sign in to opac 3 - Verify you have an OverDrive tab 4 - Click 'Login to Overdrive' 5 - If password required you shoudl be prompted, otherwise you should be signed in and see account info 6 - Test logging out and in 7 - Log-in, perform a search on the opac - you should see hold/checkout buttons 8 - Test the buttons 9 - After holding/checking out items, check your account page 10 - Verify info is correct 11 - Log out of overdrive 12 - Search catalog click overdrive results 13 - Test "Login to Overdrive" link on OD results 14 - Verify page is reloaded, buttons show and work https://bugs.koha-community.org/show_bug.cgi?id=2108 Signed-off-by: Sandy Allgood <sandy.allgood@citruslibraries.org> Signed-off-by: Sandy Allgood <sandy.allgood@citruslibraries.org>
Created attachment 79957 [details] [review] Bug 21082: DO NOT PUSH - Schema updates https://bugs.koha-community.org/show_bug.cgi?id=2108 Signed-off-by: Sandy Allgood <sandy.allgood@citruslibraries.org> Signed-off-by: Sandy Allgood <sandy.allgood@citruslibraries.org>
Created attachment 79985 [details] [review] Bug 21082: Database updates Signed-off-by: Sandy Allgood <sandy.allgood@citruslibraries.org> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Created attachment 79986 [details] [review] Bug 21082: Add new admin page for overdrive The 'authname' field required for OverDrive can differ per branch. This patch adds Koha Objects for dealing with OD info and submitting authnames per branch. The description is left open so future branch info can be added. To test: 1 - prove -v t/db_dependent/Koha/Library/OverDriveInfos.t 2 - visit cgi-bin/koha/admin/overdrive.pl 3 - Add some authnames for various branches 4 - Verify data saves correctly Signed-off-by: Sandy Allgood <sandy.allgood@citruslibraries.org> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Created attachment 79987 [details] [review] Bug 21082: Update OverDrive authentication method Testing will require an OverDrive account, you should be able to obtain a developer account here: https://developer.overdrive.com/ You will need to register a SIP connection for patron authentication To test authentication: 1 - Set authname default in OD prefs 2 - Sign in as a patron whose branch matches authname 3 - Verify the patron can sign into OverDrive 4 - Set the patrons branch authname to be incorrect 5 - Verify branch specific authname is used and patron cannot sign in 6 - Set the default authname to be incorrect and patron's branch authname to be correct 7 - Verofy patron can sign in To test circulation: 1 - Fill out all OD prefs and enable circulation 2 - Sign in to opac 3 - Verify you have an OverDrive tab 4 - Click 'Login to Overdrive' 5 - If password required you shoudl be prompted, otherwise you should be signed in and see account info 6 - Test logging out and in 7 - Log-in, perform a search on the opac - you should see hold/checkout buttons 8 - Test the buttons 9 - After holding/checking out items, check your account page 10 - Verify info is correct 11 - Log out of overdrive 12 - Search catalog click overdrive results 13 - Test "Login to Overdrive" link on OD results 14 - Verify page is reloaded, buttons show and work Signed-off-by: Sandy Allgood <sandy.allgood@citruslibraries.org> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Awesome work all! Pushed to master for 18.11
Pushed to 18.05.x for 18.05.06
I pass for 17.11.x