The overdrive API wants cardnumbers, not usernames
Created attachment 83403 [details] [review] Bug 22030: Send cardnumber to overdrive instead of username To test: 1 - Have an OverDrive account setup with SIP authentication Note: You can apply for a testing account at developer.overdrive.com and setup an environment 2 - Fill in all your OverDrive system preferences 3 - Test with a patron whose username is theri cardnumber 4 - Confirm their overdrive account tab on opac loads 5 - Change the username to be another value like "borked_wont_work" 6 - Note the overdrive account tab won't load 7 - Apply patch 8 - Note the OD account loads successfully
Created attachment 83434 [details] [review] DO NOT PUSH - example of building filters for uri parameters
Created attachment 83692 [details] [review] Bug 22030: Use preference to determine username sent to overdrive Overdrive configuration generally defaults to cardnumber, however, they have confirmed that some libraries use usernames. We need to allow for both scenarios. To test: 1 - Have an OverDrive account setup with SIP authentication Note: You can apply for a testing account at developer.overdrive.com and setup an environment 2 - Fill in all your OverDrive system preferences 3 - Test with a patron whose username is their cardnumber 4 - Confirm their overdrive account tab on opac loads 5 - Change the username to be another value like "borked_wont_work" 6 - Note the overdrive account tab won't load 7 - Apply patch, update database, change the system preference 8 - Note the OD account loads successfully
Created attachment 83693 [details] [review] Bug 22030: Use preference to determine username sent to overdrive Overdrive configuration generally defaults to cardnumber, however, they have confirmed that some libraries use usernames. We need to allow for both scenarios. To test: 1 - Have an OverDrive account setup with SIP authentication Note: You can apply for a testing account at developer.overdrive.com and setup an environment 2 - Fill in all your OverDrive system preferences 3 - Test with a patron whose username is their cardnumber 4 - Confirm their overdrive account tab on opac loads 5 - Change the username to be another value like "borked_wont_work" 6 - Note the overdrive account tab won't load 7 - Apply patch, update database, not new system preference OverDriveUsername (default to 'cardnumber) 8 - Note the OD account loads successfully 9 - Change the system preference to 'user name' - the account load fails
Created attachment 83702 [details] [review] Bug 22030: Use preference to determine username sent to overdrive Overdrive configuration generally defaults to cardnumber, however, they have confirmed that some libraries use usernames. We need to allow for both scenarios. To test: 1 - Have an OverDrive account setup with SIP authentication Note: You can apply for a testing account at developer.overdrive.com and setup an environment 2 - Fill in all your OverDrive system preferences 3 - Test with a patron whose username is their cardnumber 4 - Confirm their overdrive account tab on opac loads 5 - Change the username to be another value like "borked_wont_work" 6 - Note the overdrive account tab won't load 7 - Apply patch, update database, not new system preference OverDriveUsername (default to 'cardnumber) 8 - Note the OD account loads successfully 9 - Change the system preference to 'user name' - the account load fails Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Trivia fix, no regressions.. going straight for QA here.
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.02
Pushed to 18.05.x for 18.05.08
Depends on Bug 21082 not in 17.11.x