When the housebound module is activated, trying to save a patron record after editing it will result in an internal server errror: No property housebound_deliverer for Koha::Patron To test: - Activate housebound, system preference: HouseboundModule - Edit a patron using the edit button in the toolbar - Save the patron - Verify you get an Internal server error.
On creating the error is: Patron creation failed! - DBIx::Class::Row::store_column(): No such column 'housebound_chooser' on Koha::Schema::Result::Borrower at /home/vagrant/kohaclone/Koha/Object.pm line 75
Caused by bug 20287.
Created attachment 77094 [details] [review] Bug 21085: Fix add/edit of patrons when HouseboundModule is set This script takes all the parameters then set it to create/edit the patron. We must list housebound_chooser and housebound_deliverer as not part of patron's attributes Test plan: - Enable HouseboundModule - Create a patron => When you save, if the patch is not applied, you will get: No property housebound_deliverer for Koha::Patron - Edit a patron => When you save, if the patch is not applied, you will get: Patron creation failed! - DBIx::Class::Row::store_column(): No such column 'housebound_chooser' on Koha::Schema::Result::Borrower at /home/vagrant/kohaclone/Koha/Object.pm line 75
Created attachment 77097 [details] [review] Bug 21085: Fix add/edit of patrons when HouseboundModule is set This script takes all the parameters then set it to create/edit the patron. We must list housebound_chooser and housebound_deliverer as not part of patron's attributes Test plan: - Enable HouseboundModule - Create a patron => When you save, if the patch is not applied, you will get: No property housebound_deliverer for Koha::Patron - Edit a patron => When you save, if the patch is not applied, you will get: Patron creation failed! - DBIx::Class::Row::store_column(): No such column 'housebound_chooser' on Koha::Schema::Result::Borrower at /home/vagrant/kohaclone/Koha/Object.pm line 75 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 77102 [details] [review] Bug 21085: Fix add/edit of patrons when HouseboundModule is set This script takes all the parameters then set it to create/edit the patron. We must list housebound_chooser and housebound_deliverer as not part of patron's attributes Test plan: - Enable HouseboundModule - Create a patron => When you save, if the patch is not applied, you will get: No property housebound_deliverer for Koha::Patron - Edit a patron => When you save, if the patch is not applied, you will get: Patron creation failed! - DBIx::Class::Row::store_column(): No such column 'housebound_chooser' on Koha::Schema::Result::Borrower at /home/vagrant/kohaclone/Koha/Object.pm line 75 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Awesome work all! Pushed to master for 18.11
Depends on (and is caused by) but 20287 which is not in 18.05.x series.