Bug 21136 - Error "No property select_city for Koha::Patron" when saving patron record
Summary: Error "No property select_city for Koha::Patron" when saving patron record
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low critical (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 20287
Blocks:
  Show dependency treegraph
 
Reported: 2018-08-01 12:52 UTC by Owen Leonard
Modified: 2019-10-14 19:56 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 21136: Fix add/edit patron when cities are defined (1.23 KB, patch)
2018-08-01 13:00 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 21136: Fix add/edit patron when cities are defined (1.27 KB, patch)
2018-08-01 13:34 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 21136: Fix add/edit patron when cities are defined (1.33 KB, patch)
2018-08-01 15:05 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2018-08-01 12:52:38 UTC
When I edit an existing patron in master, I get an error upon saving: 

No property select_city for Koha::Patron at /usr/share/perl5/Exception/Class/Base.pm line 73

To reproduce this error you must have cities defined in Administration -> Cities & towns.
Comment 1 Jonathan Druart 2018-08-01 13:00:58 UTC
Created attachment 77362 [details] [review]
Bug 21136: Fix add/edit patron when cities are defined

Same as bug 21085.

When cities are defined, there is a select with name="select_city" added
to the DOM and its value will be passed to memberentry.pl
We must remove it from the attribute list before creating the
Koha::Patron object

No property select_city for Koha::Patron at
/usr/share/perl5/Exception/Class/Base.pm line 73

Test plan:
Define cities
Add or edit a patron, save
Comment 2 Owen Leonard 2018-08-01 13:34:30 UTC
Created attachment 77366 [details] [review]
Bug 21136: Fix add/edit patron when cities are defined

Same as bug 21085.

When cities are defined, there is a select with name="select_city" added
to the DOM and its value will be passed to memberentry.pl
We must remove it from the attribute list before creating the
Koha::Patron object

No property select_city for Koha::Patron at
/usr/share/perl5/Exception/Class/Base.pm line 73

Test plan:
Define cities
Add or edit a patron, save

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Katrin Fischer 2018-08-01 15:05:43 UTC
Created attachment 77374 [details] [review]
Bug 21136: Fix add/edit patron when cities are defined

Same as bug 21085.

When cities are defined, there is a select with name="select_city" added
to the DOM and its value will be passed to memberentry.pl
We must remove it from the attribute list before creating the
Koha::Patron object

No property select_city for Koha::Patron at
/usr/share/perl5/Exception/Class/Base.pm line 73

Test plan:
Define cities
Add or edit a patron, save

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2018-08-02 13:12:29 UTC
Pushed to master. Thanks all!
Comment 5 Martin Renvoize 2018-08-03 14:11:48 UTC
Depends on (and is caused by) but 20287 which is not in 18.05.x series.