Bug 21195 - Makefile.t is failing due to new files for SCSS
Summary: Makefile.t is failing due to new files for SCSS
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low major (vote)
Assignee: Nick Clemens
QA Contact: Testopia
URL:
Keywords:
Depends on: 19474
Blocks:
  Show dependency treegraph
 
Reported: 2018-08-09 16:07 UTC by Nick Clemens
Modified: 2019-10-14 19:57 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 21195: Ignore files used for SCSS build process (848 bytes, patch)
2018-08-09 16:09 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 21195: Ignore files used for SCSS build process (910 bytes, patch)
2018-08-09 17:17 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 21195: Ignore files used for SCSS build process (1.13 KB, patch)
2018-08-09 20:53 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens 2018-08-09 16:07:35 UTC
not ok 1 - All directories should be mapped: .sass-lint.yml,.scss-lint.yml,gulpfile.js,package.json,yarn.lock
Comment 1 Nick Clemens 2018-08-09 16:09:44 UTC
Created attachment 77631 [details] [review]
Bug 21195: Ignore files used for SCSS build process

I do not know if this is the correct way, it does work. Can we place these into a directory so that they can be ignored as one? that might be cleaner

To test:
prove t/Makefile.t
Comment 2 Tomás Cohen Arazi 2018-08-09 17:17:47 UTC
Created attachment 77633 [details] [review]
Bug 21195: Ignore files used for SCSS build process

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 3 Jonathan Druart 2018-08-09 20:53:40 UTC
Created attachment 77635 [details] [review]
Bug 21195: Ignore files used for SCSS build process

koha_1       | #   Failed test 'All directories should be mapped:
.sass-lint.yml,.scss-lint.yml,gulpfile.js,package.json,yarn.lock'
koha_1       | #   at t/Makefile.t line 47.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Nick Clemens 2018-08-10 12:58:11 UTC
Awesome work all!

Pushed to master for 18.11
Comment 5 Martin Renvoize 2018-08-13 08:36:37 UTC
Bug 19474 not in 18.05.0x, no need to backport.