I propose a new workflow for handling CSS in the staff client based on the work in Bug 15522 which adds a client-side asset processing workflow. My patch will be designed to work independently from that bug but use the same framework so that the two can be merged easily. - Uses yarn (https://yarnpkg.com) to manage installation of npm dependencies - Uses gulp (https://gulpjs.com) to process client-side assets. In this case, conversion of SCSS to CSS, auto-prefixing of CSS, minification of CSS. This patch will add a configuration file for sass-lint (https://github.com/sasstools/sass-lint) to help standardize how we write SCSS. The version I'm working with is pretty much the default, and I hope it won't be controversial. I'm using this configuration file in conjunction with my editor's linting plugin. We might later plug sass-lint into the gulp build process. The patch will include a conversion of staff-global.css to SCSS and remove staff-global.css from git.
Created attachment 68211 [details] [review] Bug 19474: Convert staff client CSS to SCSS This patch converts staff-global.css to Sass, using SCSS syntax. This changes the build process for Koha to include installation and execution of yarn to install npm dependencies and run SCSS -> CSS conversion. To test, apply the patch and run the following: $ sudo apt-get install nodejs npm [not necessary in kohadevbox] $ sudo npm install -g yarn $ yarn install $ yarn build Clear your browser cache if necessary and confirm that CSS styling throughout the staff client looks correct. The "yarn build" command triggers a gulp process which compiles SCSS to CSS, adds automatic vendor-prefixing, and minifies the resulting CSS file. There is also a "yarn css" command available which might be used by developers who are making changes to SCSS. This command does two things differently: 1. Adds .css.map files which aid CSS debugging using in-browser inspector tools. 2. Compiles staff-global.css without minification. It can be useful to see unminified CSS during development, especially to see how SCSS compiles. This patch adds a configuration file for sass-lint, .sass-lint.yml. Currently this configuration is not used during the build process but can be used in a code editor which supports linting.
Note to testers: The qa tools gave me a fail for .sass-lint.yml ("YAML Error: Invalid element in map"), but using web-based YAML linter returned no errors. Not sure what's going on there.
(In reply to Owen Leonard from comment #2) > Note to testers: The qa tools gave me a fail for .sass-lint.yml ("YAML > Error: Invalid element in map"), but using web-based YAML linter returned no > errors. Not sure what's going on there. The script executes YAML::LoadFile($filepath) and displays the lines containing "YAML error".
Another note to testers: If you are using the included sass-lint configuration to lint the new scss file, it's not perfect. I've tried to make a good first pass as properly nesting staff-global.css, but there are many cases where I'm not sure using strict SCSS syntax results in more efficient output than the non-nested version.
Patch fails to apply in devbox. The following is from my terminal. vagrant@kohadevbox:kohaclone((dafb678...))$ git bz apply -s 19474 Bug 19474 - Convert staff client CSS to SCSS 68211 - Bug 19474: Convert staff client CSS to SCSS Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 19474: Convert staff client CSS to SCSS Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/css/staff-global.css Falling back to patching base and 3-way merge... CONFLICT (modify/delete): koha-tmpl/intranet-tmpl/prog/css/staff-global.css deleted in Bug 19474: Convert staff client CSS to SCSS and modified in HEAD. Version HEAD of koha-tmpl/intranet-tmpl/prog/css/staff-global.css left in tree. Failed to merge in the changes. Patch failed at 0001 Bug 19474: Convert staff client CSS to SCSS The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-19474-Convert-staff-client-CSS-to-SCSS-bSMH6p.patch
This patch deletes staff-global.css, assuming that staff-global.css should be generated from the SCSS file. Since commits have been made to stafff-global.css in the meantime, it creates a conflict. I will submit follow-ups to catch up with master, but I think this could be properly tested by resolving the conflict manually.
Created attachment 69197 [details] [review] Bug 19474 [follow-up] Convert staff client CSS to SCSS This patch brings staff-global.scss up to date with changes which have been recently committed to staff-global.css, specifically ILL module styles.
Created attachment 70315 [details] [review] Bug 19474 (Follow-up) Convert staff client CSS to SCSS This patch brings staff-global.scss up to date with changes which have been recently committed to staff-global.css, specifically staff client responsiveness improvements (Bug 19851).
Created attachment 70915 [details] [review] [SIGNED-OFF] Bug 19474: Convert staff client CSS to SCSS This patch converts staff-global.css to Sass, using SCSS syntax. This changes the build process for Koha to include installation and execution of yarn to install npm dependencies and run SCSS -> CSS conversion. To test, apply the patch and run the following: $ sudo apt-get install nodejs npm [not necessary in kohadevbox] $ sudo npm install -g yarn $ yarn install $ yarn build Clear your browser cache if necessary and confirm that CSS styling throughout the staff client looks correct. The "yarn build" command triggers a gulp process which compiles SCSS to CSS, adds automatic vendor-prefixing, and minifies the resulting CSS file. There is also a "yarn css" command available which might be used by developers who are making changes to SCSS. This command does two things differently: 1. Adds .css.map files which aid CSS debugging using in-browser inspector tools. 2. Compiles staff-global.css without minification. It can be useful to see unminified CSS during development, especially to see how SCSS compiles. This patch adds a configuration file for sass-lint, .sass-lint.yml. Currently this configuration is not used during the build process but can be used in a code editor which supports linting. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Created attachment 70916 [details] [review] [SIGNED-OFF] Bug 19474 [follow-up] Convert staff client CSS to SCSS This patch brings staff-global.scss up to date with changes which have been recently committed to staff-global.css, specifically ILL module styles. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Created attachment 70917 [details] [review] [SIGNED-OFF] Bug 19474 (Follow-up) Convert staff client CSS to SCSS This patch brings staff-global.scss up to date with changes which have been recently committed to staff-global.css, specifically staff client responsiveness improvements (Bug 19851). Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Created attachment 70944 [details] [review] Bug 19474: Convert staff client CSS to SCSS This patch converts staff-global.css to Sass, using SCSS syntax. This changes the build process for Koha to include installation and execution of yarn to install npm dependencies and run SCSS -> CSS conversion. To test, apply the patch and run the following: $ sudo apt-get install nodejs npm [not necessary in kohadevbox] $ sudo npm install -g yarn $ yarn install $ yarn build Clear your browser cache if necessary and confirm that CSS styling throughout the staff client looks correct. The "yarn build" command triggers a gulp process which compiles SCSS to CSS, adds automatic vendor-prefixing, and minifies the resulting CSS file. There is also a "yarn css" command available which might be used by developers who are making changes to SCSS. This command does two things differently: 1. Adds .css.map files which aid CSS debugging using in-browser inspector tools. 2. Compiles staff-global.css without minification. It can be useful to see unminified CSS during development, especially to see how SCSS compiles. This patch adds a configuration file for sass-lint, .sass-lint.yml. Currently this configuration is not used during the build process but can be used in a code editor which supports linting. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 70945 [details] [review] Bug 19474: (follow-up) Convert staff client CSS to SCSS This patch brings staff-global.scss up to date with changes which have been recently committed to staff-global.css, specifically ILL module styles. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 70946 [details] [review] Bug 19474: (follow-up) Convert staff client CSS to SCSS This patch brings staff-global.scss up to date with changes which have been recently committed to staff-global.css, specifically staff client responsiveness improvements (Bug 19851). Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 70947 [details] [review] Bug 19474: (QA follow-up) Fix sass lint yaml configuration Test plan: QA tools should report green on the .sass-lint.yml file now Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Noticing this is PQA :) Should we prepare a wiki page with instructions to go with it?
Created attachment 71055 [details] [review] Bug 19474: Convert staff client CSS to SCSS This patch converts staff-global.css to Sass, using SCSS syntax. This changes the build process for Koha to include installation and execution of yarn to install npm dependencies and run SCSS -> CSS conversion. To test, apply the patch and run the following: $ sudo apt-get install nodejs npm [not necessary in kohadevbox] $ sudo npm install -g yarn $ yarn install $ yarn build Clear your browser cache if necessary and confirm that CSS styling throughout the staff client looks correct. The "yarn build" command triggers a gulp process which compiles SCSS to CSS, adds automatic vendor-prefixing, and minifies the resulting CSS file. There is also a "yarn css" command available which might be used by developers who are making changes to SCSS. This command does two things differently: 1. Adds .css.map files which aid CSS debugging using in-browser inspector tools. 2. Compiles staff-global.css without minification. It can be useful to see unminified CSS during development, especially to see how SCSS compiles. This patch adds a configuration file for sass-lint, .sass-lint.yml. Currently this configuration is not used during the build process but can be used in a code editor which supports linting. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 71056 [details] [review] Bug 19474: Convert staff client CSS to SCSS This patch converts staff-global.css to Sass, using SCSS syntax. This changes the build process for Koha to include installation and execution of yarn to install npm dependencies and run SCSS -> CSS conversion. To test, apply the patch and run the following: $ sudo apt-get install nodejs npm [not necessary in kohadevbox] $ sudo npm install -g yarn $ yarn install $ yarn build Clear your browser cache if necessary and confirm that CSS styling throughout the staff client looks correct. The "yarn build" command triggers a gulp process which compiles SCSS to CSS, adds automatic vendor-prefixing, and minifies the resulting CSS file. There is also a "yarn css" command available which might be used by developers who are making changes to SCSS. This command does two things differently: 1. Adds .css.map files which aid CSS debugging using in-browser inspector tools. 2. Compiles staff-global.css without minification. It can be useful to see unminified CSS during development, especially to see how SCSS compiles. This patch adds a configuration file for sass-lint, .sass-lint.yml. Currently this configuration is not used during the build process but can be used in a code editor which supports linting. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 71057 [details] [review] Bug 19474: (follow-up) Convert staff client CSS to SCSS This patch brings staff-global.scss up to date with changes which have been recently committed to staff-global.css, specifically ILL module styles. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 71058 [details] [review] Bug 19474: (follow-up) Convert staff client CSS to SCSS This patch brings staff-global.scss up to date with changes which have been recently committed to staff-global.css, specifically staff client responsiveness improvements (Bug 19851). Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 71059 [details] [review] Bug 19474: (QA follow-up) Fix sass lint yaml configuration Test plan: QA tools should report green on the .sass-lint.yml file now Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(In reply to Katrin Fischer from comment #16) > Noticing this is PQA :) Should we prepare a wiki page with instructions to > go with it? Yes, that seems like an excellent idea.
https://wiki.koha-community.org/wiki/Working_with_staff_client_SCSS
.gitignore is not tracked yet, so I get: error: The following untracked working tree files would be overwritten by merge: .gitignore Please move or remove them before you merge.
(In reply to Jonathan Druart from comment #24) > .gitignore is not tracked yet, so I get: > > error: The following untracked working tree files would be overwritten by > merge: > .gitignore > Please move or remove them before you merge. Sounds like you added your own .gitignore file. Just remove it and everything should apply just fine. You could add a followup to merge the two versions if what you have in yours would be generally useful.
I thought it was not a good idea to commit the .gitignore file, but actually it does. .git/info/exclude must be used for local modifications.
Did we discuss and vote this change in a dev meeting or the mailing list (I do not find track of that)? I do not understand why the .css is no longer part of the codebase. Do not you think RM should generate it?
I think most of the discussion so far centered around a different bug, Bug 15522. We discussed the idea of implementing this kind of workflow on the mailing list here: http://lists.koha-community.org/pipermail/koha-devel/2017-August/043910.html ...and during a dev meeting: http://meetings.koha-community.org/2017/development_irc_meeting_9_august_2017.2017-08-09-22.00.log.html
(In reply to Jonathan Druart from comment #27) > I do not understand why the .css is no longer part of the codebase. Do not > you think RM should generate it? ?
Created attachment 71609 [details] [review] Bug 19474: Convert staff client CSS to SCSS This patch converts staff-global.css to Sass, using SCSS syntax. This changes the build process for Koha to include installation and execution of yarn to install npm dependencies and run SCSS -> CSS conversion. To test, apply the patch and run the following: $ sudo apt-get install nodejs npm [not necessary in kohadevbox] $ sudo npm install -g yarn $ yarn install $ yarn build Clear your browser cache if necessary and confirm that CSS styling throughout the staff client looks correct. The "yarn build" command triggers a gulp process which compiles SCSS to CSS, adds automatic vendor-prefixing, and minifies the resulting CSS file. There is also a "yarn css" command available which might be used by developers who are making changes to SCSS. This command does two things differently: 1. Adds .css.map files which aid CSS debugging using in-browser inspector tools. 2. Compiles staff-global.css without minification. It can be useful to see unminified CSS during development, especially to see how SCSS compiles. This patch adds a configuration file for sass-lint, .sass-lint.yml. Currently this configuration is not used during the build process but can be used in a code editor which supports linting. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 71610 [details] [review] Bug 19474: (follow-up) Convert staff client CSS to SCSS This patch brings staff-global.scss up to date with changes which have been recently committed to staff-global.css, specifically ILL module styles. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 71611 [details] [review] Bug 19474: (follow-up) Convert staff client CSS to SCSS This patch brings staff-global.scss up to date with changes which have been recently committed to staff-global.css, specifically staff client responsiveness improvements (Bug 19851). Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 71612 [details] [review] Bug 19474: (QA follow-up) Fix sass lint yaml configuration Test plan: QA tools should report green on the .sass-lint.yml file now Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
I've modified the first patch in two ways: 1. staff-global.css now remains in git 2. .gitignore no longer ignores staff-global.css QA team: Should I seek another signoff?
Created attachment 71616 [details] [review] Bug 19474: (follow-up) Catch up with changes to staff-global.css This patch brings staff-global.scss up to date with changes which have been recently committed to staff-global.css: - Bug 15707: (QA follow-up) Fix UI issues - Bug 20135: Prevent staff client language choose pop-up from appearing off-screen
Created attachment 72444 [details] [review] Bug 19474 (follow-up) Catch up with changes to CSS from Bug 19981 This patch brings staff-global.scss up to date with changes made in Bug 19981.
Created attachment 72643 [details] [review] Bug 19474: (follow-up) Catch up with changes to CSS from Bug 19981 This patch brings staff-global.scss up to date with changes made in Bug 19981.
Created attachment 72677 [details] [review] Bug 19474: (follow-up) Catch up with changes to CSS from Bug 19981 This patch brings staff-global.scss up to date with changes made in Bug 19981.
Created attachment 72684 [details] [review] Bug 19474: (follow-up) Catch up with changes to staff-global.css This patch brings staff-global.scss up to date with changes which have been recently committed to staff-global.css: - Bug 15707: (QA follow-up) Fix UI issues - Bug 20135: Prevent staff client language choose pop-up from appearing off-screen
Created attachment 72685 [details] [review] Bug 19474: (follow-up) Catch up with changes to CSS from Bug 19981 This patch brings staff-global.scss up to date with changes made in Bug 19981. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Created attachment 72686 [details] [review] Bug 19474: (follow-up) Catch up with changes to staff-global.css This patch brings staff-global.scss up to date with changes which have been recently committed to staff-global.css: - Bug 15707: (QA follow-up) Fix UI issues - Bug 20135: Prevent staff client language choose pop-up from appearing off-screen Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Created attachment 72776 [details] [review] Bug 19474: Convert staff client CSS to SCSS This patch converts staff-global.css to Sass, using SCSS syntax. This changes the build process for Koha to include installation and execution of yarn to install npm dependencies and run SCSS -> CSS conversion. To test, apply the patch and run the following: $ sudo apt-get install nodejs npm [not necessary in kohadevbox] $ sudo npm install -g yarn $ yarn install $ yarn build Clear your browser cache if necessary and confirm that CSS styling throughout the staff client looks correct. The "yarn build" command triggers a gulp process which compiles SCSS to CSS, adds automatic vendor-prefixing, and minifies the resulting CSS file. There is also a "yarn css" command available which might be used by developers who are making changes to SCSS. This command does two things differently: 1. Adds .css.map files which aid CSS debugging using in-browser inspector tools. 2. Compiles staff-global.css without minification. It can be useful to see unminified CSS during development, especially to see how SCSS compiles. This patch adds a configuration file for sass-lint, .sass-lint.yml. Currently this configuration is not used during the build process but can be used in a code editor which supports linting. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 72777 [details] [review] Bug 19474: (QA follow-up) Fix sass lint yaml configuration Test plan: QA tools should report green on the .sass-lint.yml file now Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 72778 [details] [review] Bug 19474 (follow-up) Compiled CSS This patch includes the compiled CSS.
Created attachment 72788 [details] [review] Bug 19474: Convert staff client CSS to SCSS This patch converts staff-global.css to Sass, using SCSS syntax. This changes the build process for Koha to include installation and execution of yarn to install npm dependencies and run SCSS -> CSS conversion. To test, apply the patch and run the following: $ sudo apt-get install nodejs npm [not necessary in kohadevbox] $ sudo npm install -g yarn $ yarn install $ yarn build Clear your browser cache if necessary and confirm that CSS styling throughout the staff client looks correct. The "yarn build" command triggers a gulp process which compiles SCSS to CSS, adds automatic vendor-prefixing, and minifies the resulting CSS file. There is also a "yarn css" command available which might be used by developers who are making changes to SCSS. This command does two things differently: 1. Adds .css.map files which aid CSS debugging using in-browser inspector tools. 2. Compiles staff-global.css without minification. It can be useful to see unminified CSS during development, especially to see how SCSS compiles. This patch adds a configuration file for sass-lint, .sass-lint.yml. Currently this configuration is not used during the build process but can be used in a code editor which supports linting. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 72789 [details] [review] Bug 19474: (QA follow-up) Fix sass lint yaml configuration Test plan: QA tools should report green on the .sass-lint.yml file now Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 72790 [details] [review] Bug 19474 (follow-up) Compiled CSS This patch includes the compiled CSS. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 72791 [details] [review] Bug 19474: (follow-up) Compiled CSS This patch includes the compiled CSS. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 73470 [details] [review] Bug 19474: Convert staff client CSS to SCSS This patch converts staff-global.css to Sass, using SCSS syntax. This changes the build process for Koha to include installation and execution of yarn to install npm dependencies and run SCSS -> CSS conversion. To test, apply the patch and run the following: $ sudo apt-get install nodejs npm [not necessary in kohadevbox] $ sudo npm install -g yarn $ yarn install $ yarn build Clear your browser cache if necessary and confirm that CSS styling throughout the staff client looks correct. The "yarn build" command triggers a gulp process which compiles SCSS to CSS, adds automatic vendor-prefixing, and minifies the resulting CSS file. There is also a "yarn css" command available which might be used by developers who are making changes to SCSS. This command does two things differently: 1. Adds .css.map files which aid CSS debugging using in-browser inspector tools. 2. Compiles staff-global.css without minification. It can be useful to see unminified CSS during development, especially to see how SCSS compiles. This patch adds a configuration file for sass-lint, .sass-lint.yml. Currently this configuration is not used during the build process but can be used in a code editor which supports linting. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 73471 [details] [review] Bug 19474: (QA follow-up) Fix sass lint yaml configuration Test plan: QA tools should report green on the .sass-lint.yml file now Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 73472 [details] [review] Bug 19474 (follow-up) Compiled CSS This patch includes the compiled CSS.
Could we imagine to have a staff-global.css and staff-global.min.css It would depend on the dev_install config flag, devs will use .css whereas production installations will use .min.css The .min.css would be generated only on releasing (and will avoid to pollute the git log).
Owen, could you add, on the wiki page, a list of the files bug 19474 and bug 20427 are going to add to our codebase? And tell what is the purpose in front each one.
We should also update https://wiki.koha-community.org/wiki/Working_with_Bootstrap_OPAC_LESS_files
Created attachment 74724 [details] [review] Bug 19474: (follow-up) Bring scss up to date with latest CSS changes This patch catches the scss up to the latest changes in master: Bug 19946, Bug 20045, Bug 20343, Bug 18327, Bug 20322, and Bug 18799
Created attachment 74725 [details] [review] Bug 19474: (follow-up) Compiled CSS This patch includes the compiled CSS.
Created attachment 74757 [details] [review] Bug 19474: (follow-up) Bring scss up to date with latest CSS changes This patch catches the scss up to the latest changes in master: Bug 19946, Bug 20045, Bug 20343, Bug 18327, Bug 20322, Bug 18799, and Bug 20622.
Created attachment 74758 [details] [review] Bug 19474: (follow-up) Compiled CSS This patch includes the compiled CSS.
I am stuck here and I need help: https://framabin.org/?92fc14016eb1b26b#Ign1IDycTejFZj7suueyIXO/wEy2wFB13hxbqq5Yle0= I changed .scss file and `yarn build` or `yarn css` does not update .css files.
This will not be part of 18.05 unfortunately.
Created attachment 76657 [details] [review] Bug 19474: (follow-up) Bring scss up to date with latest CSS changes This patch catches the scss up to the latest changes in master: Bug 19946 Bug 20045 Bug 20343 Bug 18327 Bug 20322 Bug 18799 Bug 20622 Bug 20329 Bug 20744 Bug 20931 Bug 20793 Bug 20651
Created attachment 77189 [details] [review] Bug 19474: (follow-up) Bring scss up to date with latest CSS changes This patch catches the scss up to the latest changes in master: Bug 19946 Bug 20045 Bug 20343 Bug 18327 Bug 20322 Bug 18799 Bug 20622 Bug 20329 Bug 20744 Bug 20931 Bug 20793 Bug 20651
(In reply to Jonathan Druart from comment #59) > I am stuck here and I need help: > https://framabin.org/?92fc14016eb1b26b#Ign1IDycTejFZj7suueyIXO/ > wEy2wFB13hxbqq5Yle0= > > I changed .scss file and `yarn build` or `yarn css` does not update .css > files. Retested right now and I do see the expected changes made to koha-tmpl/intranet-tmpl/prog/css/staff-global.css
(In reply to Jonathan Druart from comment #63) > (In reply to Jonathan Druart from comment #59) > > I am stuck here and I need help: > > https://framabin.org/?92fc14016eb1b26b#Ign1IDycTejFZj7suueyIXO/ > > wEy2wFB13hxbqq5Yle0= > > > > I changed .scss file and `yarn build` or `yarn css` does not update .css > > files. > > Retested right now and I do see the expected changes made to > koha-tmpl/intranet-tmpl/prog/css/staff-global.css I would like to retest on top of bug 20427 as well (maybe it came from there?), but it does no longer apply.
(In reply to Jonathan Druart from comment #64) > (In reply to Jonathan Druart from comment #63) > > (In reply to Jonathan Druart from comment #59) > > > I am stuck here and I need help: > > > https://framabin.org/?92fc14016eb1b26b#Ign1IDycTejFZj7suueyIXO/ > > > wEy2wFB13hxbqq5Yle0= > > > > > > I changed .scss file and `yarn build` or `yarn css` does not update .css > > > files. > > > > Retested right now and I do see the expected changes made to > > koha-tmpl/intranet-tmpl/prog/css/staff-global.css > > I would like to retest on top of bug 20427 as well (maybe it came from > there?), but it does no longer apply. Confirmed! The issue still exists for me with bug 20427 applied
(In reply to Jonathan Druart from comment #65) > (In reply to Jonathan Druart from comment #64) > > (In reply to Jonathan Druart from comment #63) > > > (In reply to Jonathan Druart from comment #59) > > > > I am stuck here and I need help: > > > > https://framabin.org/?92fc14016eb1b26b#Ign1IDycTejFZj7suueyIXO/ > > > > wEy2wFB13hxbqq5Yle0= > > > > > > > > I changed .scss file and `yarn build` or `yarn css` does not update .css > > > > files. > > > > > > Retested right now and I do see the expected changes made to > > > koha-tmpl/intranet-tmpl/prog/css/staff-global.css > > > > I would like to retest on top of bug 20427 as well (maybe it came from > > there?), but it does no longer apply. > > Confirmed! The issue still exists for me with bug 20427 applied Fixed since patch on bug 20427 comment 13.
Created attachment 77621 [details] [review] Bug 19474: (follow-up) Bring scss up to date with latest CSS changes This patch catches the scss up to the latest changes in master: Bug 19946 Bug 20045 Bug 20343 Bug 18327 Bug 20322 Bug 18799 Bug 20622 Bug 20329 Bug 20744 Bug 20931 Bug 20793 Bug 20651 Bug 20668 Bug 16575 Bug 19166 Bug 20770 Bug 21163 Bug 20779
Awesome work all! Pushed to master for 18.11
Enhancement, this will not be backported to 18.05.x series.
I have opened bug 21239 to list the different regressions introduced by this change.
Any chance of a short rationale and summary for the release notes for this one Owen?
*** Bug 11896 has been marked as a duplicate of this bug. ***