Bug 21202 - C4::Items - Remove GetItemsByBiblioitemnumber
Summary: C4::Items - Remove GetItemsByBiblioitemnumber
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Jonathan Druart
QA Contact: Marcel de Rooy
URL:
Keywords:
: 18253 (view as bug list)
Depends on: 21203
Blocks: 18252 21205
  Show dependency treegraph
 
Reported: 2018-08-10 15:07 UTC by Jonathan Druart
Modified: 2020-01-06 20:14 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 21202: Replace C4::Items::GetItemsByBiblioitemnumber calls (4.63 KB, patch)
2018-08-10 16:15 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 21202: Replace C4::Items::GetItemsByBiblioitemnumber calls (4.67 KB, patch)
2018-08-16 10:33 UTC, Josef Moravec
Details | Diff | Splinter Review
Bug 21202: Replace C4::Items::GetItemsByBiblioitemnumber calls (4.63 KB, patch)
2018-08-22 00:56 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 21202: Replace C4::Items::GetItemsByBiblioitemnumber calls (4.76 KB, patch)
2018-08-24 06:56 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2018-08-10 15:07:09 UTC
my $items = GetItemsByBiblioitemnumber($biblioitemnumber);
will become
  my $items = $biblio->items->unblessed;
Comment 1 Jonathan Druart 2018-08-10 16:15:35 UTC
Created attachment 77703 [details] [review]
Bug 21202: Replace C4::Items::GetItemsByBiblioitemnumber calls

http://lists.koha-community.org/pipermail/koha-devel/2018-August/044757.html

Prior to this patch, GetRecords returned timestampX, cardX and borrowerX for
the last 3 patrons who checked out the items.

I have no idea if it is a desired effects but, as this code has been
there for a very long time (2005), I suspect it's not.
The "doc" (/ilsdi.pl?service=Describe&verb=GetRecords) does not say
anything about the checkouts info.

Test plan:
hit /ilsdi.pl?service=GetRecords&id=1
and confirm the info about items are displayed correctly
Comment 2 Josef Moravec 2018-08-16 10:33:32 UTC
Created attachment 77888 [details] [review]
Bug 21202: Replace C4::Items::GetItemsByBiblioitemnumber calls

http://lists.koha-community.org/pipermail/koha-devel/2018-August/044757.html

Prior to this patch, GetRecords returned timestampX, cardX and borrowerX for
the last 3 patrons who checked out the items.

I have no idea if it is a desired effects but, as this code has been
there for a very long time (2005), I suspect it's not.
The "doc" (/ilsdi.pl?service=Describe&verb=GetRecords) does not say
anything about the checkouts info.

Test plan:
hit /ilsdi.pl?service=GetRecords&id=1
and confirm the info about items are displayed correctly

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 3 Jonathan Druart 2018-08-22 00:56:31 UTC
Created attachment 78079 [details] [review]
Bug 21202: Replace C4::Items::GetItemsByBiblioitemnumber calls

http://lists.koha-community.org/pipermail/koha-devel/2018-August/044757.html

Prior to this patch, GetRecords returned timestampX, cardX and borrowerX for
the last 3 patrons who checked out the items.

I have no idea if it is a desired effects but, as this code has been
there for a very long time (2005), I suspect it's not.
The "doc" (/ilsdi.pl?service=Describe&verb=GetRecords) does not say
anything about the checkouts info.

Test plan:
hit /ilsdi.pl?service=GetRecords&id=1
and confirm the info about items are displayed correctly
Comment 4 Marcel de Rooy 2018-08-24 06:42:00 UTC
QA: Looking here
Comment 5 Marcel de Rooy 2018-08-24 06:56:21 UTC
Created attachment 78108 [details] [review]
Bug 21202: Replace C4::Items::GetItemsByBiblioitemnumber calls

http://lists.koha-community.org/pipermail/koha-devel/2018-August/044757.html

Prior to this patch, GetRecords returned timestampX, cardX and borrowerX for
the last 3 patrons who checked out the items.

I have no idea if it is a desired effects but, as this code has been
there for a very long time (2005), I suspect it's not.
The "doc" (/ilsdi.pl?service=Describe&verb=GetRecords) does not say
anything about the checkouts info.

Test plan:
hit /ilsdi.pl?service=GetRecords&id=1
and confirm the info about items are displayed correctly

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 6 Nick Clemens 2018-08-31 13:00:00 UTC
Awesome work all!

Pushed to master for 18.11
Comment 7 Martin Renvoize 2018-09-05 12:53:44 UTC
Refactoring enhancement, deprecation warning added to the affected subroutine to warn users of the pending changes to ILS-DI created by this change.

Deprecation warning will be in 18.05.04
Comment 8 Fridolin Somers 2018-09-24 09:22:12 UTC
Refactoring enhancement not pushed to 17.11.x
Comment 9 Jonathan Druart 2019-03-14 18:00:52 UTC
*** Bug 18253 has been marked as a duplicate of this bug. ***