This is done to ease the move of C4::Items (bug 18252) to Koha::Items my @itemnumbers = GetItemnumbersFromOrder($order->{ordernumber}); will become my @itemnumbers = $order_object->items->get_column('itemnumbers');
Koha::Acquisition::Order->items comes from bug 15184
Created attachment 77698 [details] [review] Bug 21205: Replace C4::Items::GetOrderFromItemnumber calls This is done to ease the move of C4::Items (bug 18252) to Koha::Items my @itemnumbers = GetItemnumbersFromOrder($order->{ordernumber}); will become my @itemnumbers = $order_object->items->get_column('itemnumbers'); Test plan: - Create an order with several items - Receive some items
Created attachment 78042 [details] [review] Bug 21205: Replace C4::Items::GetOrderFromItemnumber calls This is done to ease the move of C4::Items (bug 18252) to Koha::Items my @itemnumbers = GetItemnumbersFromOrder($order->{ordernumber}); will become my @itemnumbers = $order_object->items->get_column('itemnumbers'); Test plan: - Create an order with several items - Receive some items Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 78043 [details] [review] Bug 21205: (follow-up) Fix column name - itemnumbers -> itemnumber Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
perl t/db_dependent/Acquisition/CancelReceipt.t 1..12 The method Koha::Acquisition::Order->items is not covered by tests! perl t/db_dependent/Acquisition/TransferOrder.t 1..13 ok 1 - 1 order in basket1 The method Koha::Acquisition::Order->items is not covered by tests!
Koha::Acquisition::Order->items is added by bug 15184
QA: Looking here
Created attachment 78319 [details] [review] Bug 21205: Replace C4::Items::GetOrderFromItemnumber calls This is done to ease the move of C4::Items (bug 18252) to Koha::Items my @itemnumbers = GetItemnumbersFromOrder($order->{ordernumber}); will become my @itemnumbers = $order_object->items->get_column('itemnumbers'); Test plan: - Create an order with several items - Receive some items Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 78320 [details] [review] Bug 21205: (follow-up) Fix column name - itemnumbers -> itemnumber Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Passed QA but note that 15184 is in FQA now. Please wait, RM. Added a temporary flag in the title.
Awesome work all! Pushed to master for 18.11
Enhancement, will not be backported to 18.05.x series.