OCLC has decided to retire all xISBN services: https://www.oclc.org/developer/news/2018/xid-decommission.en.html The code for related features has to be removed from Koha.
Created attachment 77827 [details] [review] Bug 21226: DB Changes Remove prefs OCLCAffiliateID, XISBN and XISBNDailyLimit
Created attachment 77828 [details] [review] Bug 21226: Remove xISBN services OCLC has decided to retire all xISBN services: https://www.oclc.org/developer/news/2018/xid-decommission.en.html The code for related features has to be removed from Koha. Test plan: You need to be familiar with the different sysprefs (I am not): - FRBRizeEditions - SyndeticsEnabled - SyndeticsEditions - ThingISBN Make sure there are no regressions introduced by this patchset. QA Note: C4/XISBN.pm should be renammed
Created attachment 77829 [details] [review] Bug 21226: Remove table services_throttle This table was only used by XISBN, this patch remove the table and the related code (cronjobs)
Created attachment 77830 [details] [review] Bug 21226: DB Changes Remove prefs OCLCAffiliateID, XISBN and XISBNDailyLimit
Created attachment 77831 [details] [review] Bug 21226: Remove xISBN services OCLC has decided to retire all xISBN services: https://www.oclc.org/developer/news/2018/xid-decommission.en.html The code for related features has to be removed from Koha. Test plan: You need to be familiar with the different sysprefs (I am not): - FRBRizeEditions - SyndeticsEnabled - SyndeticsEditions - ThingISBN Make sure there are no regressions introduced by this patchset. QA Note: C4/XISBN.pm should be renammed
Created attachment 77832 [details] [review] Bug 21226: Remove table services_throttle This table was only used by XISBN, this patch remove the table and the related code (cronjobs)
Created attachment 77833 [details] [review] Bug 21226: DB Changes Remove prefs OCLCAffiliateID, XISBN and XISBNDailyLimit
Created attachment 77834 [details] [review] Bug 21226: Remove xISBN services OCLC has decided to retire all xISBN services: https://www.oclc.org/developer/news/2018/xid-decommission.en.html The code for related features has to be removed from Koha. Test plan: You need to be familiar with the different sysprefs (I am not): - FRBRizeEditions - SyndeticsEnabled - SyndeticsEditions - ThingISBN Make sure there are no regressions introduced by this patchset. QA Note: C4/XISBN.pm should be renammed
Created attachment 77836 [details] [review] Bug 21226: Remove table services_throttle This table was only used by XISBN, this patch remove the table and the related code (cronjobs)
Created attachment 77902 [details] [review] Bug 21226: DB Changes Remove prefs OCLCAffiliateID, XISBN and XISBNDailyLimit Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 77903 [details] [review] Bug 21226: Remove xISBN services OCLC has decided to retire all xISBN services: https://www.oclc.org/developer/news/2018/xid-decommission.en.html The code for related features has to be removed from Koha. Test plan: You need to be familiar with the different sysprefs (I am not): - FRBRizeEditions - SyndeticsEnabled - SyndeticsEditions - ThingISBN Make sure there are no regressions introduced by this patchset. QA Note: C4/XISBN.pm should be renammed Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 77904 [details] [review] Bug 21226: Remove table services_throttle This table was only used by XISBN, this patch remove the table and the related code (cronjobs) Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
I think we might be breaking the terms of service for ThingISBN inadvertently before this patch. There's a loose mention of a 1000 query limit on the followup blog post announcing it's availability and with the removal of OCLC's service, this could become more of a problem if libraries decide to switch. http://blog.librarything.com/thingology/2008/01/while-you-were-sleeping-thingisbn-got-better/ Perhaps rather than removing the services throttle code we should switch to using it for the ThingISBN calls? I've reached out to Tim at LibraryThing for comment.
Created attachment 77918 [details] [review] Bug 21226: DB Changes Remove prefs OCLCAffiliateID, XISBN and XISBNDailyLimit Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 77919 [details] [review] Bug 21226: Remove xISBN services OCLC has decided to retire all xISBN services: https://www.oclc.org/developer/news/2018/xid-decommission.en.html The code for related features has to be removed from Koha. Test plan: You need to be familiar with the different sysprefs (I am not): - FRBRizeEditions - SyndeticsEnabled - SyndeticsEditions - ThingISBN Make sure there are no regressions introduced by this patchset. QA Note: C4/XISBN.pm should be renammed Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
I have moved the services throttle removal patch into it's own bug (bug 21235) as it may be required/helpful for adding throttling to ThingISBN pending feedback from the LibraryThing maintainers. I have passed qa on the remaining patches.
Awesome work all! Pushed top master for 18.11
Pushed to 18.05.x for 18.05.03
Pushed to 17.11.x for 17.11.10
UT XISBN.t fails so : pushed to 17.05.x for 17.05.14
Thanks Fridolin :)