Bug 21235 - Remove services_throttle if not required for ThingISBN
Summary: Remove services_throttle if not required for ThingISBN
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Web services (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 21226
Blocks:
  Show dependency treegraph
 
Reported: 2018-08-16 13:08 UTC by Martin Renvoize
Modified: 2019-10-14 19:57 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 21226: Remove table services_throttle (7.30 KB, patch)
2018-08-16 13:09 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 21235: Remove table services_throttle (7.30 KB, patch)
2018-08-16 13:10 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 21235: Remove table services_throttle (6.79 KB, patch)
2018-09-07 08:04 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 21235: Remove table services_throttle (6.79 KB, patch)
2018-09-07 15:30 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 21235: (qa followup) Remove table services_throttle (1.10 KB, patch)
2018-09-07 15:30 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 21235: Remove table services_throttle (6.79 KB, patch)
2018-09-07 15:31 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 21235: (QA follow-up) Remove table services_throttle (1.10 KB, patch)
2018-09-07 15:31 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2018-08-16 13:08:44 UTC
In bug 21226 we removed the now-defunct OCLC xisbn service from koha. This resulted in the services throttle functionality no longer being used and as such a patch to remove that alongside this was created.

However, upon QAing the above bug, it became apparent that we may well require throttling on the ThingISBN service and as such I chose to move the removal patches into their own bug awaiting a reply from the LibraryThing developers.
Comment 1 Martin Renvoize 2018-08-16 13:09:17 UTC
Created attachment 77920 [details] [review]
Bug 21226: Remove table services_throttle

This table was only used by XISBN, this patch remove the table and the
related code (cronjobs)

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 2 Martin Renvoize 2018-08-16 13:10:20 UTC
Created attachment 77921 [details] [review]
Bug 21235: Remove table services_throttle

This table was only used by XISBN, this patch remove the table and the
related code (cronjobs)

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 3 Jonathan Druart 2018-08-17 15:15:05 UTC
Blocked, waiting for an answer from ThingISBN's guys.
Comment 4 Martin Renvoize 2018-09-07 07:57:37 UTC
I've had nothing back from the LibraryThing people (reached out on twitter and email).  As such, I think we're safe to remove this now.

Setting to 'signed off' as the patches were already signed off in the original bug before my QA.

I'll qa them shortly.
Comment 5 Martin Renvoize 2018-09-07 08:04:19 UTC
Created attachment 78502 [details] [review]
Bug 21235: Remove table services_throttle

This table was only used by XISBN, this patch remove the table and the
related code (cronjobs)

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

https://bugs.koha-community.org/show_bug.cgi?id=21235
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 6 Martin Renvoize 2018-09-07 08:04:42 UTC
Passing QA
Comment 7 Martin Renvoize 2018-09-07 15:30:17 UTC
Created attachment 78531 [details] [review]
Bug 21235: Remove table services_throttle

This table was only used by XISBN, this patch remove the table and the
related code (cronjobs)

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

https://bugs.koha-community.org/show_bug.cgi?id=21235
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 8 Martin Renvoize 2018-09-07 15:30:21 UTC
Created attachment 78532 [details] [review]
Bug 21235: (qa followup) Remove table services_throttle

Add the missing db update to nuke the services throttle from high orbit

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 9 Martin Renvoize 2018-09-07 15:31:22 UTC
Created attachment 78533 [details] [review]
Bug 21235: Remove table services_throttle

This table was only used by XISBN, this patch remove the table and the
related code (cronjobs)

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

https://bugs.koha-community.org/show_bug.cgi?id=21235
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 10 Martin Renvoize 2018-09-07 15:31:26 UTC
Created attachment 78534 [details] [review]
Bug 21235: (QA follow-up) Remove table services_throttle

Add the missing db update to nuke the services throttle from high orbit

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 11 Martin Renvoize 2018-09-07 15:32:35 UTC
Added a followup with the missing atomic update to remove existing services_throttle table for upgrades
Comment 12 Nick Clemens 2018-09-07 16:05:53 UTC
Awesome work all!

Pushed to master for 18.11
Comment 13 Martin Renvoize 2018-09-11 08:45:06 UTC
Pushed to 18.05.x for 18.05.04
Comment 14 Fridolin Somers 2018-09-21 13:10:54 UTC
I prefer not to push to 17.11.x to keep this change in a major upgrade