Bug 21291 - Article requests page doesn't show MARC, LabeledMARC and ISBD in sidebar
Summary: Article requests page doesn't show MARC, LabeledMARC and ISBD in sidebar
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Blou
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 21492
  Show dependency treegraph
 
Reported: 2018-08-30 14:30 UTC by Blou
Modified: 2019-10-14 19:56 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 21291: request-article.pl doesn't show MARC, LabeledMARC and ISBD in sidebar (1.51 KB, patch)
2018-08-30 14:37 UTC, Blou
Details | Diff | Splinter Review
Bug 21291: (follow up) Pass subscriptionsnumber to all tools in staff detail's sidebar (3.38 KB, patch)
2018-10-04 17:07 UTC, Blou
Details | Diff | Splinter Review
Bug 21291: (follow up) Pass subscriptionsnumber to all tools in staff detail's sidebar (3.43 KB, patch)
2018-10-04 17:48 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 21291: (follow up) Pass subscriptionsnumber to all tools in staff detail's sidebar (5.16 KB, patch)
2018-10-10 19:36 UTC, Blou
Details | Diff | Splinter Review
Bug 21291: request-article.pl doesn't show MARC, LabeledMARC and ISBD in sidebar (1.56 KB, patch)
2018-10-11 11:49 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 21291: (follow up) Pass subscriptionsnumber to all tools in staff detail's sidebar (5.21 KB, patch)
2018-10-11 11:49 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 21291: request-article.pl doesn't show MARC, LabeledMARC and ISBD in sidebar (1.62 KB, patch)
2018-10-11 21:11 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 21291: (follow-up) Pass subscriptionsnumber to all tools in staff detail's sidebar (5.27 KB, patch)
2018-10-11 21:12 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Blou 2018-08-30 14:30:26 UTC
When on a detailed record in the intranet, any click on the sidebar will lead you to another page with the same sidebar EXCEPT for "Article requests".

When clicking on article requests, you get a new sidebar without
MARC
Labeled MARC
ISBD
Comment 1 Blou 2018-08-30 14:37:40 UTC
Created attachment 78311 [details] [review]
Bug 21291: request-article.pl doesn't show MARC, LabeledMARC and ISBD in sidebar

When on a detailed record in the intranet, any click on the sidebar will lead you to another page with the same sidebar EXCEPT for "Article requests".

When clicking on article requests, you get a new sidebar without
MARC
Labeled MARC
ISBD

This fix adds the required C4::Biblio::enabled_staff_search_views that loads the required hash with the permissions.

TEST
0) login with a user having all rights
1) go to any detailed notices, notice the sidebar on the left
2) click on MARC
3) notice the sidebar is the same in the new page
4) click on Request articles
5) notice the missing labels on the sidebar
6) apply patch, redo steps
Comment 2 Séverine Queune 2018-09-16 18:34:03 UTC
Patch works as described, but you missed the tab "Subscription(s)" which also disappears when we're on "Article request" + "Holds" +"Checkout history" + "Modification logs" tabs.
Do you want to fix it too, or should I open a new report ?
Comment 3 Katrin Fischer 2018-09-22 10:58:27 UTC
"In Discussion" asks for more opinions, better to use "Failed QA" for questions to the developer.
Comment 4 Séverine Queune 2018-09-24 08:55:14 UTC
Oups... sorry Katrin, and thanks for the advice !
Comment 5 Blou 2018-10-04 17:07:33 UTC
Created attachment 79952 [details] [review]
Bug 21291: (follow up) Pass subscriptionsnumber to all tools in staff detail's sidebar

The subscriptionsnumber is required in biblio-view-menu.inc to display the Subscription(s) tab.
In detail.pl, if you click any of

Hold(s)
Article requests
Checkout history
Modification log

you lose the Subscription(s) tab.

This patch fixes the display by having each feature script generate that value to be passed to the UI.
I keep this separated from the first patch since it's not exactly the same issue, and the solution might not please.
Comment 6 Owen Leonard 2018-10-04 17:48:19 UTC Comment hidden (obsolete)
Comment 7 Katrin Fischer 2018-10-06 19:03:06 UTC
Sorry, patch doesn't apply - can you have a look please?

 sloth:/usr/local/vagrant/kohaclone_master (30-21291-missing-navigation) $ git b apply 21291
Bug 21291 - request-article.pl doesn't show MARC, LabeledMARC and ISBD in sidebar

79958 - Bug 21291: (follow up) Pass subscriptionsnumber to all tools in staff detail's sidebar

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 21291: (follow up) Pass subscriptionsnumber to all tools in staff detail's sidebar
error: sha1 information is lacking or useless (circ/request-article.pl).
error: could not build fake ancestor
Patch failed at 0001 Bug 21291: (follow up) Pass subscriptionsnumber to all tools in staff detail's sidebar
Use 'git am --show-current-patch' to see the failed patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Comment 8 Blou 2018-10-09 19:36:52 UTC
The first patch had been obsoleted.  Once put back, it all applies without problem.
Comment 9 Owen Leonard 2018-10-10 14:12:30 UTC
I noticed a couple of things while working on Bug 21492 I noticed a couple of issues with this:

- Missing subscriptions tab on the labeled MARC view
  (catalogue/labeledMARCdetail.pl)
- Missing subscriptions tab on the stock rotation page 
  (catalogue/stockrotation.pl)
- The subscriptionsnumber variable being passed to the view log template is not a  number as it is on other page. With Bug 21492 applied the variable is output as "Object."
Comment 10 Blou 2018-10-10 19:36:34 UTC
Created attachment 80369 [details] [review]
Bug 21291: (follow up) Pass subscriptionsnumber to all tools in staff detail's sidebar

The subscriptionsnumber is required in biblio-view-menu.inc to display the Subscription(s) tab.
In detail.pl, if you click any of

Labeled MARC  (you need to set the syspref viewLabeledMARC)
Hold(s)
Article requests
Checkout history
Modification log
Rota          (you need to set the syspref StockRotation)

you lose the Subscription(s) tab.

This patch fixes the display by having each feature script generate that value to be passed to the UI.
I keep this separated from the first patch since it's not exactly the same issue, and the solution might not please.
Comment 11 Owen Leonard 2018-10-11 11:49:17 UTC
Created attachment 80401 [details] [review]
Bug 21291: request-article.pl doesn't show MARC, LabeledMARC and ISBD in sidebar

When on a detailed record in the intranet, any click on the sidebar
will lead you to another page with the same sidebar EXCEPT for "Article
requests".

When clicking on article requests, you get a new sidebar without
MARC
Labeled MARC
ISBD

This fix adds the required C4::Biblio::enabled_staff_search_views that
loads the required hash with the permissions.

TEST
0) login with a user having all rights
1) go to any detailed notices, notice the sidebar on the left
2) click on MARC
3) notice the sidebar is the same in the new page
4) click on Request articles
5) notice the missing labels on the sidebar
6) apply patch, redo steps

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 12 Owen Leonard 2018-10-11 11:49:21 UTC
Created attachment 80402 [details] [review]
Bug 21291: (follow up) Pass subscriptionsnumber to all tools in staff detail's sidebar

The subscriptionsnumber is required in biblio-view-menu.inc to display
the Subscription(s) tab. In detail.pl, if you click any of

Labeled MARC  (you need to set the syspref viewLabeledMARC)
Hold(s)
Article requests
Checkout history
Modification log
Rota          (you need to set the syspref StockRotation)

you lose the Subscription(s) tab.

This patch fixes the display by having each feature script generate that
value to be passed to the UI. I keep this separated from the first patch
since it's not exactly the same issue, and the solution might not
please.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 13 Katrin Fischer 2018-10-11 21:11:34 UTC
Created attachment 80427 [details] [review]
Bug 21291: request-article.pl doesn't show MARC, LabeledMARC and ISBD in sidebar

When on a detailed record in the intranet, any click on the sidebar
will lead you to another page with the same sidebar EXCEPT for "Article
requests".

When clicking on article requests, you get a new sidebar without
MARC
Labeled MARC
ISBD

This fix adds the required C4::Biblio::enabled_staff_search_views that
loads the required hash with the permissions.

TEST
0) login with a user having all rights
1) go to any detailed notices, notice the sidebar on the left
2) click on MARC
3) notice the sidebar is the same in the new page
4) click on Request articles
5) notice the missing labels on the sidebar
6) apply patch, redo steps

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 14 Katrin Fischer 2018-10-11 21:12:26 UTC
Created attachment 80428 [details] [review]
Bug 21291: (follow-up) Pass subscriptionsnumber to all tools in staff detail's sidebar

The subscriptionsnumber is required in biblio-view-menu.inc to display
the Subscription(s) tab. In detail.pl, if you click any of

Labeled MARC  (you need to set the syspref viewLabeledMARC)
Hold(s)
Article requests
Checkout history
Modification log
Rota          (you need to set the syspref StockRotation)

you lose the Subscription(s) tab.

This patch fixes the display by having each feature script generate that
value to be passed to the UI. I keep this separated from the first patch
since it's not exactly the same issue, and the solution might not
please.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 15 Nick Clemens 2018-10-15 17:03:53 UTC
Awesome work all!

Pushed to master for 18.11
Comment 16 Martin Renvoize 2018-10-17 10:50:55 UTC
Pushed to 18.05.x for 18.05.05
Comment 17 Fridolin Somers 2018-11-09 08:31:21 UTC
For 17.11.x I prefer not to change display of oldstable branch