Bug 21492 - Show subscriptions count in the sidebar menu
Summary: Show subscriptions count in the sidebar menu
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 21291
Blocks:
  Show dependency tree / graph
 
Reported: 2018-10-04 18:04 UTC by Owen Leonard
Modified: 2019-10-14 19:56 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 21492: Show subscriptions count in the sidebar menu (1.72 KB, patch)
2018-10-10 13:43 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 21492: Show subscriptions count in the sidebar menu (1.83 KB, patch)
2018-10-11 21:21 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2018-10-04 18:04:22 UTC 
The various bibliographic view templates all have available to them a count of the subscriptions for that title. We should show it in the sidebar menu as:

Subscriptions (2)

Instead of...

Subscription(s)
Comment 1 Owen Leonard 2018-10-10 13:43:02 UTC 
Created attachment 80350 [details] [review]
Bug 21492: Show subscriptions count in the sidebar menu

This patch modifies the include file for the sidebar menu of
bibliographic views so that a count of subscriptions is shown on the
subscriptions tab.

To test you should have bibliographic record with one or more
subscriptions. View that bibliographic record and confirm that the
sidebar menu tab shows the count of subscriptions.
Comment 2 Katrin Fischer 2018-10-11 21:21:05 UTC 
Created attachment 80429 [details] [review]
Bug 21492: Show subscriptions count in the sidebar menu

This patch modifies the include file for the sidebar menu of
bibliographic views so that a count of subscriptions is shown on the
subscriptions tab.

To test you should have bibliographic record with one or more
subscriptions. View that bibliographic record and confirm that the
sidebar menu tab shows the count of subscriptions.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

https://bugs.koha-community.org/show_bug.cgi?id=21291
Comment 3 Katrin Fischer 2018-10-11 21:21:29 UTC 
Really nice one line patch, PQA too.
Comment 4 Nick Clemens (kidclamp) 2018-10-24 17:33:45 UTC 
Awesome work all!

Pushed to master for 18.11
Comment 5 Martin Renvoize (ashimema) 2018-11-06 10:31:12 UTC 
Enhancement, will not be backported to 18.05.x series.