Created attachment 79511 [details] Internal server error Internal server error when clicking on Checkout History left menu. Koha 18.05.02.000 See image attached.
Could you elaborate on the error please Claudio, I can't replicate any issues on the latest 18.05.x branch or the 18.05.04 release.
Of course Martin, sorry. I've just noticed a plack error. ) Login into intranet 2) Search something 3) Click on “Checkout History” link in the left side menu as shown in the image I have attached 4) Internal server error occurs 5) Plack error: Argument "batch_id" isn't numeric in numeric eq (==) at /usr/share/koha/lib/C4/Creators/Lib.pm line 536. Template process failed: undef error - DBIC result _type isn't of the _type Borrower at /usr/share/koha/intranet/htdocs/intranet-tmpl/prog/es-ES/modules/catalogue/issuehistory.tt line 47. Could not dup 'STDIN': Invalid argument at /usr/share/perl5/Archive/Extract.pm line 146. Could not restore 'STDIN': Invalid argument at /usr/share/perl5/Archive/Extract.pm line 146. Template process failed: undef error - DBIC result _type isn't of the _type Borrower at /usr/share/koha/intranet/htdocs/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt line 47. Koha version 18.02 Hope this helps...
Martin, was my last comment enough? Please contact me if you are expecting further information
Thanks Claudio, I'll get to investigating this further shortly.
;)
Confirmed on master if a patron has been removed.
Caused by commit 3c65318243de786bdc11d9ad335a253d59754d74 Bug 20899: Fix patron's name display
Created attachment 79785 [details] [review] Bug 21432: (bug 20899 follow-up) Fix patron's name display for deleted patrons Template process failed: undef error - DBIC result _type isn't of the _type Borrower at /home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt line 54. Koha::Old::Checkout->patron should return undef if the patron record has been removed. Test plan: - Check 2 items out on the same bibliographic record - Check them in - Delete the patron's record of one of the issuer (Is this word really exist?) - View the checkout history for this bib record (Home › Catalog › Checkout history) => Without this patch you get the error => With this patch applied one of the "Patron" cells will be empty
Upping severity.
I have made a test in a local installation and it works fine!
(In reply to Claudio from comment #10) > I have made a test in a local installation and it works fine! Can you add your signed-off-by stamp on the patch?
The fix works fine! Thanks Martin and Jonathan!
Created attachment 79828 [details] [review] Bug 21432: (bug 20899 follow-up) Fix patron's name display for deleted patrons Template process failed: undef error - DBIC result _type isn't of the _type Borrower at /home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt line 54. Koha::Old::Checkout->patron should return undef if the patron record has been removed. Test plan: - Check 2 items out on the same bibliographic record - Check them in - Delete the patron's record of one of the issuer (Is this word really exist?) - View the checkout history for this bib record (Home › Catalog › Checkout history) => Without this patch you get the error => With this patch applied one of the "Patron" cells will be empty Signed-off-by: Claudio <costalc@gmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Awesome work all! Pushed to master for 18.11
Pushed to 18.05.x for 18.05.05 Thanks for jumping on this one Jonathan.
Depends on Bug 20899 not in 17.11.x
*** Bug 21624 has been marked as a duplicate of this bug. ***