Bug 21470 - Due date no longer shown in red when viewing checkouts for a patron
Summary: Due date no longer shown in red when viewing checkouts for a patron
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 19474
Blocks:
  Show dependency treegraph
 
Reported: 2018-10-02 11:01 UTC by Stefan Berndtsson
Modified: 2019-10-14 19:56 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 21470: Due date no longer shown in red when viewing checkouts for a patron (1.54 KB, patch)
2018-10-02 13:54 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 21470: Due date no longer shown in red when viewing checkouts for a patron (1.61 KB, patch)
2018-10-05 19:33 UTC, Pierre-Marc Thibault
Details | Diff | Splinter Review
Bug 21470: Due date no longer shown in red when viewing checkouts for a patron (1.61 KB, patch)
2018-10-06 19:21 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Berndtsson 2018-10-02 11:01:41 UTC
It seems the conversion from CSS to SCSS for staff-global.css (Bug 19474) has misplaced the colouring of the "overdue" class when viewing checkouts for a patron.

18.05, which does not use SCSS, has rules for ".overdue" and ".debit", but in the SCSS these are placed inside the "a" tag rule.
Comment 1 Owen Leonard 2018-10-02 13:54:40 UTC
Created attachment 79821 [details] [review]
Bug 21470: Due date no longer shown in red when viewing checkouts for a patron

This patch corrects an error in the staff client CSS which was causing
overdue items on the checkout screen to not be highlighted.

To test, apply the patch and regenerate the staff client CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

Check out to a patron who has overdues. The overdue items should have
due dates styled bold and red.
Comment 2 Pierre-Marc Thibault 2018-10-05 19:33:32 UTC
Created attachment 80148 [details] [review]
Bug 21470: Due date no longer shown in red when viewing checkouts for a patron

This patch corrects an error in the staff client CSS which was causing
overdue items on the checkout screen to not be highlighted.

To test, apply the patch and regenerate the staff client CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

Check out to a patron who has overdues. The overdue items should have
due dates styled bold and red.

Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com>
Comment 3 Katrin Fischer 2018-10-06 19:21:34 UTC
Created attachment 80163 [details] [review]
Bug 21470: Due date no longer shown in red when viewing checkouts for a patron

This patch corrects an error in the staff client CSS which was causing
overdue items on the checkout screen to not be highlighted.

To test, apply the patch and regenerate the staff client CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

Check out to a patron who has overdues. The overdue items should have
due dates styled bold and red.

Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com>
Comment 4 Nick Clemens 2018-10-09 16:22:15 UTC
Awesome work all!

Pushed to master for 18.11
Comment 5 Martin Renvoize 2018-10-15 11:38:20 UTC
Caused by bug 19474 not in 18.05.x series.
Comment 6 Jonathan Druart 2018-10-15 14:52:05 UTC
+ .strong {
+    font-weight: bold;
+ }

Was it expected?