Bug 21568 - Add more spans with classes around callnumbers in OPAC for additional styling
Summary: Add more spans with classes around callnumbers in OPAC for additional styling
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Kyle M Hall
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-15 10:36 UTC by Kyle M Hall
Modified: 2019-10-14 19:58 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 21568: Add more spans with classes around callnumbers in OPAC for additional styling (3.00 KB, patch)
2018-10-15 10:51 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 21568: Add more spans with classes around callnumbers in OPAC for additional styling (3.03 KB, patch)
2018-10-15 12:01 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 21568: Add more spans with classes around callnumbers in OPAC for additional styling (3.09 KB, patch)
2018-10-18 16:26 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2018-10-15 10:36:34 UTC
It would be nice if the callnumber portion of the callnumber + label was in a span, and it also makes sense to wrap the entire callnumber string in a span as well. This was started on bug 21340 but I have found more callnumbers in the search results that need spans.
Comment 1 Kyle M Hall 2018-10-15 10:51:38 UTC
Created attachment 80588 [details] [review]
Bug 21568: Add more spans with classes around callnumbers in OPAC for additional styling

It would be nice if the callnumber portion of the callnumber + label was in a span,
and it also makes sense to wrap the entire callnumber string in a span as well.
This was started on bug 21340 but I have found more callnumbers in the search results that need spans.

Test Plan:
1) Apply this patch
2) Search for something in the OAPC with multiple results
3) View the HTML source
4) Note the new spans around the callnumbers, like: <span class="CallNumber"
Comment 2 Owen Leonard 2018-10-15 12:01:12 UTC
Created attachment 80589 [details] [review]
Bug 21568: Add more spans with classes around callnumbers in OPAC for additional styling

It would be nice if the callnumber portion of the callnumber + label was in a span,
and it also makes sense to wrap the entire callnumber string in a span as well.
This was started on bug 21340 but I have found more callnumbers in the search results that need spans.

Test Plan:
1) Apply this patch
2) Search for something in the OAPC with multiple results
3) View the HTML source
4) Note the new spans around the callnumbers, like: <span class="CallNumber"

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Tomás Cohen Arazi 2018-10-18 16:26:13 UTC
Created attachment 80865 [details] [review]
Bug 21568: Add more spans with classes around callnumbers in OPAC for additional styling

It would be nice if the callnumber portion of the callnumber + label was in a span,
and it also makes sense to wrap the entire callnumber string in a span as well.
This was started on bug 21340 but I have found more callnumbers in the search results that need spans.

Test Plan:
1) Apply this patch
2) Search for something in the OAPC with multiple results
3) View the HTML source
4) Note the new spans around the callnumbers, like: <span class="CallNumber"

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 4 Nick Clemens 2018-11-05 14:57:05 UTC
Awesome work all!

Pushed to master for 18.11
Comment 5 Martin Renvoize 2018-11-16 12:25:49 UTC
Enhancement, will not be backported into 18.05.x series.