On addorderiso2709.pl there is a JS error "ReferenceError: $ is not defined" It comes from commit 1a132440766277d6d94246a86ec671b79de7a442 Bug 19753: Move template JavaScript to the footer: Acquisitions From Owen on #koha: """ That's just poor testing on my part, and the change to that file should be undone. There's currently no good way to handle cataloging plugin JS with all other JS in the footer """
Owen, could you have a look maybe? Is this an urgent one?
Created attachment 83889 [details] [review] Bug 21989: JS error in "Add orders from MARC file" - addorderiso2709.pl This patch undoes the changes to addorderiso2709.tt introduced by Bug 19753. The item information tab can include embedded JavaScript for cataloging plugins, and these don't currently work with JS in the footer. To test, apply the patch and test the JavaScript driven features of the "Add to basket from a staged file" page: - Acquisitions -> Vendor -> Basket -> Add to basket from a staged file - MARC and Card previews, select all/clear all - Item information tab: Cataloging plugins for fields like date acquired, barcode - Default accounting details tab: Show inactive control
Created attachment 84440 [details] [review] Bug 21989: JS error in "Add orders from MARC file" - addorderiso2709.pl This patch undoes the changes to addorderiso2709.tt introduced by Bug 19753. The item information tab can include embedded JavaScript for cataloging plugins, and these don't currently work with JS in the footer. To test, apply the patch and test the JavaScript driven features of the "Add to basket from a staged file" page: - Acquisitions -> Vendor -> Basket -> Add to basket from a staged file - MARC and Card previews, select all/clear all - Item information tab: Cataloging plugins for fields like date acquired, barcode - Default accounting details tab: Show inactive control Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Created attachment 84445 [details] [review] Bug 21989: JS error in "Add orders from MARC file" - addorderiso2709.pl This patch undoes the changes to addorderiso2709.tt introduced by Bug 19753. The item information tab can include embedded JavaScript for cataloging plugins, and these don't currently work with JS in the footer. To test, apply the patch and test the JavaScript driven features of the "Add to basket from a staged file" page: - Acquisitions -> Vendor -> Basket -> Add to basket from a staged file - MARC and Card previews, select all/clear all - Item information tab: Cataloging plugins for fields like date acquired, barcode - Default accounting details tab: Show inactive control Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Ignoring the QA script fail as invalid in this case (see commit message): FAIL koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt OK filters OK forbidden patterns OK git manipulation FAIL js_in_body A <script> tag found inside head, must be moved to the body (see bug 17858)
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.03
doesnt cleanly apply to 18.05.x needs rebase
Created attachment 84815 [details] [review] Bug 21989: [18.05.x] JS error in "Add orders from MARC file" - addorderiso2709.pl This patch undoes the changes to addorderiso2709.tt introduced by Bug 19753. The item information tab can include embedded JavaScript for cataloging plugins, and these don't currently work with JS in the footer. To test, apply the patch and test the JavaScript driven features of the "Add to basket from a staged file" page: - Acquisitions -> Vendor -> Basket -> Add to basket from a staged file - MARC and Card previews, select all/clear all - Item information tab: Cataloging plugins for fields like date acquired, barcode - Default accounting details tab: Show inactive control