I get a JavaScript error in the console when I view the details of a subscription (serials/subscription-detail.pl): TypeError: this.data(...) is undefined[Learn More] jquery.treetable_18.1200010.js:481:7 I assume this is because I don't have any orders associated with my subscription?
Created attachment 84540 [details] [review] Bug 22239: JavaScript error on subscription detail page when there are no orders This page modifies the subscription detail page so that a JavaScript error isn't triggered when a subscription has no acquisition details. To test, apply the patch and go to Serials. - Locate a subscription which isn't tied to acquisitions. In the browser console there should be no errors. - Locate a subscription which is part of an order. There should be an 'Acquisitions details' tab and the order information on that tab should be displayed as a collapsible tree.
*** Bug 22072 has been marked as a duplicate of this bug. ***
Created attachment 85190 [details] [review] Bug 22239: JavaScript error on subscription detail page when there are no orders This page modifies the subscription detail page so that a JavaScript error isn't triggered when a subscription has no acquisition details. To test, apply the patch and go to Serials. - Locate a subscription which isn't tied to acquisitions. In the browser console there should be no errors. - Locate a subscription which is part of an order. There should be an 'Acquisitions details' tab and the order information on that tab should be displayed as a collapsible tree. Signed-off-by: Charles Farmer <charles.farmer@inLibro.com>
Created attachment 85204 [details] [review] Bug 22239: JavaScript error on subscription detail page when there are no orders This page modifies the subscription detail page so that a JavaScript error isn't triggered when a subscription has no acquisition details. To test, apply the patch and go to Serials. - Locate a subscription which isn't tied to acquisitions. In the browser console there should be no errors. - Locate a subscription which is part of an order. There should be an 'Acquisitions details' tab and the order information on that tab should be displayed as a collapsible tree. Signed-off-by: Charles Farmer <charles.farmer@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.04
missing dependency for 18.05.x, won't backport