When a new order is created from a subscription the quantity is set to 1 and cannot be modified. The idea was to order 1 subscription. This behavior leads to a limitation: it is not possible to mark a receipt as partially received. However it is how it works in real life, the vendors send invoices throughout the year. The number of items can also be changed. The idea would be to rethink the "quantity" value for an order created from a subscription and use it to track the number of invoices already paid.
Created attachment 79801 [details] [review] Bug 21467: Allow several receipts for a given subscription When a new order is created from a subscription the quantity is set to 1 and cannot be modified. The idea was to order 1 subscription. This behavior leads to a limitation: it is not possible to mark a receipt as partially received. However it is how it works in real life, the vendors send invoices throughout the year. The number of items can also be changed. The idea is be to rethink the "quantity" value for an order created from a subscription and use it to track the number of invoices already paid. FIXME: This approach will not cohabit with standing orders. This patch is a first draft to get feedback on the idea. FIXME: What about cancelled orders? Test plan: - Create a new order from a subscription - Enter the number of items you think you will receive for this subscription (for instance 1 per month: 12) - Close the basket - Receive 3 items (a trimester) and create a specific invoice for this receipt. Note that the price are per unit. If you want to receive items with different prices you should make split the receipt - Receive more items. This time you will notice that the previous order will be displayed on the "order receive" under a new block "Receipt history for this subscription" - Note that the "Quantity to receive" has been decrease by the number of items you previously received - Also you can notice that this "Quantity to receive" can be modified. Indeed it can happen that the number of items to receive changed during the year - Go to the detail of the subscription and notice that the orders have been grouped by "parent ordernumber" - Continue to receive items until all have been received
Created attachment 79802 [details] [review] Bug 21467: Add treetable to subscription detail to group orders by parent ordernumber
Created attachment 79834 [details] [review] Bug 21467: Allow several receipts for a given subscription When a new order is created from a subscription the quantity is set to 1 and cannot be modified. The idea was to order 1 subscription. This behavior leads to a limitation: it is not possible to mark a receipt as partially received. However it is how it works in real life, the vendors send invoices throughout the year. The number of items can also be changed. The idea is be to rethink the "quantity" value for an order created from a subscription and use it to track the number of invoices already paid. FIXME: This approach will not cohabit with standing orders. This patch is a first draft to get feedback on the idea. FIXME: What about cancelled orders? Test plan: - Create a new order from a subscription - Enter the number of items you think you will receive for this subscription (for instance 1 per month: 12) - Close the basket - Receive 3 items (a trimester) and create a specific invoice for this receipt. Note that the price are per unit. If you want to receive items with different prices you should make split the receipt - Receive more items. This time you will notice that the previous order will be displayed on the "order receive" under a new block "Receipt history for this subscription" - Note that the "Quantity to receive" has been decrease by the number of items you previously received - Also you can notice that this "Quantity to receive" can be modified. Indeed it can happen that the number of items to receive changed during the year - Go to the detail of the subscription and notice that the orders have been grouped by "parent ordernumber" - Continue to receive items until all have been received
Created attachment 79835 [details] [review] Bug 21467: Add treetable to subscription detail to group orders by parent ordernumber
Created attachment 79836 [details] [review] Bug 21467: Add subscription's info when ordering When ordering from a subscription, there is now a "hint" to display the number of issues and the frequency. It will be easier to estimate the quantity to receive.
Created attachment 79837 [details] [review] Bug 21467: Do not erase the internal note of the first order For the subscription we would like to keep the original internal note (from the first order), to display it unmodified each time we receive issues.
Created attachment 79838 [details] [review] Bug 21467: Display the quantity and adjust the amounts On the subscription detail view we should display the amounts depending on the quantity (can be different than 0 now!)
Created attachment 80546 [details] [review] Bug 21467: Display a summary line per parent_ordernumber This will help to keep track of the different orders for a given subscription.
Why "In Discussion"?
(In reply to Katrin Fischer from comment #9) > Why "In Discussion"? The patch is not ready for testing, I am iterating with the sponsor (Séverine @BULAC) by email. But you can read/test the patches and provide feedback if you want :)
Created attachment 80706 [details] [review] Bug 21467: Fix default sort
Created attachment 80707 [details] [review] Bug 21467: Display a summary line per parent_ordernumber This will help to keep track of the different orders for a given subscription.
Created attachment 80717 [details] [review] Bug 21474: Add the Koha::Subscription->frequency method And the 2 modules for the subscriptions' frequencies Test plan: prove t/db_dependent/Koha/Subscription.t must return green Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 80718 [details] [review] Bug 21467: Allow several receipts for a given subscription When a new order is created from a subscription the quantity is set to 1 and cannot be modified. The idea was to order 1 subscription. This behavior leads to a limitation: it is not possible to mark a receipt as partially received. However it is how it works in real life, the vendors send invoices throughout the year. The number of items can also be changed. The idea is be to rethink the "quantity" value for an order created from a subscription and use it to track the number of invoices already paid. FIXME: This approach will not cohabit with standing orders. This patch is a first draft to get feedback on the idea. FIXME: What about cancelled orders? Test plan: - Create a new order from a subscription - Enter the number of items you think you will receive for this subscription (for instance 1 per month: 12) - Close the basket - Receive 3 items (a trimester) and create a specific invoice for this receipt. Note that the price are per unit. If you want to receive items with different prices you should make split the receipt - Receive more items. This time you will notice that the previous order will be displayed on the "order receive" under a new block "Receipt history for this subscription" - Note that the "Quantity to receive" has been decrease by the number of items you previously received - Also you can notice that this "Quantity to receive" can be modified. Indeed it can happen that the number of items to receive changed during the year - Go to the detail of the subscription and notice that the orders have been grouped by "parent ordernumber" - Continue to receive items until all have been received Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 80719 [details] [review] Bug 21467: Add treetable to subscription detail to group orders by parent ordernumber Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 80720 [details] [review] Bug 21467: Add subscription's info when ordering When ordering from a subscription, there is now a "hint" to display the number of issues and the frequency. It will be easier to estimate the quantity to receive. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 80721 [details] [review] Bug 21467: Do not erase the internal note of the first order For the subscription we would like to keep the original internal note (from the first order), to display it unmodified each time we receive issues. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 80722 [details] [review] Bug 21467: Display the quantity and adjust the amounts On the subscription detail view we should display the amounts depending on the quantity (can be different than 0 now!) Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 80723 [details] [review] Bug 21467: Fix default sort Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 80724 [details] [review] Bug 21467: Display a summary line per parent_ordernumber This will help to keep track of the different orders for a given subscription. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Patch doesn't apply (on top of bug 21475: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 21467: Allow several receipts for a given subscription Applying: Bug 21467: Add treetable to subscription detail to group orders by parent ordernumber Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt Applying: Bug 21467: Add subscription's info when ordering Applying: Bug 21467: Do not erase the internal note of the first order Applying: Bug 21467: Display the quantity and adjust the amounts Applying: Bug 21467: Fix default sort Applying: Bug 21467: Display a summary line per parent_ordernumber error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt). error: could not build fake ancestor Patch failed at 0001 Bug 21467: Display a summary line per parent_ordernumber The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-21467-Display-a-summary-line-per-parentordernu-mjKFO_.patch
Created attachment 81394 [details] [review] Bug 21467: Allow several receipts for a given subscription When a new order is created from a subscription the quantity is set to 1 and cannot be modified. The idea was to order 1 subscription. This behavior leads to a limitation: it is not possible to mark a receipt as partially received. However it is how it works in real life, the vendors send invoices throughout the year. The number of items can also be changed. The idea is be to rethink the "quantity" value for an order created from a subscription and use it to track the number of invoices already paid. FIXME: This approach will not cohabit with standing orders. This patch is a first draft to get feedback on the idea. FIXME: What about cancelled orders? Test plan: - Create a new order from a subscription - Enter the number of items you think you will receive for this subscription (for instance 1 per month: 12) - Close the basket - Receive 3 items (a trimester) and create a specific invoice for this receipt. Note that the price are per unit. If you want to receive items with different prices you should make split the receipt - Receive more items. This time you will notice that the previous order will be displayed on the "order receive" under a new block "Receipt history for this subscription" - Note that the "Quantity to receive" has been decrease by the number of items you previously received - Also you can notice that this "Quantity to receive" can be modified. Indeed it can happen that the number of items to receive changed during the year - Go to the detail of the subscription and notice that the orders have been grouped by "parent ordernumber" - Continue to receive items until all have been received Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 81395 [details] [review] Bug 21467: Add treetable to subscription detail to group orders by parent ordernumber Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 81396 [details] [review] Bug 21467: Add subscription's info when ordering When ordering from a subscription, there is now a "hint" to display the number of issues and the frequency. It will be easier to estimate the quantity to receive. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 81397 [details] [review] Bug 21467: Do not erase the internal note of the first order For the subscription we would like to keep the original internal note (from the first order), to display it unmodified each time we receive issues. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 81398 [details] [review] Bug 21467: Display the quantity and adjust the amounts On the subscription detail view we should display the amounts depending on the quantity (can be different than 0 now!) Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 81399 [details] [review] Bug 21467: Fix default sort Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 81400 [details] [review] Bug 21467: Display a summary line per parent_ordernumber This will help to keep track of the different orders for a given subscription. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
In case you are faster than me: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt FAIL filters wrong_html_filter at line 79 ( <a href="/cgi-bin/koha/acqui/invoice.pl?invoiceid=[% order.invoiceid | html %]" title="Invoice detail page">) FAIL t/db_dependent/Acquisition.t OK critic OK forbidden patterns OK git manipulation OK pod OK spelling FAIL valid Can't redeclare "my" in "my" t/db_dependent/Acquisition.t had compilation errors.
Created attachment 81430 [details] [review] Bug 21467: (QA follow-up) Fix filter and variable declaration in .t
Jonathan, can you explain a bit more? 1) I am a little confused as to what items means in the test plan. Items from the order = Invoices I plan to enter? Or Issues? 2) What about the FIXMEs? - standing orders - why can't it cohabit? If these changes only applied to 'order by subscription' it would be ok, right? - cancelling order I'll come back to this, but continuing somewhere else first. Can you please check my follow-up?
(In reply to Katrin Fischer from comment #31) > Jonathan, can you explain a bit more? > > 1) I am a little confused as to what items means in the test plan. Items > from the order = Invoices I plan to enter? Or Issues? The number of issues you are expecting for this subscription. > 2) What about the FIXMEs? > - standing orders - why can't it cohabit? If these changes only applied to > 'order by subscription' it would be ok, right? You can create an order from a subscription, using a basket that has the standing orders flag. > - cancelling order It was a question for the tester, and Séverine confirmed me it seems to work ok in case of cancelled orders. > I'll come back to this, but continuing somewhere else first. > > Can you please check my follow-up? It looks great, thanks!
*** Bug 17876 has been marked as a duplicate of this bug. ***
QA tools are green, but there is a problem with the tests. I will continue testing, hoping for a quick follow-up: kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Acquisition.t t/db_dependent/Acquisition.t .. 70/71 DBD::mysql::db do failed: Out of range value for column 'tax_value_on_ordering' at row 1 [for Statement " UPDATE aqorders SET tax_value_on_ordering = quantity * ecost_tax_excluded * tax_rate_on_ordering, tax_value_on_receiving = quantity * unitprice_tax_excluded * tax_rate_on_receiving WHERE ordernumber = ? "] at /home/vagrant/kohaclone/C4/Acquisition.pm line 1484. # No tests run! t/db_dependent/Acquisition.t .. 71/71 # Failed test 'No tests run for subtest "ModReceiveOrder and subscription"' # at t/db_dependent/Acquisition.t line 748. DBD::mysql::db do failed: Out of range value for column 'tax_value_on_ordering' at row 1 [for Statement " UPDATE aqorders SET tax_value_on_ordering = quantity * ecost_tax_excluded * tax_rate_on_ordering, tax_value_on_receiving = quantity * unitprice_tax_excluded * tax_rate_on_receiving WHERE ordernumber = ? "] at /home/vagrant/kohaclone/C4/Acquisition.pm line 1484. # Looks like your test exited with 255 just after 71. t/db_dependent/Acquisition.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 1/71 subtests Test Summary Report ------------------- t/db_dependent/Acquisition.t (Wstat: 65280 Tests: 71 Failed: 1) Failed test: 71 Non-zero exit status: 255
Created attachment 81797 [details] [review] Bug 21467: Prevent tests to fail The following error is raised if TestBuilder generates too big numbers: Out of range value for column 'tax_value_on_ordering' UPDATE aqorders SET tax_value_on_ordering = quantity * ecost_tax_excluded * tax_rate_on_ordering, tax_value_on_receiving = quantity * unitprice_tax_excluded * tax_rate_on_receiving WHERE ordernumber = ? "] at /home/vagrant/kohaclone/C4/Acquisition.pm line 1484.
Created attachment 81798 [details] [review] Bug 21467: (QA follow-up) Move hint a little bit
Created attachment 81799 [details] [review] Bug 21467: (follow-up) Display a summary line per parent_ordernumber Wrong resolution conflict
QA tool green, tests tool pass now. Acq tab in subscription detail works correctly.
Created attachment 81800 [details] [review] Bug 21474: Add the Koha::Subscription->frequency method And the 2 modules for the subscriptions' frequencies Test plan: prove t/db_dependent/Koha/Subscription.t must return green Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> https://bugs.koha-community.org/show_bug.cgi?id=21475 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 81801 [details] [review] Bug 21467: Allow several receipts for a given subscription When a new order is created from a subscription the quantity is set to 1 and cannot be modified. The idea was to order 1 subscription. This behavior leads to a limitation: it is not possible to mark a receipt as partially received. However it is how it works in real life, the vendors send invoices throughout the year. The number of items can also be changed. The idea is be to rethink the "quantity" value for an order created from a subscription and use it to track the number of invoices already paid. FIXME: This approach will not cohabit with standing orders. This patch is a first draft to get feedback on the idea. FIXME: What about cancelled orders? Test plan: - Create a new order from a subscription - Enter the number of items you think you will receive for this subscription (for instance 1 per month: 12) - Close the basket - Receive 3 items (a trimester) and create a specific invoice for this receipt. Note that the price are per unit. If you want to receive items with different prices you should make split the receipt - Receive more items. This time you will notice that the previous order will be displayed on the "order receive" under a new block "Receipt history for this subscription" - Note that the "Quantity to receive" has been decrease by the number of items you previously received - Also you can notice that this "Quantity to receive" can be modified. Indeed it can happen that the number of items to receive changed during the year - Go to the detail of the subscription and notice that the orders have been grouped by "parent ordernumber" - Continue to receive items until all have been received Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 81802 [details] [review] Bug 21467: Add treetable to subscription detail to group orders by parent ordernumber Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 81803 [details] [review] Bug 21467: Add subscription's info when ordering When ordering from a subscription, there is now a "hint" to display the number of issues and the frequency. It will be easier to estimate the quantity to receive. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 81804 [details] [review] Bug 21467: Do not erase the internal note of the first order For the subscription we would like to keep the original internal note (from the first order), to display it unmodified each time we receive issues. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 81805 [details] [review] Bug 21467: Display the quantity and adjust the amounts On the subscription detail view we should display the amounts depending on the quantity (can be different than 0 now!) Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 81806 [details] [review] Bug 21467: Fix default sort Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 81807 [details] [review] Bug 21467: Display a summary line per parent_ordernumber This will help to keep track of the different orders for a given subscription. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 81808 [details] [review] Bug 21467: (QA follow-up) Fix filter and variable declaration in .t Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 81809 [details] [review] Bug 21467: Prevent tests to fail The following error is raised if TestBuilder generates too big numbers: Out of range value for column 'tax_value_on_ordering' UPDATE aqorders SET tax_value_on_ordering = quantity * ecost_tax_excluded * tax_rate_on_ordering, tax_value_on_receiving = quantity * unitprice_tax_excluded * tax_rate_on_receiving WHERE ordernumber = ? "] at /home/vagrant/kohaclone/C4/Acquisition.pm line 1484. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 81810 [details] [review] Bug 21467: (QA follow-up) Move hint a little bit Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 81811 [details] [review] Bug 21467: (follow-up) Display a summary line per parent_ordernumber Wrong resolution conflict Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
I believe this is great in its flexibility and will work much better for acquisition of serials than the standing order feature. You will be able to handle an end-of-year invoice or being charged by issue. The amounts will be encumbered for the year. I think the only thing missing now would be an option to bring those orders into the next year, but the duplicate order line feature also waiting will help with that :)
Created attachment 82117 [details] View of receipt page The language here is confusing in english, could: Quantity to receive be: Quantity outstanding or do you have another suggestion? the two receive/received is confusing
The terms haven't changed with these patches. Should we fix here or discuss a better wording in a separate bug?
Katrin makes a fair point about keeping this bug on-task and letting wording questions go elsewhere, but: I agree that receive/received gets confusing quickly in spoken English. "Outstanding" works but is not the most common usage. I'd go with "Quantity expected" or "Quantity ordered."
(In reply to Andrew from comment #54) > Katrin makes a fair point about keeping this bug on-task and letting wording > questions go elsewhere, but: > I agree that receive/received gets confusing quickly in spoken English. > "Outstanding" works but is not the most common usage. I'd go with "Quantity > expected" or "Quantity ordered." I could write a follow-up. Maybe we could say Quantity delivered instead of expected?
Created attachment 82122 [details] [review] Bug 21467: Allow several receipts for a given subscription When a new order is created from a subscription the quantity is set to 1 and cannot be modified. The idea was to order 1 subscription. This behavior leads to a limitation: it is not possible to mark a receipt as partially received. However it is how it works in real life, the vendors send invoices throughout the year. The number of items can also be changed. The idea is be to rethink the "quantity" value for an order created from a subscription and use it to track the number of invoices already paid. FIXME: This approach will not cohabit with standing orders. This patch is a first draft to get feedback on the idea. FIXME: What about cancelled orders? Test plan: - Create a new order from a subscription - Enter the number of items you think you will receive for this subscription (for instance 1 per month: 12) - Close the basket - Receive 3 items (a trimester) and create a specific invoice for this receipt. Note that the price are per unit. If you want to receive items with different prices you should make split the receipt - Receive more items. This time you will notice that the previous order will be displayed on the "order receive" under a new block "Receipt history for this subscription" - Note that the "Quantity to receive" has been decrease by the number of items you previously received - Also you can notice that this "Quantity to receive" can be modified. Indeed it can happen that the number of items to receive changed during the year - Go to the detail of the subscription and notice that the orders have been grouped by "parent ordernumber" - Continue to receive items until all have been received Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 82123 [details] [review] Bug 21467: Add treetable to subscription detail to group orders by parent ordernumber Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 82124 [details] [review] Bug 21467: Add subscription's info when ordering When ordering from a subscription, there is now a "hint" to display the number of issues and the frequency. It will be easier to estimate the quantity to receive. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 82125 [details] [review] Bug 21467: Do not erase the internal note of the first order For the subscription we would like to keep the original internal note (from the first order), to display it unmodified each time we receive issues. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 82126 [details] [review] Bug 21467: Display the quantity and adjust the amounts On the subscription detail view we should display the amounts depending on the quantity (can be different than 0 now!) Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 82127 [details] [review] Bug 21467: Fix default sort Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 82128 [details] [review] Bug 21467: Display a summary line per parent_ordernumber This will help to keep track of the different orders for a given subscription. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 82129 [details] [review] Bug 21467: (QA follow-up) Fix filter and variable declaration in .t Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 82130 [details] [review] Bug 21467: Prevent tests to fail The following error is raised if TestBuilder generates too big numbers: Out of range value for column 'tax_value_on_ordering' UPDATE aqorders SET tax_value_on_ordering = quantity * ecost_tax_excluded * tax_rate_on_ordering, tax_value_on_receiving = quantity * unitprice_tax_excluded * tax_rate_on_receiving WHERE ordernumber = ? "] at /home/vagrant/kohaclone/C4/Acquisition.pm line 1484. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 82131 [details] [review] Bug 21467: (QA follow-up) Move hint a little bit Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 82132 [details] [review] Bug 21467: (follow-up) Display a summary line per parent_ordernumber Wrong resolution conflict Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Rebased - number of tests and changes on the order receive form (added hints from Bug 21619)
Suggestion for template change on Bug 21799 - Change wording for quantity input fields on order receive page
Awesome work all! Pushed to master for 18.11
New Feature, will not be backported to 18.05.x series.
The pre-release notes for 19.05 show this bug report - maybe a follow-up pushed after release? https://gitlab.com/koha-community/koha-release-notes/blob/master/release_notes_18_12_00.md