We deprecated C4::Accounts::manualinvoice in bug 21756, this bug is a placeholder to ensure it's removed when appropriate.
We have been warning via a deprecation warning since the release of 19.05.00.. with the release of 20.11 it will make 18 months of the warning having been fired so I think we're safe to remove it now
This was a nice example of the use of the deprecated method from Mojo::Utils to give warning of a method being removed prior to it's actual removal.. I wonder.. did people find this helpful and should we adopt the practice more widely?
Created attachment 108588 [details] [review] Bug 22394: Remove C4::Accounts::manualinvoice This patch removes C4::Accounts::manualinvoice and it's corresponding test. We have been warning deprecation of this method for 18 months (by the time of 20.11 release). Test plan 1/ Apply patch 2/ Ensure no mention of manualinvoice accross the codebase
Patch no longer applies 8-( Notes for testing: - Find usage of manualinvoice: git grep manualinvoice - Search before applying patch - After apply patch should be no occurrences
Created attachment 111991 [details] [review] Bug 22394: Remove C4::Accounts::manualinvoice This patch removes C4::Accounts::manualinvoice and it's corresponding test. We have been warning deprecation of this method for 18 months (by the time of 20.11 release). Test plan 1/ Apply patch 2/ Ensure no mention of manualinvoice accross the codebase 3/ Run t/db_dependant/Accounts.t and ensure it still passes
Created attachment 112259 [details] [review] Bug 22394: Remove C4::Accounts::manualinvoice This patch removes C4::Accounts::manualinvoice and it's corresponding test. We have been warning deprecation of this method for 18 months (by the time of 20.11 release). Test plan 1/ Apply patch 2/ Ensure no mention of manualinvoice accross the codebase 3/ Run t/db_dependant/Accounts.t and ensure it still passes Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi>
Created attachment 112361 [details] [review] Bug 22394: Remove C4::Accounts::manualinvoice This patch removes C4::Accounts::manualinvoice and it's corresponding test. We have been warning deprecation of this method for 18 months (by the time of 20.11 release). Test plan 1/ Apply patch 2/ Ensure no mention of manualinvoice accross the codebase 3/ Run t/db_dependant/Accounts.t and ensure it still passes Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 20.11, thanks to everybody involved!
enhancement will not be backported to 20.05.x