Tested on 18.11.01 and 18.11.03 If you have an order for multiple copies and only receipt one or more of those copies but not the entire number, and edit the internal note field on the invoice screen, the internal note field then updates every order on the system. The internal note is applied to all orders but also it overwrites any other note that was there.
Data loss bug - updating severity.
Looks like this was caused by bug 21467. There's a really clear mistake in the Update statement that's called in that it's missing a WHERE clause... Ooops.
Created attachment 86965 [details] [review] Bug 22565: Do NOT replace all internalnote's on receive Bug 21467 introduced a but whereby setting any order_internalnote on receive one would end up setting all orders to have that internalnote. This patch adds the missing WHERE clause to the database query which was likely lost during a rebase? Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 86966 [details] [review] Bug 22565: Add test for ModReceiveOrder regression This test checks that order_internalnote is only updated for the given orderline in ModReceiveOrder. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 86967 [details] [review] Bug 22565: Do NOT replace all internalnote's on receive Bug 21467 introduced a but whereby setting any order_internalnote on receive one would end up setting all orders to have that internalnote. This patch adds the missing WHERE clause to the database query which was likely lost during a rebase? Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 86968 [details] [review] Bug 22565: Add test for ModReceiveOrder regression This test checks that order_internalnote is only updated for the given orderline in ModReceiveOrder. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 86969 [details] [review] Bug 22565: (QA follow-up) Fix test Acquisition.t Test plan: prove t/db_dependent/Acquisition.t should pass Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 86970 [details] [review] Bug 22565: (QA follow-up) Fix test Acquisition.t Test plan: prove t/db_dependent/Acquisition.t should pass Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Thanks Josef, looking good.
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.04
missing dependency for 18.05.x, not backporting.