'Do not notify' in messages sort of hints that messages will be prevented, however, when checked it simply clear the other boxes. Hold notices wil generate print even when nothing is selected, so we shouldn't imply that there is an 'Opt out'/'Do not notify' (see bug 5501 for that) The goal of this bug is to simply rename this option
Created attachment 88357 [details] [review] Bug 22744: Rename 'Do no notify' to 'Clear' To test: 1 - Enable enhanced messaging prefs 2 - Allow users to set their messaging on the opac 3 - Edit a patron and check 'Do not notify' 4 - Save and note the box is empty if editing again 5 - Same on opac 6 - Apply patch 7 - Repeat and note the option now says 'Clear' 8 - Confirm this makes more sense
Created attachment 88534 [details] [review] Bug 22744: Rename 'Do no notify' to 'Clear' To test: 1 - Enable enhanced messaging prefs 2 - Allow users to set their messaging on the opac 3 - Edit a patron and check 'Do not notify' 4 - Save and note the box is empty if editing again 5 - Same on opac 6 - Apply patch 7 - Repeat and note the option now says 'Clear' 8 - Confirm this makes more sense Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Created attachment 88535 [details] [review] Bug 22774 - (QA follow-up) make "clear" a little more specific Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Not to nit-pick, but wouldn't make more sense for this to be a button or link that clears the check boxes? It's kind of weird to have a checkbox do this. Especially since the checkbox isn't going to retain a setting.
It's a little long. Maybe "Clear preferences" would work too? I think the reason it's not a button is that you still need to save the changes. Maybe a "Clear settings" or "Clear preferences" link like we have on the z39.50 form?
Created attachment 90454 [details] [review] Bug 22744: Make checkboxes links
Sorry, still not quite happy: The table is labelled "messaging preferences" but the colunn uses "notification perference". I think it's prefer to have it just say "Clear", but if we want the longer version, it should use the same terminology (think translators). Should the days in advance be reset? I feel it's not strictly necessary, but noting. Please also fix the subject line on the second patch!
It might be questionable if we need the column at all? There are not that many columns to not be able to uncheck them quickly. (just a side note as this feature seems more confusing than helpful atm)
bug 5501 seems a possible duplicate (just found it by accident, didn't read all the discussion)
Created attachment 90568 [details] [review] Bug 22744: Name the column clear
Created attachment 90569 [details] [review] Bug 22744: Rename 'Do no notify' to 'Clear' To test: 1 - Enable enhanced messaging prefs 2 - Allow users to set their messaging on the opac 3 - Edit a patron and check 'Do not notify' 4 - Save and note the box is empty if editing again 5 - Same on opac 6 - Apply patch 7 - Repeat and note the option now says 'Clear' 8 - Confirm this makes more sense Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Created attachment 90570 [details] [review] Bug 22774 - (QA follow-up) make "clear" a little more specific Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Created attachment 90571 [details] [review] Bug 22744: Make checkboxes links
Created attachment 90572 [details] [review] Bug 22744: Name the column clear
Created attachment 90574 [details] [review] Bug 22744: [alternate] Remove the 'do not notify' buttons These checkboxes are simply a way to clear the prefs before editing. We are not saving a lot of click, and we are confusing people, this patch simply removes them To test: 1 - Edit a patron's messaging preferences 2 - Think too hard about the 'Do not notify' boxes 3 - Feel confused 4 - Apply this patch 5 - Edit a patron's messaging preferences 6 - Confirm it feels better
(In reply to Katrin Fischer from comment #9) > bug 5501 seems a possible duplicate (just found it by accident, didn't read > all the discussion) Bug 5501 goes the other way - it seeks to actually add a way to prevent sending notifications to the patron all together. Actually implementing 'Do not notify' as an option and not a clear button
So this is more of a 'Reset to defaults' type option right? Katrin.. are you keen on the alternative or would you prefer the original but worded as accurately as possible.. I'm confused..
Created attachment 92642 [details] [review] Bug 22744: Rename 'Do no notify' to 'Clear' To test: 1 - Enable enhanced messaging prefs 2 - Allow users to set their messaging on the opac 3 - Edit a patron and check 'Do not notify' 4 - Save and note the box is empty if editing again 5 - Same on opac 6 - Apply patch 7 - Repeat and note the option now says 'Clear' 8 - Confirm this makes more sense Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 92643 [details] [review] Bug 22744: Rename 'Do no notify' to 'Clear' To test: 1 - Enable enhanced messaging prefs 2 - Allow users to set their messaging on the opac 3 - Edit a patron and check 'Do not notify' 4 - Save and note the box is empty if editing again 5 - Same on opac 6 - Apply patch 7 - Repeat and note the option now says 'Clear' 8 - Confirm this makes more sense Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 92644 [details] [review] Bug 22774 - (QA follow-up) make "clear" a little more specific Signed-off-by: Liz Rea <wizzyrea@gmail.com> https://bugs.koha-community.org/show_bug.cgi?id=22744 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 92645 [details] [review] Bug 22744: Make checkboxes links Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 92646 [details] [review] Bug 22744: Name the column clear Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 92647 [details] [review] Bug 22744: [alternate] Remove the 'do not notify' buttons These checkboxes are simply a way to clear the prefs before editing. We are not saving a lot of click, and we are confusing people, this patch simply removes them To test: 1 - Edit a patron's messaging preferences 2 - Think too hard about the 'Do not notify' boxes 3 - Feel confused 4 - Apply this patch 5 - Edit a patron's messaging preferences 6 - Confirm it feels better Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Both versions are good imo. Leaving it to the RM to decide imo :)
I prefer the 'alternate'.. i.e. removing the column altogether pending 5501 being worked on to properly implement the feature... however.. that patch needs some more work as it does not currently include the OPAC.
Hi, Thanks to rebase this patch for testing. Bug 22744 - 'Do not notify' is really a 'Clear' option 92643 - Bug 22744: Rename 'Do no notify' to 'Clear' 92644 - Bug 22774 - (QA follow-up) make "clear" a little more specific 92645 - Bug 22744: Make checkboxes links 92646 - Bug 22744: Name the column clear 92647 - Bug 22744: [alternate] Remove the 'do not notify' buttons Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 22744: Rename 'Do no notify' to 'Clear' Applying: Bug 22774 - (QA follow-up) make "clear" a little more specific Applying: Bug 22744: Make checkboxes links Applying: Bug 22744: Name the column clear Applying: Bug 22744: [alternate] Remove the 'do not notify' buttons Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc error: Failed to merge in the changes. Patch failed at 0001 Bug 22744: [alternate] Remove the 'do not notify' buttons The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-22744-alternate-Remove-the-do-not-notify-butto-rf3GDD.patch Bouzid.
Created attachment 93109 [details] [review] Bug 22744: Remove the 'do not notify' buttons These checkboxes are simply a way to clear the prefs before editing. We are not saving a lot of click, and we are confusing people, this patch simply removes them To test: 1 - Edit a patron's messaging preferences 2 - Think too hard about the 'Do not notify' boxes 3 - Feel confused 4 - Apply this patch 5 - Edit a patron's messaging preferences 6 - Confirm it feels better Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 93114 [details] [review] Bug 22744: Remove the 'do not notify' buttons These checkboxes are simply a way to clear the prefs before editing. We are not saving a lot of click, and we are confusing people, this patch simply removes them To test: 1 - Edit a patron's messaging preferences 2 - Think too hard about the 'Do not notify' boxes 3 - Feel confused 4 - Apply this patch 5 - Edit a patron's messaging preferences 6 - Confirm it feels better Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 93115 [details] [review] Bug 22744: Changes for opac and remove JS
Nice work! Pushed to master for 19.11.00
Pushed to 19.05.x for 19.05.04
backported to 18.11.x for 18.11.11