When looking at the enhanced messages for patrons there is a 'do not notify' option - which is basically the same as not checking any messaging choices - so why do we need that option at all? I recommend removing it since it's confusing.
This still confuses people in training.
Libraries still reporting confusion over this feature.
We have confusion as well. The worst thing is that it actually doesn't do what it says. We still have print messages even if the "do not notify"-option is used. Looking into adding a new message-transport-type "do not notify" used to catch that. So instead of clicking an "clear"-button in the GUI we actually select a viable transport alternative overriding message sending behaviour. Sometimes the message_transport_type defaults to print if no transport is defined.
Created attachment 35413 [details] [review] Bug 5501 - Improve the 'do not notify' option Introducing the message_transport_type 'none' and enabling it for all messages. Enabling print-option for "HOLD Fulfilled". Print option can be added for other messages as well, but HOLD seems to make the most sense.
Created attachment 35414 [details] [review] Bug 5501 - Improve the 'do not notify' option. HOLD-letter. TEST PLAN: 1. Find a Borrower and edit "Patron messaging preferences". 2. Check the "Do not notify" for "Hold filled" -letter. 3. Check any other checkboxes for "Hold filled" -letter. The "Do not notify"-checkbox should get unchecked. 4. Check the "Do not notify" -checkbox again for the "Hold filled" -letter. Other selections for the row get unchecked. 5. Save changes. 6. Make a hold for a borrower. 7. Check-in the reserved Item and catch the hold. 8. In the notices-tab for the Borrower, there should be no message for the borrower about getting the caught Hold.
This feature is about enabling explicit message rejection for selectable message types. Default behaviour is only overridden if the "Do not notify"-checkbox is checked.
Is this patch ready to be tested ? If yes, we need to set as "Needs sign-off"
Zeno, this feature is ready to be tested regarding the patches I made, but this is still missing a lot more message types. I need to take a look at our acquisitions department as they report severe slowdowns in the acquisitions process (and a ton of stuff) so I'll let you sign off these if you want. But followups need to be provided for the other message_types.
But I feel like this is a good start for improving on this feature.
When I applied the patches, it got rid of all the checkboxes for Do not notify completely so I can't check or uncheck the boxes to test. I feel like this wasn't the preferred outcome?
Hi there and thanks for testing this! Did you run the updatedatabase.pl-script? I think I should have mentioned it in the TEST PLAN, but I have a bad habit of not doing so :) Thanks for reminding me!
Created attachment 46566 [details] [review] Bug 5501 - Improve the 'do not notify' option. HOLD-letter. TEST PLAN: 1. Find a Borrower and edit "Patron messaging preferences". 2. Check the "Do not notify" for "Hold filled" -letter. 3. Check any other checkboxes for "Hold filled" -letter. The "Do not notify"-checkbox should get unchecked. 4. Check the "Do not notify" -checkbox again for the "Hold filled" -letter. Other selections for the row get unchecked. 5. Save changes. 6. Make a hold for a borrower. 7. Check-in the reserved Item and catch the hold. 8. In the notices-tab for the Borrower, there should be no message for the borrower about getting the caught Hold. Signed-off-by: Aleisha <aleishaamohia@hotmail.com>
Olli, is it still valid? As it, it cannot be pushed to master, it should be done for any letter types if we want it. Moreover, there is now a "none" message transport type when editing letter templates, I am not sure it removes confusion :)
Be nice to get this moving again.. is anyone tempted to adopt it?
It looks like this is resolved as bug 22744 removed the 'Do not notify' column altogether.