Bug 5501 - Improve the 'do not notify' option
Summary: Improve the 'do not notify' option
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Kyle M Hall
QA Contact: Bugs List
URL:
Keywords:
Depends on: 22744
Blocks: 22745
  Show dependency treegraph
 
Reported: 2010-12-15 15:23 UTC by Nicole C. Engard
Modified: 2023-12-28 20:42 UTC (History)
9 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 5501 - Improve the 'do not notify' option (8.84 KB, patch)
2015-01-20 18:07 UTC, Olli-Antti Kivilahti
Details | Diff | Splinter Review
Bug 5501 - Improve the 'do not notify' option. HOLD-letter. (1.30 KB, patch)
2015-01-20 19:01 UTC, Olli-Antti Kivilahti
Details | Diff | Splinter Review
Bug 5501 - Improve the 'do not notify' option. HOLD-letter. (1.35 KB, patch)
2016-01-12 22:54 UTC, Aleisha Amohia
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2010-12-15 15:23:08 UTC
When looking at the enhanced messages for patrons there is a 'do not notify' option - which is basically the same as not checking any messaging choices - so why do we need that option at all? I recommend removing it since it's confusing.
Comment 1 Nicole C. Engard 2013-01-23 13:09:07 UTC
This still confuses people in training.
Comment 2 Danielle Elder 2014-04-10 19:41:12 UTC
Libraries still reporting confusion over this feature.
Comment 3 Olli-Antti Kivilahti 2015-01-20 16:45:38 UTC
We have confusion as well. The worst thing is that it actually doesn't do what it says. We still have print messages even if the "do not notify"-option is used.

Looking into adding a new message-transport-type "do not notify" used to catch that. So instead of clicking an "clear"-button in the GUI we actually select a viable transport alternative overriding message sending behaviour.

Sometimes the message_transport_type defaults to print if no transport is defined.
Comment 4 Olli-Antti Kivilahti 2015-01-20 18:07:06 UTC
Created attachment 35413 [details] [review]
Bug 5501 - Improve the 'do not notify' option

Introducing the message_transport_type 'none' and enabling it for all messages.
Enabling print-option for "HOLD Fulfilled".
Print option can be added for other messages as well, but HOLD seems to make
the most sense.
Comment 5 Olli-Antti Kivilahti 2015-01-20 19:01:29 UTC Comment hidden (obsolete)
Comment 6 Olli-Antti Kivilahti 2015-01-20 19:03:23 UTC
This feature is about enabling explicit message rejection for selectable message types. Default behaviour is only overridden if the "Do not notify"-checkbox is checked.
Comment 7 Zeno Tajoli 2015-01-21 07:40:53 UTC
Is this patch ready to be tested ? 
If yes, we need to set as "Needs sign-off"
Comment 8 Olli-Antti Kivilahti 2015-01-21 16:38:27 UTC
Zeno, this feature is ready to be tested regarding the patches I made, but this is still missing a lot more message types.

I need to take a look at our acquisitions department as they report severe slowdowns in the acquisitions process (and a ton of stuff) so I'll let you sign off these if you want. But followups need to be provided for the other message_types.
Comment 9 Olli-Antti Kivilahti 2015-01-21 16:39:12 UTC
But I feel like this is a good start for improving on this feature.
Comment 10 Aleisha Amohia 2015-01-22 21:53:00 UTC
When I applied the patches, it got rid of all the checkboxes for Do not notify completely so I can't check or uncheck the boxes to test. I feel like this wasn't the preferred outcome?
Comment 11 Olli-Antti Kivilahti 2015-01-26 10:12:23 UTC
Hi there and thanks for testing this!

Did you run the updatedatabase.pl-script?

I think I should have mentioned it in the TEST PLAN, but I have a bad habit of not doing so :)
Thanks for reminding me!
Comment 12 Aleisha Amohia 2016-01-12 22:54:09 UTC
Created attachment 46566 [details] [review]
Bug 5501 - Improve the 'do not notify' option. HOLD-letter.

TEST PLAN:
1. Find a Borrower and edit "Patron messaging preferences".
2. Check the "Do not notify" for "Hold filled" -letter.
3. Check any other checkboxes for "Hold filled" -letter.
    The "Do not notify"-checkbox should get unchecked.
4. Check the "Do not notify" -checkbox again for the "Hold filled" -letter.
    Other selections for the row get unchecked.
5. Save changes.
6. Make a hold for a borrower.
7. Check-in the reserved Item and catch the hold.
8. In the notices-tab for the Borrower, there should be no message for the
   borrower about getting the caught Hold.

Signed-off-by: Aleisha <aleishaamohia@hotmail.com>
Comment 13 Jonathan Druart 2016-01-13 10:25:39 UTC
Olli, is it still valid?
As it, it cannot be pushed to master, it should be done for any letter types if we want it.
Moreover, there is now a "none" message transport type when editing letter templates, I am not sure it removes confusion :)
Comment 14 Martin Renvoize 2019-07-16 13:32:48 UTC
Be nice to get this moving again.. is anyone tempted to adopt it?
Comment 15 Katrin Fischer 2023-01-07 23:16:22 UTC
It looks like this is resolved as bug 22744 removed the 'Do not notify' column altogether.