Bug 22203 changed the behavior on the hold-found2 modal that pops up when a hold is found so that whether or not the patron's name is displayed is now governed by the HidePatronName system preference. However, if a hold is confirmed and you check the item in a second time, the modal that pops up is hold-found1 and whether or not the patron's name is displayed in the hold-found1 modal is not governed by the HidePatronName system preference. For the sake of consistency, the display of the patron's name on hold-found2 and hold-found1 should both be governed by the HidePatronName system preference.
Created attachment 94104 [details] [review] Bug 22814: Make patron names on holds modal consistent (second check-in) Bug 22203 changed the behavior on the hold-found2 modal that pops up when a hold is found so that whether or not the patron's name is displayed is now governed by the HidePatronName system preference. However, if a hold is confirmed and you check the item in a second time, the modal that pops up is hold-found1 and whether or not the patron's name is displayed in the hold-found1 modal is not governed by the HidePatronName system preference. For the sake of consistency, the display of the patron's name on hold-found2 and hold-found1 should both be governed by the HidePatronName system preference. To test: - Place a hold on an item - Check in the item to trigger the hold modal - Confirm hold - Check the item in again - verify name of patron displays - Apply patch - Repeat - Verify name display now matches between the two modals - change HidePatronName pref - Repeat - Name display should still match
Created attachment 94213 [details] [review] Bug 22814: Make patron names on holds modal consistent (second check-in) Bug 22203 changed the behavior on the hold-found2 modal that pops up when a hold is found so that whether or not the patron's name is displayed is now governed by the HidePatronName system preference. However, if a hold is confirmed and you check the item in a second time, the modal that pops up is hold-found1 and whether or not the patron's name is displayed in the hold-found1 modal is not governed by the HidePatronName system preference. For the sake of consistency, the display of the patron's name on hold-found2 and hold-found1 should both be governed by the HidePatronName system preference. To test: - Place a hold on an item - Check in the item to trigger the hold modal - Confirm hold - Check the item in again - verify name of patron displays - Apply patch - Repeat - Verify name display now matches between the two modals - change HidePatronName pref - Repeat - Name display should still match Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 94937 [details] [review] Bug 22814: Make patron names on holds modal consistent (second check-in) Bug 22203 changed the behavior on the hold-found2 modal that pops up when a hold is found so that whether or not the patron's name is displayed is now governed by the HidePatronName system preference. However, if a hold is confirmed and you check the item in a second time, the modal that pops up is hold-found1 and whether or not the patron's name is displayed in the hold-found1 modal is not governed by the HidePatronName system preference. For the sake of consistency, the display of the patron's name on hold-found2 and hold-found1 should both be governed by the HidePatronName system preference. To test: - Place a hold on an item - Check in the item to trigger the hold modal - Confirm hold - Check the item in again - verify name of patron displays - Apply patch - Repeat - Verify name display now matches between the two modals - change HidePatronName pref - Repeat - Name display should still match Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Nice work! Pushed to master for 19.11.00