During the checkin process, all the message info is completely obscured by any modal forms that may be triggered by the checkin. In some cases that info could be vital to making an informed decision as to what option to choose in the modal itself.
Screencast example: https://monosnap.com/file/zHNCgXuEg0eG1BOb3hdKpIRlKnra4O
We circulate hotspots, and when a device is 4 days overdue, we mark it lost and damaged and turn off the service. When these hotspots are returned, a hold will trigger (they are a high-demand item), but if the item has been deactivated, staff often miss this and trap the hold. Moving the the modal so it does not obstruct these messages, or adding lost/damaged information to the modal would benefit us greatly. Thanks!
> adding > lost/damaged information to the modal would benefit us greatly. > +1 for this!
I've been working on a possible solution to this which moves check-in messages into the confirmation modals. I've posted a brief video here of how it looks: https://zivotdesign.com/p/uploads/big/3d6b8a24067f27a834d03b8e104d7a40.mp4 If there is no popup (no hold confirmation, no transfer), messages and/or errors will be displayed onscreen just like they have in the past. I'd love to hear opinions about it!
Owen, from a user-standpoint, your fix is brilliant and does what it needs to do. I can't speak to anything back-end. Thanks so much! -Marti
Owen, I am sure you have thought of this, (I have only watched your video) but we like to use custom sounds for different messages that the circ staff needs to know. To that end I am guessing you have added specific div or id so that we can use them to set up audio alerts. Ed
Ed I'll double-check but the template markup is mostly just re-arranged so sounds should still work.
(In reply to Owen Leonard from comment #4) > I've been working on a possible solution to this which moves check-in > messages into the confirmation modals. I've posted a brief video here > of how it looks: > > https://zivotdesign.com/p/uploads/big/3d6b8a24067f27a834d03b8e104d7a40.mp4 > > If there is no popup (no hold confirmation, no transfer), messages and/or > errors will be displayed onscreen just like they have in the past. > > I'd love to hear opinions about it! I like it!
Created attachment 92476 [details] [review] Bug 23039: Hold found modal on checkin screen ( circulation.pl ) obscures Check in message info Bug 23039: Hold found modal on checkin screen ( circulation.pl ) obscures Check in message info This patch modifies the checkin process so that any errors or messages related to the current checkin are displayed in any hold/transit modal which is displayed. This prevents any information from being hidden by the modal. This patch also adds an "information" button to the checkout form which the user can click to redisplay the last modal which was dismissed (unless confirming the modal reloads the page). To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Test the checkin process with various types of items: - Item not checked out - Item not checked out, on hold - Item not checked out, needs to be transferred - Item is marked lost, needs to be transferred - Item checked out, patron has waiting holds (with WaitingNotifyAtCheckin enabled) - Item checked out, patron has outstanding fines (with FineNotifyAtCheckin enabled) - Test that the modal redisplay button works in cases where the modal is dismissed without triggering a page reload: - Hold confirmation -> Ignore - Transfer confirmation -> OK
Created attachment 92481 [details] [review] Bug 23039: Hold found modal on checkin screen ( circulation.pl ) obscures Check in message info This patch modifies the checkin process so that any errors or messages related to the current checkin are displayed in any hold/transit modal which is displayed. This prevents any information from being hidden by the modal. This patch also adds an "information" button to the checkout form which the user can click to redisplay the last modal which was dismissed (unless confirming the modal reloads the page). To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Test the checkin process with various types of items: - Item not checked out - Item not checked out, on hold - Item not checked out, needs to be transferred - Item is marked lost, needs to be transferred - Item checked out, patron has waiting holds (with WaitingNotifyAtCheckin enabled) - Item checked out, patron has outstanding fines (with FineNotifyAtCheckin enabled) - Test that the modal redisplay button works in cases where the modal is dismissed without triggering a page reload: - Hold confirmation -> Ignore - Transfer confirmation -> OK
Created attachment 92514 [details] [review] Bug 23039: Hold found modal on checkin screen ( circulation.pl ) obscures Check in message info This patch modifies the checkin process so that any errors or messages related to the current checkin are displayed in any hold/transit modal which is displayed. This prevents any information from being hidden by the modal. This patch also adds an "information" button to the checkout form which the user can click to redisplay the last modal which was dismissed (unless confirming the modal reloads the page). To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Test the checkin process with various types of items: - Item not checked out - Item not checked out, on hold - Item not checked out, needs to be transferred - Item is marked lost, needs to be transferred - Item checked out, patron has waiting holds (with WaitingNotifyAtCheckin enabled) - Item checked out, patron has outstanding fines (with FineNotifyAtCheckin enabled) - Test that the modal redisplay button works in cases where the modal is dismissed without triggering a page reload: - Hold confirmation -> Ignore - Transfer confirmation -> OK Signed-off-by: Kyle Hall <kyle@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 92515 [details] [review] Bug 23039: Don't hide the checkin dialogs Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
I like this one Owen, I didn't like the way the dialogs disappeared when the modal appeared though. I am wondering if we can simply leave them in place? While we can bring the modal back up, it might be nice to keep the messages in place. I tried making them show on modal hide, but that added more page flicker Feel free to SO or obsolete my follow-up, I won't argue strongly
(In reply to Nick Clemens from comment #13) > I like this one Owen, I didn't like the way the dialogs disappeared when the > modal appeared though. I am wondering if we can simply leave them in place? > While we can bring the modal back up, it might be nice to keep the messages > in place. I tried making them show on modal hide, but that added more page > flicker > > Feel free to SO or obsolete my follow-up, I won't argue strongly Owen, could you take a look please? (Back to signed off after, please :) )
(In reply to Nick Clemens from comment #13) > I am wondering if we can simply leave them in place? I don't have a problem with doing it this way.
Created attachment 93047 [details] [review] Bug 23039: Hold found modal on checkin screen ( circulation.pl ) obscures Check in message info This patch modifies the checkin process so that any errors or messages related to the current checkin are displayed in any hold/transit modal which is displayed. This prevents any information from being hidden by the modal. This patch also adds an "information" button to the checkout form which the user can click to redisplay the last modal which was dismissed (unless confirming the modal reloads the page). To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Test the checkin process with various types of items: - Item not checked out - Item not checked out, on hold - Item not checked out, needs to be transferred - Item is marked lost, needs to be transferred - Item checked out, patron has waiting holds (with WaitingNotifyAtCheckin enabled) - Item checked out, patron has outstanding fines (with FineNotifyAtCheckin enabled) - Test that the modal redisplay button works in cases where the modal is dismissed without triggering a page reload: - Hold confirmation -> Ignore - Transfer confirmation -> OK Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com>
Created attachment 93048 [details] [review] Bug 23039: Don't hide the checkin dialogs Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com>
Created attachment 93598 [details] [review] Bug 23039: Hold found modal on checkin screen ( circulation.pl ) obscures Check in message info This patch modifies the checkin process so that any errors or messages related to the current checkin are displayed in any hold/transit modal which is displayed. This prevents any information from being hidden by the modal. This patch also adds an "information" button to the checkout form which the user can click to redisplay the last modal which was dismissed (unless confirming the modal reloads the page). To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Test the checkin process with various types of items: - Item not checked out - Item not checked out, on hold - Item not checked out, needs to be transferred - Item is marked lost, needs to be transferred - Item checked out, patron has waiting holds (with WaitingNotifyAtCheckin enabled) - Item checked out, patron has outstanding fines (with FineNotifyAtCheckin enabled) - Test that the modal redisplay button works in cases where the modal is dismissed without triggering a page reload: - Hold confirmation -> Ignore - Transfer confirmation -> OK Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 93599 [details] [review] Bug 23039: Don't hide the checkin dialogs Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Nice work! Pushed to master for 19.11.00
Any chance this will get backported to 19.05? Thanks, Marti Fuerst
missing dependencies for 19.05.x, no backport